Clean Coding - Common Sense

[cbk1994]

Originally Posted by Chompy

Someone (Well, a couple) told me to change my styling so...

PHP Code:

public function Hurt(damage, attacker, hurtani) {
  temp.conditionsok = ((this.clientr.hp > 0 && this.clientr.dead == false && level.nopk == false && this.client.nopk == false) ? true : false);
  if (temp.conditionsok) {

    if (temp.damage => this.clientr.hp) {
      this.clientr.hp = 0;
      this.Kill(temp.attacker); 
      this.showHp(7);
      return NULL;
    }
    if (temp.hurtani)
      this.setani("hurt", NULL);

    this.clientr.lastattacker = temp.attacker;
    this.clientr.hp -= abs(temp.damage);
    this.showHp(7);
    return NULL;
  }
} 


(Based of RW's script)

I've never seen of return NULL. Any different from return false;?

--

There's more to scripting than you reading it. It needs to be legible for others too.