Clean Coding - Common Sense

[Inverness]

Ah, no wonder I had that array problem that time, oh well, it can be easily be fixed.

PHP Code:

function onCreated() {
  temp.rawr = 0;
  rawr = 3;
  echo("1:" @ rawr);
  echo("2:" @ temp.rawr);
} 


Returns 3 in both cases, problem solved.

Edit:
It doesn't look pretty anymore though

[Skyld]

Originally Posted by Inverness

Ah, no wonder I had that array problem that time, oh well, it can be easily be fixed.

PHP Code:

function onCreated() {
  temp.rawr = 0;
  rawr = 3;
  echo("1:" @ rawr);
  echo("2:" @ temp.rawr);
} 


Returns 3 in both cases, problem solved.

Edit:
It doesn't look pretty anymore though

I'm not sure why you are trying to manage the variables anyway. The engine's meant to do that for you, and if your functions are structured sensibly, it should be obvious which variable names you are using.

[Inverness]

Uh, I do this for the simple fact that I'm damn tired of typing temp. before every variable name, no other reason. I also like it better without temp., its more pretty like that. Also shortens the code in the long run.

[napo_p2p]

Originally Posted by Skyld

I'm not sure why you are trying to manage the variables anyway. The engine's meant to do that for you, and if your functions are structured sensibly, it should be obvious which variable names you are using.

I think it's more of a styling thing. So he doesn't have to write temp. all of the time.

EDIT: Ding Ding Ding!

[Skyld]

Originally Posted by Inverness

Uh, I do this for the simple fact that I'm damn tired of typing temp. before every variable name, no other reason. I also like it better without temp., its more pretty like that.

Hm, in my opinion, it is better to always prefix variables. That way, there is no confusion as to which scope you are working in.

I try to write my scripts for people who have to work with them as well as for myself.

[Inverness]

Originally Posted by Skyld

Hm, in my opinion, it is better to always prefix variables. That way, there is no confusion as to which scope you are working in.

I try to write my scripts for people who have to work with them as well as for myself.

For myself, I only do this no-prefixing thing for temp variables, like how local variables in Java usually go without a prefix. So there is no confusion for myself. But also, all the temp variables are declared at the beginning so you know them already.

Edit:
I would like it if un-prefixed variables defaulted to temp. rather than a global if no previous temp. or this. variables were found.

[Skyld]

Originally Posted by Inverness

For myself, I only do this no-prefixing thing for temp variables, like how local variables in Java usually go without a prefix. So there is no confusion for myself. But also, all the temp variables are declared at the beginning so you know them already.

My point is not so much whether it's solely clear to you, but also to other people who are reading the script who might not be as good at scripting as you or I. A lot of people have difficulty getting their heads around variable declarations, and even more people have difficulty identifying differences between scopes. If everything temporary is prefixed, there's no confusion. If you list things as temp. and then don't use temp. in the rest of the function, that seems slightly misleading. :|

There's more to styling than whether it looks pretty or not; it's about catering for other people who may wish to edit the script or read it. It's for that reason that we prefer people to style scripts before posting asking for help with them here.

[Inverness]

You have a good point.
Though on Aeon, Napo and myself are the only major scripters and hes easily skilled enough to not be confused in any way.
Though I suppose when I release some of my stuff to public I will restyle it...
However until then nobody needs to be lookin' at my stuff :P

/sign for un-prefixed variables going temp and not global.

[cbk1994]

Clean coding looks prettier anyway

[Rapidwolve]

I recently have been practicing better organization and clean coding in my scripts, heres a snippet.

PHP Code:

public function Hurt(damage, attacker, hurtani){
  temp.conditionsok = ((this.clientr.hp > 0 && this.clientr.dead == false && level.nopk == false && this.client.nopk == false) ? true : false);
   if (temp.conditionsok){
       if (temp.damage => this.clientr.hp) {
        this.clientr.hp = 0;
        this.Kill(temp.attacker); 
        this.showHp(7);
        return;
       }
       if (temp.hurtani) this.setani("hurt", null);
          clientr.lastattacker = temp.attacker;
          this.clientr.hp -= abs(temp.damage);
          this.showHp(7);
    }
    return;
} 


[Gambet]

Yeah, your old method of not styling at all and scripting like this:

PHP Code:

function onCreated(){
player.chat="Rapid's styling sucks major wang";
setTimer(1);
}

function onTimeOut(){
this.yourstylingoldstylingsucks;;
chat="You grouped everything together without any spacing";
echo("And it was very annoying to read");
setTimer(1);
} 


Or something like that....



It was very annoying and barely legible.

[Bl0nkt]

Originally Posted by Gambet

Yeah, your old method of not styling at all and scripting like this:

PHP Code:

function onCreated(){
player.chat="Rapid's styling sucks major wang";
setTimer(1);
}

function onTimeOut(){
this.yourstylingoldstylingsucks;;
chat="You grouped everything together without any spacing";
echo("And it was very annoying to read");
setTimer(1);
} 


Or something like that....



It was very annoying and barely legible.

Looks fine to me

[killerogue]

Originally Posted by Bl0nkt

Looks fine to me

You wonder why scripters hate looking at your scripts Hachi?

[Chandler]

I'd do this:

PHP Code:

public function Hurt(hurtDamage, attackersAccount, hurtGani)
  if (this.clientr.hp > 0 && !this.clientr.dead && !level.nopk && !this.client.nopk)
  {
  this.clientr.hp -= abs(temp.hurtDamage);  
  if (temp.hurtGani) 
    this.setAni("hurt", "");
  clientr.lastattacker = temp.attackersAccount;
  if (this.clientr.hp <= 0) 
    this.doDeath(temp.attackersAccount);
  this.showHp(7);
  }
public function doDeath(attackersAccount)
  {
  this.clientr.dead = true;
  this.clientr.hp = 0;
  this.Kill(temp.attackersAccount); 
  } 


[Angel_Light]

Yes this has happened to me too *sneeze*TheFox*sneezes* I just used the Servers style command

/style Type Name

Like when Fox made a weapon I couldnt read I did

/Style weapon -FoxTest

it's not "my" style but it organizes the code.