Some questions

[papajchris]

So im looking at one of xXziroXx's old scripts and i had some questions

Originally Posted by xXziroXx

PHP Code:

function onPlayerChats()
{
  tokens = player.chat.tokenize();
  BodyParts = { "skin", "coat", "sleeves", "shoes", "belt", "all"};
  BodyColors = { "white", "yellow", "orange", "pink", "red",
    "darkred", "lightgreen", "green", "darkgreen", "lightblue",
      "blue", "darkblue", "brown", "cynober", "purple",
        "darkpurple", "lightgray", "gray", "black"};
  if (BodyParts.index( tokens[0]) > -1 && BodyColors.index( tokens[1]) > -1) {
    if (tokens[0] != "all") player.colors[ BodyParts.index( tokens[0])] = tokens[1];
    else {
      for (i: BodyParts) player.colors[ BodyParts.index( i)] = tokens[1];
    }
    player.chat = "Changed " @ tokens[0] @ " to " @ tokens[1] @ "!";
  }
} 


PHP Code:

 if (BodyParts.index( tokens[0]) > -1 && BodyColors.index( tokens[1]) > -1) 


What does the -1 do? Assuming its the word number, how can words be less than first word (which is number 0).

PHP Code:

for (i: BodyParts) player.colors[ BodyParts.index( i)] = tokens[1]; 


What does the "i" do? My guess is its a variable?

Lastly can SPC be used instead of "@"?

[cbk1994]

SPC is another option for concatenating strings, yes, but I think most scripters prefer to avoid it. I could be wrong.

This post should help explain the foreach loop he used.

The index function returns -1 if the item does not appear in the array.

[papajchris]

Thanks that link had great examples, final question and i think i got this part understood.

Could you do this

PHP Code:

for player.colors[ BodyParts.index(BodyParts)] = tokens[1]; 


instead of

PHP Code:

for (i: BodyParts) player.colors[ BodyParts.index( i)] = tokens[1]; 


[fowlplay4]

Originally Posted by papajchris

Thanks that link had great examples, final question and i think i got this part understood.

Could you do this

PHP Code:

for player.colors[ BodyParts.index(BodyParts)] = tokens[1]; 


instead of

PHP Code:

for (i: BodyParts) player.colors[ BodyParts.index( i)] = tokens[1]; 


no.

for (element: array) { }

[cbk1994]

Originally Posted by papajchris

Thanks that link had great examples, final question and i think i got this part understood.

Could you do this

PHP Code:

for player.colors[ BodyParts.index(BodyParts)] = tokens[1]; 


instead of

PHP Code:

for (i: BodyParts) player.colors[ BodyParts.index( i)] = tokens[1]; 


No. It might help if I pick apart his example.

PHP Code:

for (i: BodyParts) {
  player.colors[BodyParts.index(i)] = tokens[1];
} 


This is the example with braces added to clarify it.

I don't really like how he's doing that anyway. This is how I would have done it:

PHP Code:

for (temp.i = 0; i < BodyParts.size(); i ++) {
  player.colors[i] = tokens[1];
} 


Basically, i is starting at zero and increasing until it reaches the number of body parts. For each body part, it sets that part's color to tokens[1].

I'm not really sure how to explain the problems with yours except that it's just not following the right format. If you've got more questions I can try to answer them.

Also check out Jer's post on arrays.

[papajchris]

When you say it reaches the number of bodyparts you mean the number assigned from the array? So skin would be 0, coat 1, etc..

Im hoping to get a RC on testbed soon so that i can trial and error this myself

[cbk1994]

Originally Posted by papajchris

When you say it reaches the number of bodyparts you mean the number assigned from the array? So skin would be 0, coat 1, etc..

Im hoping to get a RC on testbed soon so that i can trial and error this myself

Yes. TGaniObject.colors is an array, where the first element is skin, second is shoes, etc. See here.

[papajchris]

Im trying to do a script where if someone with a staff level 2 or higher says "/kill <account>" it does so.

The script worked before I added the staff level requirement. Also can you show me where i would add an else statement for those who aren't level 2 or higher? I am trying to make it say "Not Allowed". At one point it was making my text "Not Allowed" no matter what i said unless i said "/kill <account>" so i think i was close.

PHP Code:

function onActionServerSide(tokens){
    if (tokens[0] == "/kill") {
        temp.pl = findPlayerByCommunityName(tokens[1]);
        temp.pl.hearts = 0;
        temp.pl.chat = player.account SPC "killed you!";
        player.chat = "You killed" SPC temp.pl SPC "!";
    }
}

//#CLIENTSIDE
function onPlayerChats() {
    if(tokens[0] == "/kill" && (player.clientr.stafflvl) > 1) {
        temp.tokens = player.chat.tokenize();
        triggerServer("gui", this.name, tokens);
    }
} 


[cbk1994]

Nothing wrong with it that I can see, except that you'll want to do the checks serverside.

PHP Code:

function onActionServerSide(tokens){
    if (tokens[0] == "/kill") {
        if (player.clientr.stafflvl > 1) {
          temp.pl = findPlayerByCommunityName(tokens[1]);
          temp.pl.hearts = 0;
          temp.pl.chat = player.account SPC "killed you!";
          player.chat = "You killed" SPC temp.pl SPC "!";
        } else {
          player.chat = "Not authorized!";
        }
    }
}

//#CLIENTSIDE
function onPlayerChats() {
    if(tokens[0] == "/kill") {
        temp.tokens = player.chat.tokenize();
        triggerServer("gui", this.name, tokens);
    }
} 


Also, there's no reason to do (player.clientr.stafflvl)—just player.clientr.stafflvl works fine.

The reason I inserted another if statement was so you could use the else clause properly. If you'd used && instead, then the else would also apply if the command wasn't "/kill".

Also, be sure to work on your styling. Two spaces is an indent.

[papajchris]

Hm i can't seem to get the script to work. I made sure i have a high enough staff level and i even swapper that part out for my account name to see if that would work, but still no luck

PHP Code:

function onCreated(){
  findplayer("papajchris").addweapon("Personal/papajchris/Staff");
}
function onActionServerSide(tokens){
    if (tokens[0] == "/kill") {
        if (player.account == "papajchris") {
          temp.pl = findPlayerByCommunityName(tokens[1]);
          temp.pl.hearts = 0;
          temp.pl.chat = player.account SPC "killed you!";
          player.chat = "You killed" SPC temp.pl SPC "!";
        } else {
          player.chat = "Not authorized!";
        }
    }
}

//#CLIENTSIDE
function onPlayerChats() {
    if(tokens[0] == "/kill") {
        temp.tokens = player.chat.tokenize();
        triggerServer("gui", this.name, tokens);
    }
} 


[cbk1994]

You have to tokenize the player's chat before you check tokens[0]—otherwise, the array doesn't exist yet.

PHP Code:

//#CLIENTSIDE 
function onPlayerChats() { 
  temp.tokens = player.chat.tokenize(); 
  
  if(tokens[0] == "/kill") { 
      triggerServer("gui", this.name, tokens); 
  } 
} 


[papajchris]

Can strings like clientr. and client only be numbers? When I do scripts such as the following, they don't appear in attributes.

PHP Code:

function onPlayerTouchsme() {
 client.high3=false;
} 


[Mark Sir Link]

Originally Posted by papajchris

Can strings like clientr. and client only be numbers? When I do scripts such as the following, they don't appear in attributes.

PHP Code:

function onPlayerTouchsme() {
 client.high3=false;
} 


if a var is set to false, it will no longer appear if you view a player's flags to prevent that var from taking up memory

since client.high3 wouldn't exist, evaluating

if(client.high3)

would return false since no value is attached to it

[cbk1994]

Originally Posted by papajchris

Can strings like clientr. and client only be numbers? When I do scripts such as the following, they don't appear in attributes.

PHP Code:

function onPlayerTouchsme() {
 client.high3=false;
} 


client and clientr variables can be anything but objects.

PHP Code:

player.clientr.foo = "bar"; // string
player.clientr.bar = 10 ^ 3; // number
player.clientr.baz = {"one", "two"}; // array
player.clientr.baa = true; // boolean 


Unlike languages like Java, Graal is a dynamically-typed language, which means you don't have to tell Graal what type of variable you want something to be. In Java, you would have to do

PHP Code:

String foo = "bar";
int bar = 10 ^ 3;
String[] baz = {"one", "two"};
boolean baa = true; 


Since you don't have to do that in Graal, the engine internally converts certain values to others. This doesn't affect behavior in this case.

Setting a value to true will show it equal to 1. Setting it to false will either show it equal to 0 or remove it from attributes altogether. Either works.

If a variable has never been set to false, it will by default be false.

[MrOmega]

Correct me if I'm wrong but float( false) would make it show 0 in the flags list.