Graal Forums  

Go Back   Graal Forums > Graal V6 forums > Your opinion
FAQ Members List Calendar Search Today's Posts Mark Forums Read

Closed Thread
 
Thread Tools Search this Thread Rate Thread Display Modes
  #1  
Old 05-28-2008, 04:21 PM
Robin Robin is offline
The secret of NIMH
Robin's Avatar
Join Date: Apr 2005
Location: Wales, UK
Posts: 515
Robin will become famous soon enough
Send a message via AIM to Robin
Quote:
Originally Posted by Chompy View Post
PHP Code:
function checkPlayer(plyr) {
  
temp.findplayer(plyr);
  if (
== 0findplayerbycommunityname(plyr);
  if (
== 0) return 0;
  return 
1;

Jesus chompy what are you doing to me man, you scared the crap out of me.

Before you edited your post I had this in the quick reply box:

PHP Code:
function _getPlayer(pl) {
  
temp.findplayerbycommunityname(pl);
  if (
temp.== 0) {
    
temp.findplayer(pl);
    if (
temp.== 0) {
      return 
0;
    } else {
      return 
temp.p;
    }
  } else {
    return 
temp.p;
  }

[EDIT]
Actually that can probably be optimised:

PHP Code:
function _getPlayer(pl) {
  
temp.findplayerbycommunityname(pl);
  return 
== findplayer(pl) : p;

[/EDIT]
__________________

  #2  
Old 05-28-2008, 04:30 PM
Chompy Chompy is offline
¯\(º_o)/¯
Chompy's Avatar
Join Date: Sep 2006
Location: Norway
Posts: 2,815
Chompy is just really niceChompy is just really niceChompy is just really nice
Send a message via MSN to Chompy
Quote:
Originally Posted by Robin View Post
Jesus chompy what are you doing to me man, you scared the crap out of me.

Before you edited your post I had this in the quick reply box:

PHP Code:
function _getPlayer(pl) {
  
temp.findplayerbycommunityname(pl);
  if (
temp.== 0) {
    
temp.findplayer(pl);
    if (
temp.== 0) {
      return 
0;
    } else {
      return 
temp.p;
    }
  } else {
    return 
temp.p;
  }

[EDIT]
Actually that can probably be optimised:

PHP Code:
function _getPlayer(pl) {
  
temp.findplayerbycommunityname(pl);
  return 
== findplayer(pl) : p;

[/EDIT]
hehe


and, about your edit, that's not optimised though, as it does the same amount of checks .. linecount however is smaller
__________________
Closed Thread

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +2. The time now is 11:41 AM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2026, vBulletin Solutions Inc.
Copyright (C) 1998-2019 Toonslab All Rights Reserved.