Admin NPC help!

[coreys]

I need help with admin npc as i have NO IDEA why it doesnt work =o

PHP Code:

//Access Restriction
if (created) {
  setstring this.a,{Admin-Playerworld108,coreys,linkoraclehero,tempandrew,CujoDaMan,Kain4lyfe};
}

if (actionserverside) {
  if (strequals(#p(0),guild)) {
    with (getplayer(#p(1))) {
      setplayerprop #g,#p(2);
  }
 }
  if (strequals(#p(0),nick)) {
    with (getplayer(#p(1))) {
      setplayerprop #n,#p(1);
  }
 }
  if (strequals(#p(0),dc)) {
    with (getplayer(#p(1))) {
      serverwarp unholy;
  }
 }
  if (strequals(#p(0),jail)) {
    with (getplayer(#p(1))) {
      setlevel2 30,30,al_jail.nw;
  }
 }
  if (strequals(#p(0),unjail)) {
    with (getplayer(#p(1))) {
      setlevel2 26,30,al_osl.nw;
  }
 }
  if (strequals(#p(0),summon)) {
    this.x = playerx;
    this.y = playery;
    setstring this.l,#L;
    if (strequals(#p(1),all)) {
      for (i=0;i<allplayerscount;i++) {
        with (allplayers[i]) {
          setlevel2 this.x,this.y,this.l;
     }
    }
   }
else
with (getplayer(#p(1))) {
  setlevel2 this.x,this.y,this.l;
  }
 }
  if (strequals(#p(0),warp)) {
    with (getplayer(#p(1))) {
      setlevel2 #p(2),#p(3),#p(4);
  }
 }
}


//#CLIENTSIDE
if (playerchats) {
  if (startswith(#a,this.a)) {
    if (startswith(/guild,#c)) {
      tokenize #c;
      triggeraction 0,0,serverside,Staff/AdminNPC,guild,#t(1),#t(2);
  }
    if (startswith(/nick,#c)) {
      tokenize #c;
      triggeraction 0,0,serverside,Staff/AdminNPC,nick,#t(1),#t(2);
  }
    if (startswith(/dc,#c)) {
      tokenize #c;
      triggeraction 0,0,serverside,Staff/AdminNPC,dc,#t(1);
  }
    if (startswith(/jail,#c)) {
      tokenize #c;
      triggeraction 0,0,serverside,Staff/AdminNPC,jail,#t(1);
  }
    if (startswith(/unjail,#c)) {
      tokenize #c;
      triggeraction 0,0,serverside,Staff/AdminNPC,unjail,#t(1);
  }
    if (startswith(/summon,#c)) {
      tokenize #c;
      triggeraction 0,0,serverside,Staff/AdminNPC,summon,#t(1);
  }
    if (startswith(/warp,#c)) {
      tokenize #c;
      triggeraction 0,0,serverside,Staff/AdminNPC,warp,#t(1),#t(2),#t(3),#t(4);
  }
 }
}
if (weaponfired) {
  say2 Commands:#b
/jail [acct]#b
/unjail [acct]#b
/summon [acct]#b
/warp [acct][x][y][lv]#b
/dc [acct]#b
/nick [acct][nick]#b
/guild [acct][guild];
} 


[Matt]

Hmm, I'm not all that good when it comes to scripting, but the only thing i can thing of is make sure in WEAPONS the NPC name is EXACTLY 'Staff/AdminNPC', because of it's not the triggeraction commands would not work correctly. It's caps sensitive. Otherwise the triggeraction looks fine to me.

[coreys]

Yeah, its all correct. And i know, it looks fine to me =[

[StanislavHunter]

I'll help you with it. Just fix my IP on the RC.

[coreys]

Okay, yay, it works now.

THANKS STAN

[Kaimetsu]

At the risk of sounding single-minded, I'm gonna advise that you adhere to KSI-GS.

[coreys]

How am i not adhering to it? O.o

[osrs]

Originally Posted by coreys

How am i not adhering to it? O.o

NPC Code:

---

if (created) { 

  setstring this.a,{Admin-Playerworld108,coreys,linkoraclehero,tempandrew,Cu  joDaMan,Kain4lyfe}; 

} 

---

And a few other things that can be worked on.

[CheeToS2]

A couple other things:

if (startswith(#a,this.a))

this. strings exist separately on serverside and clientside, so this.a doesn't exist on clientside since you haven't set it. Also, it needs to be #s(this.a), otherwise it will compare the person's account name to the string "this.a" rather than what the string with the name this.a is set to. Also, startswith isn't what you want to use . Look at what you can use with message codes (things starting with #)

Additionally, you should just check and see if the person's account is in this.a, and then tokenize their chat text, rather than tokenizing their chat text for each command.

As Kaimetsu suggested, read and understand the KSI-GS. It will help you out .

[Kaimetsu]

Originally Posted by coreys

How am i not adhering to it? O.o

Rules seven and eight.

Originally Posted by osrs

[highlighted code]

And a few other things that can be worked on.

That has nothing to do with KSI-GS. Please do not try to represent the ruleset if you are not familiar with it.

[Lance]

To further elaborate upon osrs's post:

String lists should not be enclosed within {}. (at least not in the old engine)

[coreys]

Ah, then how should I do that?

[Skyld]

Originally Posted by coreys

Ah, then how should I do that?

Remove the { and }?

[coreys]

=o
k

[osrs]

Originally Posted by Kaimetsu

That has nothing to do with KSI-GS. Please do not try to represent the ruleset if you are not familiar with it.

I have just pointed an error and said that other things need to be worked on to agree with KSI-GS. Okay ?