Quote:
|
Originally Posted by Slash-P2P
I made a little tutorial on how to script a custom Q-Menu. This is my first tutorial and I doubt its the best. I tried to be as clear as I could and make it so anyone could understand it. Tell me what you think (constructive criticism please).
|
Right-e-o. From skimming your document, here's what I found:
Quote:
|
...that you hold the Q-Menu down to view all of your items...
|
Holding the whole Q-Menu down sounds like a difficult task.
Spelling - you're.
Spelling - you're
Spelling - You're
Remember:
your - possession
you're - you are
Quote:
|
Below are some information
|
To my knowledge, 'information' is collective, and thus 'is' would be appropriate.
Quote:
|
Showimg - Displays an image on a certain point.
|
A whole image, on a point? Consider rewording this. If this is truly for beginners, they will (should) want to actually understand how the command works. Consider replacing 'on' with 'with the top-left corner drawn at a certain point'
Quote:
|
Showtext - Displays text on a certain point.
|
Same comment as the last one, though since you can specify some justification settings you may wish to reword it.
Quote:
|
changeimgcolors - Used to change the color of things (works best with showtext)
|
What?
Also, if you are explaining the commands and their components, it might be wise to explain what the 'index' is.
You should correct this to say '4 or over'
'for' is a control structure, not a function.
Apostrophe usage - here's
Quote:
In order to keep lag down, you should have a lesser timeout for when the
Q-Menu key is not down, and a higher one for when the Q-Menu key is down
|
What is your basis for this statement?
After this point, I've pretty much stopped checking for spelling/grammar errors. I think you can resolve those on your own.
See above.
Quote:
|
+ If the weapon is not hidden, add the weapon image and name to the strings. I suggest using insertstring so the weapons can easily be read with #I(string,index).
|
Wouldn't addstring be simpler and just as effective?
Quote:
|
The example below shows how to use the '%' function.
|
It does not show you how to use the modulus
operator, it provides an example of it being used.
Quote:
|
for (i=0;i<sarraylen(this.weapons_NAMES);i++) { // Go through the weapons list
|
This is inefficient. Each time it compares i, it recalculates the length of your string array. Set a variable to the length of your string array a line above your for statement, then compare it to that variable inside your for statement.
Quote:
...mousescreenx and mousescreeny. Those variables are the position
of the mouse on the screen (within the Graal window).
|
relative to the Graal window
Quote:
|
Example (in timeout): if (leftmousebutton && in the icon x,y) { // In the icon x,y isnt a real statement....
|
Why not use the mousedown event...? It's more efficient to act based upon an event when it happens than check a flag every timeout, yaknow.
See above.
---
I applaud you for your effort, but must ask that you thoroughly refine this document. I am going to be mean and edit the thread title, too, to add 'Proposed' in front of it.