Tokenize problems for guild script

JohnGames · #1 06-24-2004, 04:14 PM

In the following script I am making a guild maker. The set command works but it is overwritten by the next tokenize. When I say '/set something' it says
'set to something'. But when I say '/add JohnGames' it says 'You have been added to Johns Free home system! Your house number is 'JohnGames'. I want it to keep the tokens seperate.

NPC Code:

if(startswith(/Set,#c)){

    tokenize #c;

    say2 set to #t(1);

  }

  

  if(startswith(/add,#c)){

    tokenize #c;

    addguildmember House #t(1),#t(2);

    

    with (getplayer(#t(2))){

      say2 You have been added to#b

      Johns Free home system!#b

      Your house number is #t(1);

    }

  }

Crono · #2 06-24-2004, 04:26 PM

Read the rule thing jagen posted. It must be in code tags or whatever and use the graal standard thingys. I'm not sure but I think it's something like

NPC Code:



if (playerenters) {

   message Wtf crono doesnt script!;

}

osrs · #3 06-24-2004, 05:00 PM

Try saying /add 1 JohnGames and it will work. Also if you want a suggestion, make sure to the system be more secure, like checking if the house number will be > 0, tokenscount > 2 and so.

JohnGames · #4 06-24-2004, 05:37 PM

Quote:

Originally Posted by osrs

Try saying /add 1 JohnGames and it will work. Also if you want a suggestion, make sure to the system be more secure, like checking if the house number will be > 0, tokenscount > 2 and so.

THank you very much. They are there but I removed them for posting since they do not cause the problem

Dach · #5 06-24-2004, 06:03 PM

if you need to hold information from a tokenize, create a new string/variable from that token, don't rely on the #t's (same goes with the #p's)

JohnGames · #6 06-24-2004, 06:08 PM

Quote:

Originally Posted by Dach

if you need to hold information from a tokenize, create a new string/variable from that token, don't rely on the #t's (same goes with the #p's)

Thank you for the hint. THank you people who script mostly. I never us the file commands except if. (maybe I should start using them)

Trevor · #7 06-24-2004, 06:32 PM

Quote:

Originally Posted by Dach

if you need to hold information from a tokenize, create a new string/variable from that token, don't rely on the #t's (same goes with the #p's)

Why can you not rely on tokenize to keep the tokens until its next call? I would trust the Graal client more to store strings of tokens than myself.

JohnGames · #8 06-24-2004, 06:33 PM

Quote:

Originally Posted by Trevor

Why can you not rely on tokenize to keep the tokens until its next call? I would trust the Graal client more to store strings of tokens than myself.

My script overwrites them... I lose them instantly

Trevor · #9 06-24-2004, 07:32 PM

Quote:

Originally Posted by JohnGames

My script overwrites them... I lose them instantly

I do not see where it overwrites them. At the very least the tokens should stay until the end of the current control scope. And since you only call tokenize at the top of each control scope, how in the world are you overwriting them?

Also, I'm pretty sure that #t's are read-only. So the only thing that can assign new values to them is a call to tokenize.

JohnGames · #10 06-24-2004, 07:50 PM

Quote:

Originally Posted by Trevor

I do not see where it overwrites them. At the very least the tokens should stay until the end of the current control scope. And since you only call tokenize at the top of each control scope, how in the world are you overwriting them?

Also, I'm pretty sure that #t's are read-only. So the only thing that can assign new values to them is a call to tokenize.

The script call is over when I call it again as something new; so it went away

Dach · #11 06-24-2004, 08:45 PM

What I said isn't needed in the little snippet he gave, but I was really just refering to the general case. Osrs already pointed out the answer to his primary dilemma.

You can't lose them instantly without tokenizing something else (tokenize isn't local, so holding something for longer than one block of code isn't secure), same goes for parameters (#p) but more than one command will assign information to those.