Help me please

[iCoke]

Hello, I posted it here because I didnt see anywere else to post it, but anyways I need help with this script. The problem is there is a syntax error.

Script:

function onPlayerchats()
{
if (player.chat == "/open")
{
if (player.weapons.index(findweapon("-Bank/Account")) > 0)
{
say2("You already have a bank account");
}
else
{
say2("You have opened a bank account!");
player.addWeapon("-Bank/Account");
}
}

[Starfire2001]

Originally Posted by iCoke

Hello, I posted it here because I didnt see anywere else to post it, but anyways I need help with this script. The problem is there is a syntax error.

Script:

function onPlayerchats()
{
if (player.chat == "/open")
{
if (player.weapons.index(findweapon("-Bank/Account")) > 0)
{
say2("You already have a bank account");
}
else
{
say2("You have opened a bank account!");
player.addWeapon("-Bank/Account");
}
}

You are missing a }. Should style it, makes those type of errors obvious and makes things just generally easier to read.

PHP Code:

function onPlayerchats(){
  if (player.chat == "/open"){
    if (player.weapons.index(findweapon("-Bank/Account")) > 0){
      say2("You already have a bank account");
    }
    else{
      say2("You have opened a bank account!");
      player.addWeapon("-Bank/Account");
    }
  } 


[iCoke]

Now it says

"missing ] after element list"

[callimuc]

try using something like this:

PHP Code:

function onPlayerchats(){
  if (player.chat == "/open"){
    if (!("-Bank/Account" in player.weapons)){
      say2("You already have a bank account");
    }
    else{
      say2("You have opened a bank account!");
      player.addWeapon("-Bank/Account");
    }
  } 
} 


[iCoke]

Nope not working :O :'(... I wonder why?

[callimuc]

if you are trying this in the offline editor, ignore the errors there and upload it. the offline editor just debugs that for the GS1 scripts, not GS2

[iCoke]

Im not, I am putting it on as a "Weapon" on a server.

[Starfire2001]

Originally Posted by iCoke

Im not, I am putting it on as a "Weapon" on a server.

onPlayerChats doesn't work serverside in weapons, so you have to make the script you have clientside. However you can't add weapons to the player clientside, so you are going to have to use triggerserver to add the weapon. If you don't know anything about triggering try this thread.

http://forums.graal2001.com/forums/s...ad.php?t=84321

Using callimuc's script, you'll end up with something like...

PHP Code:

function onActionserverside(){
  //add the weapon
}

//#CLIENTSIDE
function onPlayerchats(){
  if (player.chat == "/open"){
    if (!("-Bank/Account" in player.weapons)){
      say2("You already have a bank account");
    }
    else{
      say2("You have opened a bank account!");
      //triggerserver goes here
    }
  } 
} 


[iCoke]

So would it be like this?

Script:

PHP Code:

function onActionserverside(){
  //add the weapon
}

//#CLIENTSIDE
function onPlayerchats(){
  if (player.chat == "/open"){
    if (!("-Bank/Account" in player.weapons)){
      say2("You already have a bank account");
    }
    else{
      say2("You have opened a bank account!");
      //// This is my clientside part of the script.
//#CLIENTSIDE
function onCreated() {
  this.myatm = "myatm.png";
  triggerserver("png", this.name, "myatm.png", this.myatm);
}
    }
  } 


[cbk1994]

Please wrap your code in [PHP] tags when you post here. That way it's formatted nicely (look at callimuc and Starfire2001's posts). I have to strain to read the code you're posting because there's no indentation.

[callimuc]

Originally Posted by iCoke

So would it be like this?

Script:

PHP Code:

function onActionserverside(){
  //add the weapon
}

//#CLIENTSIDE
function onPlayerchats(){
  if (player.chat == "/open"){
    if (!("-Bank/Account" in player.weapons)){
      say2("You already have a bank account");
    }
    else{
      say2("You have opened a bank account!");
      //// This is my clientside part of the script.
//#CLIENTSIDE
function onCreated() {
  this.myatm = "myatm.png";
  triggerserver("png", this.name, "myatm.png", this.myatm);
}
    }
  } 


maybe you should start with more basic stuff