Question about "autodetecting" variables.

[cbk1994]

They could edit the numbers with a memory editor. As a general rule of thumb when writing code, pretend that all of your clientside code can be changed by a hacker. You should always validate the data on serverside (or hide it somehow) if it's important enough that it will be changed.

[salesman]

Originally Posted by Jiroxys7

I believe im fairly familiar with using the serverside <=> clientside stuff. didnt know the difference between temp.var and this.var though =3

so if i want to create an important clientr.var, i should do something like this?:

example:
<snip>

clientr.num should equal 3.

now, I'm wondering though, are people able to hack and edit this.num1 and this.num2 to change the outcome of clientr.num? or is it just harder to hack compared to client.vars?

The values of this.num1 and this.num2 are being passed as parameters, not the actual variables themselves. It would look like this:

PHP Code:

function onActionServerSide(cmd, p1, p2) { // you can call these whatever you want
  if (temp.cmd == "calc_math") {
    // p1 and p2 hold the values 1 and 2
    
    doMakeMathVar_S(temp.p1, temp.p2);
  }
}

function doMakeMathVar_S(num1, num2){ // again, call these parameters whatever you want
   clientr.num = temp.num1 + temp.num2; // parameters are temp.vars -- only accessible within the function block
}

//#CLIENTSIDE

function doMakeMathVar_C() {
  // There's really no reason to use this.vars here because you 
  // only need them  within this function block
  // for sake of learning, I'll leave it as you had it
  
  this.num1 = 1;
  this.num2 = 2;
  triggerServer("weapon", this.name, "calc_math", this.num1, this.num2);
} 


[Jiroxys7]

Originally Posted by salesman

The values of this.num1 and this.num2 are being passed as parameters, not the actual variables themselves. It would look like this:

<snip>

For some reason, the values werent going through unless i did something like this:

PHP Code:

function onActionServerSide(cmd, v1, v2) {
  if (cmd == "calc_math") {
    doMakeMathVar_S();
  }
}

doMakeMathVar_S(){
    clientr.num = params[1] + params[2]; // <-------
}

//#CLIENTSIDE

function onTimeout() {  
  temp.num1 = 1;
  temp.num2 = 2;
  triggerServer("weapon", this.name, "calc_math", temp.num1, temp.num2);
  player.chat = clientr.num;
}

setTimer(1); 


[Cubical]

Originally Posted by Jiroxys7

For some reason, the values werent going through unless i did something like this:

PHP Code:

function onActionServerSide(cmd, v1, v2) {
  if (cmd == "calc_math") {
    doMakeMathVar_S();
  }
}

doMakeMathVar_S(){
    clientr.num = params[1] + params[2]; // <-------
}

//#CLIENTSIDE

function onTimeout() {  
  temp.num1 = 1;
  temp.num2 = 2;
  triggerServer("weapon", this.name, "calc_math", temp.num1, temp.num2);
  player.chat = clientr.num;
}

setTimer(1); 


Shouldn't it be more like this

PHP Code:

function onActionServerSide(cmd, v1, v2) {
  if (cmd == "calc_math") {
    doMakeMathVar_S(v1,v2);
  }
} 


also what's with the random setTimer(1);

[Jiroxys7]

PHP Code:

function onActionServerSide(cmd, v1, v2) {
  if (cmd == "calc_math") {
    doMakeMathVar_S();
  }
}

doMakeMathVar_S(){
    clientr.num = params[1] + params[2];
} 


seems to work the same as

PHP Code:

function onActionServerSide(cmd, v1, v2) {
  if (cmd == "calc_math") {
        clientr.num = params[1] + params[2];
  }
} 


I'm guessing because the v1 and v2 params or w/e were accessable through the entire serverside section of the script. making the doMakeMathVar_S function right there seem a bit redundant unless i can get the things to send values across eachother.

As for the timeout, when i was incorporating this into one of my other scripts and it didnt work, i played around with the example for a while to try getting it to work. i've found that looping something in player.chats is often very useful for finding where problems in scripts might be occuring. i suppose i couldve just put it in it's own timeout but since it's just an example, i looped that entire part. otherwise, if youre commenting on it being set to 1 as being random, like i said. it's an example so i just put whatever in that works.