i'm stumped, script help

[Gravis2k]

i made a bird transformation for my server, and i have made all of the ganis (walk,idle,attack etc...) and for some reason the walk one doesnt show on me... for an hour it would show on other people, but now it doesn't. i don't see anything wrong with the script what so ever.. if some1 could point it out i would really appreciate it.


//#CLIENTSIDE
if (weaponfired&&this.on=0) {
setani birdtransform,;
replaceani idle,birdidle;
replaceani sword,birdattack2;
replaceani walk,birdidle;
this.on=1;
}else if (weaponfired&&this.on=1) {
setani birdreform1,;
replaceani idle,idle;
replaceani sword,sword;
replaceani walk,walk;
this.on=0;
}
if(playerchats&&strequals(#c,land)){
setplayerprop #c,:escends slowly::;
setani birdland,;
disabledefmovement;
}
if(playerchats&&strequals(#c,fly)){
setplayerprop #c,::Rises rapidly into the air::;
setani birdfly1,;
enabledefmovement;
}

[Kaimetsu]

replaceani walk,birdidle;

[Gravis2k]

i know it says birdidle, they both are the same gani for flying and idling so i only made the idle. it worked for a little bit on other people and now it doesnt work at all

[Kaimetsu]

Fair enough. Fix it up in accordance with KSI-GS and I'll try to help you in other ways.

[Gravis2k]

//#CLIENTSIDE

if (weaponfired&&this.on=0) {
setani birdtransform,;
replaceani idle,birdidle;
replaceani sword,birdattack2;
replaceani walk,birdidle;
this.on=1;
}


else if (weaponfired&&this.on=1) {
setani birdreform1,;
replaceani idle,idle;
replaceani sword,sword;
replaceani walk,walk;
this.on=0;
}


if (playerchats&&strequals(#c,land)){
setplayerprop #c,:escends slowly::;
setani birdland,;
disabledefmovement;
}


if (playerchats&&strequals(#c,fly)){
setplayerprop #c,::Rises rapidly into the air::;
setani birdfly1,;
enabledefmovement;
}

------------------------------------------------------------------
if there is anything wrong with the format tell me and i will fix it

[Tseng]

Regarding conforming to KSI-GS:

You have two successive checks of the same event. :-\

Rather than doing:

NPC Code:

---

if (event1 && condition1) {

  dostuff();

}

if (event1 && condition2) {

  dootherstuff();

}

---

Do:

NPC Code:

---

if (event1) {

  if (condition1) {

    dostuff();

  }

  else if (condition2) {

    dootherstuff();

  }

}

---

Also, you are using one equals sign for comparisons - bad!

[Gravis2k]

//#CLIENTSIDE

if (weaponfired){
if (this.on==0) {
setani birdtransform,;
replaceani idle,birdidle;
replaceani sword,birdattack2;
replaceani walk,birdidle;
this.on=1;
}
else if (this.on==1){
setani birdreform1,;
replaceani idle,idle;
replaceani sword,sword;
replaceani walk,walk;
this.on=0;
}
}


if (playerchats&&strequals(#c,land)){
setplayerprop #c,:escends slowly::;
setani birdland,;
disabledefmovement;
}


if (playerchats&&strequals(#c,fly)){
setplayerprop #c,::Rises rapidly into the air::;
setani birdfly1,;
enabledefmovement;
}

[Tseng]

Now apply the same idea to the second block, and then test the script out again.

[Python523]

use [code] tags on the forums

[Gravis2k]

i tried, it still doesn't work.

NPC Code:

---

//#CLIENTSIDE 



if (weaponfired){

  if (this.on==0) { 

    setani birdtransform,; 

    replaceani idle,birdidle; 

    replaceani sword,birdattack2; 

    replaceani walk,birdidle; 

    this.on=1;

  }   

  else if (this.on==1){

    setani birdreform1,; 

    replaceani idle,idle; 

    replaceani sword,sword; 

    replaceani walk,walk; 

    this.on=0; 

  }

} 





if(playerchats&&strequals(#c,land)){

    setplayerprop #c,:escends slowly::;

    setani birdland,;

    disabledefmovement;

}

if(playerchats&&strequals(#c,fly)){

    setplayerprop #c,::Rises rapidly into the air::;

    setani birdfly1,;

    enabledefmovement;

}

---

[Gravis2k]

am i being ignored now lol??

[Tseng]

Originally posted by Gravis2k
am i being ignored now lol??

You didn't listen to my last set of helping directions.

[Gravis2k]

ok done (sorry)

NPC Code:

---

//#CLIENTSIDE 



if (weaponfired){

  if (this.on==0) { 

    setani birdtransform,; 

    replaceani idle,birdidle; 

    replaceani sword,birdattack2; 

    replaceani walk,birdidle; 

    this.on=1;

  }   

  else if (this.on==1){

    setani birdreform1,; 

    replaceani idle,idle; 

    replaceani sword,sword; 

    replaceani walk,walk; 

    this.on=0; 

  }

} 





if (playerchats){

  if (strequals(#c,land)){

    setplayerprop #c,escends slowly::;

    setani birdland,;

    disabledefmovement;

  }





  else if (strequals(#c,fly)){

    setplayerprop #c,::Rises rapidly into the air::;

    setani birdfly1,;

    enabledefmovement;

  }

}

---

but that's not where my problem was.... when i am in bird form and i try to move i switch back to looking human again, my friend zach can use it and fly and still look like a bird but i can't, i can also see him flying. please help lol

everything but the walk one works. fly,land,idle, and attack all work fine.

[mhermher]

You probablly got some NPC using a loop to replaceani walk,walk; or so

[Python523]

Originally posted by mhermher
You probablly got some NPC using a loop to replaceani walk,walk; or so

What? You do not loops replaceani's, I thought you were a scripter