players in room

[Kaimetsu]

Ah, yes, in that case you are correct. I tend to favour separation of event checks from normal conditional statements, but that's just a stylistic thing. Wouldn't affect efficiency.

[mhermher]

NPC Code:

---

//#CLIENTSIDE

if (timeout||playerenters) {

 if (playerscount=>5) {

 //Stuff here

 }

timeout=0.05;

}

---

Also note if you have showcharacter NPCS (the ones which stefan put in.. that have heads, bodies and stuff counts as players to, so if you got lets say 2 of them, change the 5 to 7.

[Snakeandy7]

//#CLIENTSIDE
if ((playerenters && strequals(#L,levelname.nw)) || timeout){
for(i=0; i<playerscount; i++{
stuff here :o
}
timeout=0.05;
}
Isnt that one way?
I dont think it is.. not sure tho :o..

[mhermher]

Snake, no need for the level thing, playerscount is the players in the level, allplayers is players in the server.

[Snakeandy7]

I see, Thanks for mensioning

[KainDaMan]

the npc character's problem can be solved like this

NPC Code:

---

for (i=0; i<playerscount; i++) {

  if (players[i].id>=0) {

    this.players++;

  }

}

---

of course the "this.players" variable would have to be reset to zero before called. and the variable "this.players" everytime would equal to the amount of "real players" in the room.

[protagonist]

Originally posted by Tseng


Um, the first 'check' is when the action is called, so that happens regardless. The second 'check', be it on another line or in the same if ( ) statement, will be executed regardless; efficiency is not something you can debate with this.

Very easily? I don't go around putting '&& otherflag==true' for every check I add, but it is arguably easier to type two ampersands than 'if ( ) { }'. That does not make it better, but you are incorrect in saying it's easier.

It seems bluntly obvious that it is in the interest of readability to seperate your conditional checks.

[Tseng]

Originally posted by protagonist


It seems bluntly obvious that it is in the interest of readability to seperate your conditional checks.

What part of 'stylistic choice' don't you understand? Readability is subjective.

[Dach]

I prefer Tsengs way actually, because if you ask me its alot easier to see all the checks at once instead of making new brackets for each one

just so you know it's not jut Tseng whose crazy

[Tseng]

Originally posted by Dach
I prefer Tsengs way actually, because if you ask me its alot easier to see all the checks at once instead of making new brackets for each one

just so you know it's not jut Tseng whose crazy

Well, you can liken it to reading. Different cultures have come up with different ways to read books. Some go left to right, then up to down; others go right to left, up to down; others just go straight down, right to left; still others go in other ways. Can you argue that our style of reading is better than the Japanese, or Hebrew?

Stylistic. choice.

[Kaimetsu]

It depends. The name of the game is implicit intentions; personally I don't like searching through endless conditions to understand what somebody is doing. If the conditions are related then yeah, fine, but otherwise it's stupid.

[TB3]

I didnt read all the way to the third page but.....

In order for more people to be in the room playerenters will have to be triggered.... *DUH* you dont need a timeout loop to lag the server any or little just a simple

NPC Code:

---

if(created) {

  this.minplayers=5;

}

if(playerenters) {

  if(playerscount>=this.minplayers){

    blah();

  }

}

---

THat would be sufficient right or did i miss something?


[edit]

NPC Code:

---

if(created) {

  this.minplayers=5;

  this.mode=0;

  this.check=0;

}

if(playerenters||playerleaves) {

  this.mode=(playerscount>=this.minplayers? 1 : playerscount<this.minplayers? 0 );  

  if(this.mode!==this.check) {

    door();

  }



}



function door() {

  this.check=this.mode

  if(this.mode=1) {//Opening

  blah;

  }

  if(this.mode=0) {//Closing

  blah;

  }

}

---

THeres a more complex edit it should work *goez to zleep im tired*

[Tseng]

Originally posted by Kaimetsu
It depends. The name of the game is implicit intentions; personally I don't like searching through endless conditions to understand what somebody is doing. If the conditions are related then yeah, fine, but otherwise it's stupid.

if (playerchats && strequals(#c,give me pie)) {
//Some cool pie-giving coding
}

I've been arguing related the whole time.

[Kaimetsu]

Originally posted by Tseng
I've been arguing related the whole time.

Indeed, but I'm not addressing just you

[Snakeandy7]

Originally posted by TB3

NPC Code:

---

if(created) {

  this.minplayers=5;

  this.mode=0;

  this.check=0;

}

if(playerenters||playerleaves) {

  this.mode=(playerscount>=this.minplayers? 1 : playerscount<this.minplayers? 0 );  

  if(this.mode!==this.check) {

    door();

  }



}



function door() {

  this.check=this.mode

  if(this.mode=1) {//Opening

  blah;

  }

  if(this.mode=0) {//Closing

  blah;

  }

}

---

THeres a more complex edit it should work *goez to zleep im tired*

I'm sorry but, why does your script question it self?...