Making scripts shorter

[Googi]

Could someone tell me common things that people do that can be done in shorter ways that take up less characters (preferably a lot less...)

[Pokilty]

for loops! i see so many scripts that should be taking advantage of this but aren't. i'm not just talking about the scripts where people put 20 putexplosions, there's also scripts that have just a few extra lines that could be removed and more easliy understood with a simple for loop in it.

[Googi]

Originally posted by Pokilty
for loops! i see so many scripts that should be taking advantage of this but aren't. i'm not just talking about the scripts where people put 20 putexplosions, there's also scripts that have just a few extra lines that could be removed and more easliy understood with a simple for loop in it.

Yes, I already knew that one.

[Jeff]

Use with to transfer strings around instead of using server strings. More efficient and less error-prone, too

[DarkShadows_Legend]

I've tried this a few times in Graal, but it doesn't seem to work, but it works in some other programming languages.

NPC Code:

---

//1st ex

if(var == (1||3)){

// do stuff

}

// 2nd ex.

if(playerdir == (1||3)){

//do stuff

}

---

It doesn't seem to work for me. I usually have to type out the whole thing as if(var == 1 || var == 3) // stuff

Has anyone else tried this before?

[Loriel]

Originally posted by DarkShadows_Legend
It doesn't seem to work for me.

|| is a boolean thing, so it only returns true or false.
'var == (1||3)' would check wether var is true, as '(1||3)' returns true because neither 1 or 3 is false.
Not sure wether it is exactly like that in GScript, but in theory it should be like that.

Probably one could also save some lines
by using vecx/y.

NPC Code:

---

if (playerdir == 0) playery --;

else if (playerdir == 1) playerx --;

else if (playerdir == 2) playery ++;

else if (playerdir == 3) playerx ++;

---

is inferior to

NPC Code:

---

playerx += vecx(playerdir);

playery += vecy(playerdir);

---

[osrs]

I usually use more arrays than lots of this.vars,like:

array = {10,20,30,40};

instead of

this.var1=10;
this.var2=20;

as Pokilty already said,i like to use for loops:

for(i=0;i<4;i++){changeimgvis i,4;}

instead of

changeimgvis 1,4;
changeimgvis 2,4;


You can find many ways to make your script shorter.
Btw,this remember a funny thing that ive seen,i saw a script 2 weeks ago (i wont say who was the scripter,but its a famous person),he made a scrolling message like this:

NPC Code:

---

if(playerenters){

message H;

sleep0.5;

message Hi;

sleep0.5;

message H;

sleep0.5;

message;

timeout = 1;

}

---

hehe

[adam]

Originally posted by osrs

Btw,this remember a funny thing that ive seen,i saw a script 2 weeks ago (i wont say who was the scripter,but its a famous person),he made a scrolling message like this:

NPC Code:

---

if(playerenters){

message H;

sleep0.5;

message Hi;

sleep0.5;

message H;

sleep0.5;

message;

timeout = 1;

}

---

hehe

Aw... I Hate that.

[TB3]

Originally posted by osrs

Btw,this remember a funny thing that ive seen,i saw a script 2 weeks ago (i wont say who was the scripter,but its a famous person),he made a scrolling message like this:


code:--------------------------------------------------------------------------------
if(playerenters){
message H;
sleep0.5;
message Hi;
sleep0.5;
message H;
sleep0.5;
message;
timeout = 1;
}
--------------------------------------------------------------------------------

NPC Code:

---

if(playerenters||timeout) {

  setstring this.message,H Hi H;

  tokenize #s(this.message);

  for (i=0;i<4;i++) {

    message #t(i);

    sleep .5;

  }

  timeout=1;

}

---

Just a quick script but sadly it is not that much shorter than the first one lolz
Didn't test it i just figured it would work.

[osrs]

Originally posted by TB3

NPC Code:

---

if(playerenters||timeout) {

  setstring this.message,H Hi H;

  tokenize #s(this.message);

  for (i=0;i<4;i++) {

    message #t(i);

    sleep .5;

  }

  timeout=1;

}

---

Just a quick script but sadly it is not that much shorter than the first one lolz
Didn't test it i just figured it would work.

Yes,it works fine.
But you could do for(i=0;i<=strlen(#s(this.message));i++)
instead of for(i=0;i<4;i++)

[TB3]

I would have but I didn't see a blank message ; before the actual H showed up so I didnt think of it
It was a blank message ; at the end thus the i<4 instead of <3

[osrs]

Originally posted by Kaimetsu
Both solutions are horrible.

1) Sleep is bad for loops.
2) You don't need to explicitly specify the chat text at each stage. Just store the whole text in a this.string and use #e to cut out the part you need.

And osrs, strlen would be meaningless in this case. Even within his crazy method, sarraylen would be more appropriate.

We arent expert,so we script it as the way we know..

[Tseng]

Originally posted by Kaimetsu
Both solutions are horrible.

1) Sleep is bad for loops.
2) You don't need to explicitly specify the chat text at each stage. Just store the whole text in a this.string and use #e to cut out the part you need.

And osrs, strlen would be meaningless in this case. Even within his crazy method, sarraylen would be more appropriate.

tokenscount would work as well, since he's tokenizing it and using tokens

Originally posted by osrs


We arent expert,so we script it as the way we know..

And from posts such as Kaimetsu's, you learn a new/better way to do it.

[osrs]

Originally posted by Tseng
And from posts such as Kaimetsu's, you learn a new/better way to do it.

Yes,finding new/better ways to script is always good.

[Admins]

Originally posted by DarkShadows_Legend
I've tried this a few times in Graal, but it doesn't seem to work, but it works in some other programming languages.

NPC Code:

---

//1st ex

if(var == (1||3)){

// do stuff

}

// 2nd ex.

if(playerdir == (1||3)){

//do stuff

}

---

It doesn't seem to work for me. I usually have to type out the whole thing as if(var == 1 || var == 3) // stuff

Has anyone else tried this before?

Do

NPC Code:

---

if (var in {1,3})

---