One npc triggered by another one

[E_Man]

Originally Posted by ffcmike

The placed NPC would be a separate object to the original weapon script, so the this. variable would not transfer between them. It should use 'if(created){}' as the condition, and then probably use 'destroy;' rather than 'hide;'.

Also I know this is old gscript but I believe you still need to use '==' rather than a single '='. A single '=' is for assigning values, whereas a double '==' is for comparing different values. In modern gscript using just one would result in the condition being determined as true, even if the 2 compared values were different.

But I am assigning values, it is so that when I use the weapon, it can place the bomb first, then when you use the weapon again, it blows it up, and I can't do "if(created)" because I need it to blow up when I want it to, not on it's own.

[ffcmike]

Originally Posted by E_Man

But I am assigning values, it is so that when I use the weapon, it can place the bomb first, then when you use the weapon again, it blows it up

Your assigning of variables is correct, it is the comparing of variables within the if conditions which is incorrect, using an assignment causes the if conditions to always be true.

It should be for example:

PHP Code:

if(playertouchsme){
  if(this.value == 2){
    this.value = 3;
  }
} 


Doing something like:

PHP Code:

if(this.value = 2){
  //stuff
} 


is essentially the same as:

PHP Code:

if(true){
 //stuff
} 


It's probably worth mentioning that the opposite can also be applied for doing 'not equal to', for example:

PHP Code:

if(playertouchsme){
  if(this.value != 2){
    this.value = 2;
  }
} 


Originally Posted by E_Man

and I can't do "if(created)" because I need it to blow up when I want it to, not on it's own.

In that case, you should write and read the 'bomb' variable without using 'this.', so it is a global flag, rather than one tied to the weapon.

[E_Man]

Originally Posted by ffcmike

Your assigning of variables is correct, it is the comparing of variables within the if conditions which is incorrect, using an assignment causes the if conditions to always be true.

It should be for example:

PHP Code:

if(playertouchsme){
  if(this.value == 2){
    this.value = 3;
  }
} 


Doing something like:

PHP Code:

if(this.value = 2){
  //stuff
} 


is essentially the same as:

PHP Code:

if(true){
 //stuff
} 


It's probably worth mentioning that the opposite can also be applied for doing 'not equal to', for example:

PHP Code:

if(playertouchsme){
  if(this.value != 2){
    this.value = 2;
  }
} 


In that case, you should write and read the 'bomb' variable without using 'this.', so it is a global flag, rather than one tied to the weapon.

I don't get why I need to compare variables, also would client.variable work for global flags? Though it probably is the comparing variables because I can place the bomb but it blows up on it's own.

[ffcmike]

Originally Posted by E_Man

I don't get why I need to compare variables,

When I say comparing variables, this also counts for checking to see if one variable is equal to a numerical value.

Originally Posted by E_Man

also would client.variable work for global flags?

It would work yes, but this is a functionality designed to save variables permanently for online usage, which doesn't apply here.

It should be fine to do:

PHP Code:

//Weapon
bomb = 1;

//NPC
if(bomb == 1){

} 


[E_Man]

Originally Posted by ffcmike

When I say comparing variables, this also counts for checking to see if one variable is equal to a numerical value.



It would work yes, but this is a functionality designed to save variables permanently for online usage, which doesn't apply here.

It should be fine to do:

PHP Code:

//Weapon
bomb = 1;

//NPC
if(bomb == 1){

} 


I tried that and it still blows up on it's own and the image does not change back, here is the script, I also can send the images if you need to test it.

Weapon:

PHP Code:

// NPC made by E-Man
if (created) {
  client.bomb=0;
  client.explosion=0;
  setimg remotebomb1.png;
}
if (playertouchsme) {
  toweapons Remote Bomb;
  hide;
}
if (weaponfired && client.bomb==0 && playerdir= 0) {
  putnpc remotebomb1.png,remotebomb.txt,playerx+0.5,playery-1;
  client.bomb=1;
}
if (weaponfired && client.bomb==0 && playerdir= 1) {
  putnpc remotebomb1.png,remotebomb.txt,playerx-1.5,playery+1;
  client.bomb=1;
}
if (weaponfired && client.bomb==0 && playerdir= 2)  {
  putnpc remotebomb1.png,remotebomb.txt,playerx+0.5,playery+2.5;
  client.bomb=1;
}

if (weaponfired && client.bomb==0 && playerdir= 3) {
  putnpc remotebomb1.png,remotebomb.txt,playerx+2.5,playery+1;
  client.bomb=1;
}
if (weaponfired && client.bomb==1) {
  setani shoot,remote.png;
   setimg remotebomb1.png;
 client.explosion=1;
    }
if (client.bomb==1) {
  setimg remoteimage.png;
} 


remotebomb.txt

PHP Code:

if (created) {
setimg remotebomb1.png;
}
if (client.explosion==1) {
canbecarried;
setimg remotebomb2.png;
sleep 0.5;
putexplosion 2,x,y;
client.explosion=0;
destroy;
}