Weapon Control

[cbk1994]

Originally Posted by Mark Sir Link

in the onActionServerside portion of the script you should be verifying that the player who sent the trigger is actually someone you expect it to be, IE

if(player.account in serveroptions.staff.tokenize(","))

You should check player.communityname, not player.account, since for some reason Stefan decided that the new accounts have to have their community name in the staff list.

[Emera]

Originally Posted by cbk1994

You should check player.communityname, not player.account, since for some reason Stefan decided that the new accounts have to have their community name in the staff list.

Would it be practical to check for both?

[callimuc]

Originally Posted by Emera

Would it be practical to check for both?

maybe since servers mostly still have the accounts.

PHP Code:

if(player.account in serveroptions.staff.tokenize(",") || player.communityname in serveroptions.staff.tokenize(",")) 


[Mark Sir Link]

Originally Posted by callimuc

maybe since servers mostly still have the accounts.

PHP Code:

if(player.account in serveroptions.staff.tokenize(",") || player.communityname in serveroptions.staff.tokenize(",")) 


the only time a communityname wouldn't return the proper value (I think this is still the case) is if a new Graal####### account hasn't set a community name.

I guess you could do

if( ((player.communityname.length() > 0) ? player.communityname : player.account) in severoptions.staff.tokenize(","))

to prevent incorrectly formatted staff lists that might have an empty value somewhere from returning true for players that haven't set their community name.

[cbk1994]

Originally Posted by Emera

Would it be practical to check for both?

There's no reason to. All you really need to check for is the community name. Players with old accounts will have their account as their community name.

[Mark Sir Link]

Originally Posted by cbk1994

There's no reason to. All you really need to check for is the community name. Players with old accounts will have their account as their community name.

on Unholy Nation I was checking exclusively for community names and stumbled into the same problem I posted about with an improperly formatted staff list.

Granted, I couldn't actually find any instances of an empty entry in the array but it was still returning true when I checked player.communityname in the array.

each array member -

PHP Code:

[Manager]
Absolut_Crono
[Admin]
Flares
[Dev_Admin]
Mark Sir Link
KevDoh
[NAT_Admin]
[Scripting_Team]
Toxen
Deas_Voice
devilsknite1
MysticalDragon
thatdwarf
ApothiX
Hezzy002
Switch
zeldaguardian
[Graphics]
Blazeik
JeffNightVale
[Levels_Admin]
shyguy2
[Levels_Team]
javierkid
Dr_Doctor
Hostility
27Chris1
snoop413
HolySerenity
[FAQ]
Kamakaze
Samurai_X2689
Dread
ranmalrac1
Hosaun
[Gani_Team]
dark_mater_s
[Events_Team]
Jello
Elite3
four_swords
Unknown_Prophecy
KaidaChan
warcraft1111
maxi123
GracefulCharity
BrutaL
Timez
Battousai90290
larenaz19
babyx
[Graal_Police]
CertifiedGangsta252
Okilian
dubby230
nightslayer317
Hiro
taylor
ssgohan87
MooseInATree
weeway
[Developer]
Bane
SwimChao
Gamerkid7
[SFX]
[Uploader]
Door
[Unholy_Radio]
[The_Man]
_Zelph
[ET_Dev_Admin]
Starfire2001
[ET_Dev]
Akios
[Global]
Skyld
[ENDSTAFF] 


[cbk1994]

Originally Posted by Mark Sir Link

on Unholy Nation I was checking exclusively for community names and stumbled into the same problem I posted about with an improperly formatted staff list.

Granted, I couldn't actually find any instances of an empty entry in the array but it was still returning true when I checked player.communityname in the array.

Good point. I wish Stefan would just fix community names.

[Mark Sir Link]

Originally Posted by cbk1994

Good point. I wish Stefan would just fix community names.

I guess servers could try to force it on players by disconnecting them if their community name is null and using the shared admin function thing but I doubt Stefan would approve or appreciate it.

I didn't even think it would be problematic initially until all of a sudden I see RC get flooded with players warning each other.