Arrow buying

[xAndrewx]

hmm

function onPlayerChats() {
  if (player.chat != "buy arrows") return;
  
  player.chat = this.onBuyArrows();
}
function onBuyArrows() {
  if (player.rupees < 30) return "You don't have enough money! You need 30 gralats";
  
  player.darts += 30;
  player.rupees -= 30;

  return "Yaaaay!! Thanks tuff guy";
}

quite funky

[cbk1994]

Originally Posted by xAndrewx

hmm

You shouldn't name functions with an on prefix. That implies that it is an event.

[Tigairius]

Originally Posted by cbk1994

You shouldn't name functions with an on prefix. That implies that it is an event.

I agree here, usually events only start with "onMyFunction." If it's simply a method to purchase an item you should be using "function purchaseItem" instead of "function onPurchaseItem" unless you trigger the event from trigger() or a scheduleevent(). Naming a function with the prefix of "on" basically is saying you don't expect a return value.

[Cloven]

Originally Posted by Tigairius

I agree here, usually events only start with "onMyFunction." If it's simply a method to purchase an item you should be using "function purchaseItem" instead of "function onPurchaseItem" unless you trigger the event from trigger() or a scheduleevent(). Naming a function with the prefix of "on" basically is saying you don't expect a return value.

I generally agree, though I don't think it's a big deal really...

Some people prefix their functions in that fashion for added readability. This is largely because many jerks create unintuitive names for functions, or their code is haphazardly styled. In those cases the 'Find' feature can be rendered almost useless. As such, scanning for the 'on' prefix can be of use in those cases.

For people who practice poor function and/or variable naming... @ you.

[cbk1994]

Originally Posted by Cloven

I generally agree, though I don't think it's a big deal really...

Some people prefix their functions in that fashion for added readability. This is largely because many jerks create unintuitive names for functions, or their code is haphazardly styled. In those cases the 'Find' feature can be rendered almost useless. As such, scanning for the 'on' prefix can be of use in those cases.

How does "on" make a function more readable?

[Fulg0reSama]

Originally Posted by cbk1994

How does "on" make a function more readable?

I think he means if it looks the same as the rest people will recognize it as to what it is.
Also makes narrowing down for functions easier.

[MrOmega]

Originally Posted by cbk1994

How does "on" make a function more readable?

cause then you can capitalize the letter after! :P

onSomeFunction()

-or-

someFunction()

pointless, I know. xP