float()

[Liberated]

Originally Posted by Loriel

okay so since I am paying him too i am paying him not to change float() or add a new function or whatever

Thats not what i ment,
Stefan is earning money with graal, we are paying him to play, and develop on it. Something is not working as expected,
they ask for a change, it is their right to ask stefan to change it for them, and not spend both their time own time on it.
You were asking why stefan had to do all the programming, not why he should or should not change float().

[Fulg0reSama]

We don't pay anyone. We rent their service to continue their work. We're more or so donaters, not tax payers so why should Stefan be expected to make anything more than he has to other than player satisfaction?

[xXziroXx]

Originally Posted by Loriel

Why the hell does Stefan have to do all the programming for you infants

stefan can you add a function to tie my shoelaces :'(

QQ some more please, you can do it!

[LoneAngelIbesu]

For what it's worth, I've never used a float() function that didn't convert "123str" into 123. That's kind of the purpose, isn't it?

[Skyld]

Originally Posted by xXziroXx

Definitely. Just because a string STARTS with numbers doesn't mean it's a number.

This is intentional since it allows extra notation to be correctly parsed:

PHP Code:

echo(float("1.0e4")); // 10000
echo(float("0xBC"));  // 188 


GScript is behaving in this case completely as expected, and this is the same as in JavaScript and a lot of other dynamically/variantly typed languages, so no, it can't be changed without breaking it's intended functionality.

If this is a problem then you should validate your input before processing.

[MrOmega]

Call me stupid but what are some actual purpose of using float( "123str");

[Crow]

Originally Posted by MrOmega

Call me stupid but what are some actual purpose of using float( "123str");

Let's assume we have user input. We want a number. The user gives us a string instead of a number. Ideally, throwing it into the float()-bin will return -1 and tell us it's a string this way. When there are numbers at the beginning, it won't. Don't see an issue though. Of course, this is just an example. Might be a problem elsewhere. But that can be worked around.

[LoneAngelIbesu]

Originally Posted by Crow

Ideally, throwing it into the float()-bin will return -1 and tell us it's a string this way.

Let's make sure to mention that, in this scenario, a custom sanitation function would be best, as Skyld said.

[adam]

Skyld is my hero.

[WhiteDragon]

Originally Posted by Skyld

This is intentional since it allows extra notation to be correctly parsed:

PHP Code:

echo(float("1.0e4")); // 10000
echo(float("0xBC"));  // 188 


It's not like it'd be impossible to make a parser which only accepts those variants when a letter is encountered.

I also don't think it matters that this is "how it usually works" in dynamically-typed languages, since a lot of other languages do dumb things.


But the important fact is that this behavior already exists and bugs may be introduced if it is changed.

[Riot]

In my opinion, the fact that float returns -1 on error makes less sense then "123str" returning 123.

[WhiteDragon]

Originally Posted by Riot

In my opinion, the fact that float returns -1 on error makes less sense then "123str" returning 123.

GS2 doesn't have any error handling or NaN/undefined. I suppose 0 would be a softer fail.

Edit: Post 666

[LoneAngelIbesu]

Originally Posted by Riot

In my opinion, the fact that float returns -1 on error makes less sense then "123str" returning 123.

What doesn't make sense about float('123str') returning 123? Just look at it semantically: float() does not imply a function that checks if there are non-mathematical characters. It implies returning a float value.

[Riot]

Originally Posted by LoneAngelIbesu

What doesn't make sense about float('123str') returning 123? Just look at it semantically: float() does not imply a function that checks if there are non-mathematical characters. It implies returning a float value.

I'm not saying it doesn't make sense, just that returning -1 (a perfectly valid value) on error makes less sense.

[Loriel]

Originally Posted by WhiteDragon

GS2 doesn't have any error handling or NaN/undefined. I suppose 0 would be a softer fail.

Yeah that is the explanation but guy still has a point