setting teams in events.

[xMane]

PHP Code:

function onPlayerChats(){
if(player.guild.starts("Events")){
if(player.chat="/setteams"){
players.remove(player.account);
playerscount-1;
player.chat=int((playerscount-1)/4)@"/"@playerscount-1;
for (i=0;i<playerscount-1;i++){
if(!(players[int(i)].guild.starts("Events"))){
players[int(i/12)].setlevel2("event_ttw-lobby.nw",23.5,30);
players[int(i/12)].guild = "TTW Team 1";
players[int(i/8)].setlevel2("event_ttw-lobby.nw",44,30);
players[int(i/8)].guild = "TTW Team 2";
players[int(i/4)].setlevel2("event_ttw-lobby.nw",23.5,44.5);
players[int(i/4)].guild = "TTW Team 3";
players[int(i)].setlevel2("event_ttw-lobby.nw",44,44.5);
players[int(i)].guild = "TTW Team 4";
}
}
}
}
} 


it keeps making the event's team as a player... how do i remove that.?
also is there any ways to make this script better?

[Deas_Voice]

ever heard of code styling? (if you haven't, google it!)

i doubt anyone would help you without you putting some effort in learning how to style your code.

PHP Code:

function exampleOfStyling() {
  if (value == foo) {
    doFoo();
  }
  else if (value == bar) {
    if (bar == 5) {
      doBar();
    } else doBarTwo();
  }
} 


it will also make your code much easier to read for others.

[fowlplay4]

For Loop Explanation: http://forums.graalonline.com/forums...11&postcount=4

You also can't modify the 'players' array.

Here's a common method for placing each person a different team, by just using an alternating boolean/flag.

PHP Code:

function setupTeams() {
  // Initialize flag so first player is added to the Red team
  temp.red = true;
  // Loop through players in level
  for (temp.plyr: players) {
    // Ignore Events Team / Admin
    if (!temp.plyr.guild.starts("Events")) {
      // Check if setting to Red team.
      if (temp.red) {
        // Set guild to Red
        temp.plyr.guild = "Red";
        // Reset flag so next player is blue
        temp.red = false;
      } else {
        // Set guild to Blue
        temp.plyr.guild = "Blue";
        // Set flag so next player is red
        temp.red = true;
      }
    }
  }
} 


[xMane]

Originally Posted by Deas_Voice

ever heard of code styling? (if you haven't, google it!)

i doubt anyone would help you without you putting some effort in learning how to style your code.

PHP Code:

function exampleOfStyling() {
  if (value == foo) {
    doFoo();
  }
  else if (value == bar) {
    if (bar == 5) {
      doBar();
    } else doBarTwo();
  }
} 


it will also make your code much easier to read for others.

ahh! fine...

PHP Code:

function onPlayerChats(){
  if(player.guild.starts("Events")){
    if(player.chat="/setteams"){
      players.remove(player.account);
      playerscount-1;
      player.chat=int((playerscount-1)/4)@"/"@playerscount-1;
      for (i=0;i<playerscount-1;i++){
        if(!(players[int(i)].guild.starts("Events"))){
          players[int(i/12)].setlevel2("event_ttw-lobby.nw",23.5,30);
          players[int(i/12)].guild = "TTW Team 1";
          players[int(i/8)].setlevel2("event_ttw-lobby.nw",44,30);
          players[int(i/8)].guild = "TTW Team 2";
          players[int(i/4)].setlevel2("event_ttw-lobby.nw",23.5,44.5);
          players[int(i/4)].guild = "TTW Team 3";
          players[int(i)].setlevel2("event_ttw-lobby.nw",44,44.5);
          players[int(i)].guild = "TTW Team 4";
        }
      }
    }
  }
} 


[Dnegel]

Originally Posted by xMane

PHP Code:

function onPlayerChats(){
if(player.guild.starts("Events")){
if(player.chat="/setteams"){
players.remove(player.account);
playerscount-1;
player.chat=int((playerscount-1)/4)@"/"@playerscount-1;
for (i=0;i<playerscount-1;i++){
if(!(players[int(i)].guild.starts("Events"))){
players[int(i/12)].setlevel2("event_ttw-lobby.nw",23.5,30);
players[int(i/12)].guild = "TTW Team 1";
players[int(i/8)].setlevel2("event_ttw-lobby.nw",44,30);
players[int(i/8)].guild = "TTW Team 2";
players[int(i/4)].setlevel2("event_ttw-lobby.nw",23.5,44.5);
players[int(i/4)].guild = "TTW Team 3";
players[int(i)].setlevel2("event_ttw-lobby.nw",44,44.5);
players[int(i)].guild = "TTW Team 4";
}
}
}
}
} 


Oh what a mess.

[xMane]

also why doesnt

PHP Code:

if(hasweapon("weaponname")) 


works?

[Deas_Voice]

Originally Posted by xMane

also why doesnt

PHP Code:

if(hasweapon("weaponname")) 


works?

because hasWeapon() is GS1 and un-supported in GS2

[fowlplay4]

The GS2 version of that function:

PHP Code:

public function hasWeapon(wepname) {
  return (findweapon(wepname) in player.weapons);
} 


[cbk1994]

PHP Code:

if(player.chat="/setteams"){ 


needs to be

PHP Code:

if(player.chat=="/setteams"){ 


This isn't just personal preference, it's necessary because otherwise the engine tries to assign a value to player.chat.

You can simplify your script very easily:

PHP Code:

function onPlayerChats() {
  if (player.guild == "Events Team") {
    if (player.chat == "/setteams") {
      temp.teams = { // team name, level, x, y
                     {"TTW Team 1", "event_ttw-lobby.nw", 23.5, 30},
                     {"TTW Team 2", "event_ttw-lobby.nw", 44, 30},
                     {"TTW Team 3", "event_ttw-lobby.nw", 23.5, 44.5},
                     {"TTW Team 4", "event_ttw-lobby.nw", 44, 44.5}
                   };
      
      temp.i = 0;
      for (temp.pl : players) {
        if (pl.guild == "Events Team") {
          continue;
        }
        
        temp.team = teams[i % teams.size()];
        pl.guild = team[0];
        pl.setLevel2(team[1], team[2], team[3]);
        i ++;
      }
    }
  }
}