Scripted RC

[fragman85]

Who cares about Anti-Graal having Back Ups?
I mean what's the use?

Anti-Graal can obviously not to ANYTHING to damage Graal, it's not like they're professional Hackers (otherwise they'd have hacked Graal years ago).

[fowlplay4]

Well it was fun griefing my client-rc'ers on Zodiac but this should be dealt with.

It needs to filter out HTML tags sent through RC messages.

My current hack fix to prevent the tags from continuing to wreak havoc:

PHP Code:

//#CLIENTSIDE

/*
   Hack fix due to ScriptRCRCchat.onTextChanged not working.
*/

function ScriptedRCWindow.onWake() {
  onWatchRC();
}

function ScriptedRCWindow.onShow() {
  onWatchRC();
}

function onWatchRC() {
  // Quits looping until onScrolled can takeover completely.
  if (ScriptedRCScroll.scrollpos[1] > 0) return;
  checkRC();
  this.scheduleevent(0.05, "WatchRC", "");
}

function ScriptedRCScroll.onScrolled() {
  checkRC();
}

/*
   Checks RC for new messages / text.
*/

function checkRC() {

  // Prevent Scroll Looping
  if (this.last == ScriptedRCRCchat.text.length()) return;
  
  // Get Last Line
  temp.rcchat = ScriptedRCRCchat.text;
  for (temp.i = temp.rcchat.length(); temp.i > 0; temp.i--) {
    temp.char = temp.rcchat.charat(temp.i);
    if (temp.char == "\\" && temp.lastchar == "n") {
      temp.lbpos = temp.i + 2;
      break;
    }
    temp.lastchar = temp.char;
  }
  
  // Determine Last Message
  temp.lastmsg = temp.rcchat.substring(temp.lbpos);
  if (temp.lastmsg.pos("</font>") >= 0) {
    temp.from    = temp.lastmsg.substring(0, temp.lastmsg.pos("</font>")+7);
    temp.textmsg = temp.lastmsg.substring(temp.lastmsg.pos("</font>")+7);
    temp.textmsg = temp.from @ filter(temp.textmsg);
  }
  else temp.textmsg = temp.lastmsg;
  
  // Alter Text
  temp.oldspos = @ScriptedRCScroll.scrollpos;
  ScriptedRCRCchat.text = ScriptedRCRCchat.text.substring(0, temp.lbpos) @ temp.textmsg;
  if (temp.oldspos != (@ScriptedRCScroll.scrollpos)) {
    ScriptedRCScroll.scrolltobottom();
  }
  
  // Record Length
  this.last = ScriptedRCRCchat.text.length();
}

// Filter's <font> tags.

function filter(msg) {
  temp.mpos = msg.pos("<font");
  if (temp.mpos == -1) return msg;
  temp.cpos = msg.substring(temp.mpos).pos(">");
  while (temp.mpos >= 0 && temp.cpos >= 0) {
    msg = msg.substring(0, temp.mpos) @ msg.substring(temp.mpos+temp.cpos+1);
    temp.mpos = msg.pos("<font");
    temp.cpos = msg.substring(temp.mpos).pos(">");
  }
  return " " @ msg.trim();
} 


[adam]

I can't find the scripted RC graphics. sad.

[cbk1994]

Originally Posted by fowlplay4

Well it was fun griefing my client-rc'ers on Zodiac but this should be dealt with.

It needs to filter out HTML tags sent through RC messages.

My current hack fix to prevent the tags from continuing to wreak havoc:

Can you not just replace "<" with "&lt;"? I've done it several times and it works a charm.

[fowlplay4]

Yeah but then the tags show up.

[cbk1994]

Originally Posted by fowlplay4

Yeah but then the tags show up.

Isn't that what you want?

[Skyld]

I've picked up work on the Scripted RC again and have made the following improvements:

• The ban window now works properly. You can ban both accounts and PC IDs now;
• The ban window also shows now the length of time that a ban takes, and how long there is remaining on a ban;
• The rights window has been updated and now uses tabs;
• HTML tags stripped properly from RC chat;
• RC chat is now automatically focused when you press F6;
• The script editor now has an adjustable pane so that you can drag the section between the script list and the editor;
• Removed the playerlist and instead added context menu items to the normal scripted playerlist when you log into Scripted RC (just right-click someone on your F7 list after logging in with F6);
• Adding drop-down menus for the colours selection in the Attributes window.

Things I plan to fix over the next couple of days:

• Admin messages not always working properly.

I would really appreciate it if you want to test it. You can do so by loging onto Login 2 and then onto your server and pressing F6. Let me know if there are any bugs or anything that needs improving/fixing.

[oo_jazz_oo]

The scripted rc still needs the ability to search the script list and file browser.

When you have literally hundreds and hundreds of weapons, classes, etc, it would be nice to search for a specific item.
Like the external rc does now...you begin typing, and it finds the first instance that begins with what you typed.

Other than that...i'm glad this is finally being worked on again.

Edit: Also, another thing. Is there any way to check if a player is on clientrc?
The only way I found to do this was to check:

PHP Code:

(@ "-ScriptedRC").this.sessionOpen 


Which of course only works clientside. There should be some flag set to the player if they are on clientrc.

[cbk1994]

Tig has implemented the type-to-find, albeit in an obstructive way, with the playerlist on Login 2. That should be easy enough to copy and fix up.

[Skyld]

Originally Posted by oo_jazz_oo

The scripted rc still needs the ability to search the script list and file browser.

Definitely can do this in the filebrowser, but the script editor might be a bit more complicated since scripts are being opened when they are being selected at the left. That might make it hard since if you click the left so that you can start typing, you might open a script, and also when a script is selected, it might be opened by the client (since it probably simulates a select event).

Originally Posted by oo_jazz_oo

Edit: Also, another thing. Is there any way to check if a player is on clientrc?

The clientside check is the only reliable one, not sure if it's a good idea to add client flags or such.

[cbk1994]

Originally Posted by Skyld

The clientside check is the only reliable one, not sure if it's a good idea to add client flags or such.

Use a player. variable clientside.

[Deas_Voice]

ohman, i really dislike using the playerlist with clientrc features, perhaps making a sub-menu (if such thing is possible with guis, i dont know.) in playerlist for clientrc?

i dislike the idea because i use the playerlist of "staff functions" such as "warpto"(yes i know that feature have been added to login2 version, but i dont log into that too often.) or opening a Gui with a bunch of stuffs you can do to a player as a staff (summon them, kick them from events, ect)

but hey, nice work!

Edit:
the "submenu" idea is having one menu, then an arrow to the side, like the Start button in windows have.
|------------|-----|-------------|
| Graal -> |-----| Graal.exe |
| Other -> | | Rc.exe |
|------------| |--------------|

sorta.

[oo_jazz_oo]

Originally Posted by Skyld

Definitely can do this in the filebrowser, but the script editor might be a bit more complicated since scripts are being opened when they are being selected at the left. That might make it hard since if you click the left so that you can start typing, you might open a script, and also when a script is selected, it might be opened by the client (since it probably simulates a select event).

You could add a search box to the bottom of the list of weapons.

Just a single input box would do, and it would be helpful.

[xAndrewx]

hmmm

[Skyld]

Originally Posted by xAndrewx

hmmm

Hmm there is a problem with the menu display sometimes, I guess it is a problem with the profiles. Go via Login 2 and see if it still happens with the new Scripted RC (that is the old one you are using there).

[cbk1994]

Would be great if you made a non-graphical client-RC (modeled after the non-graphical RC, of course).

[Skyld]

Fixed a couple of bugs and also have eliminated that horrible Script Menu, replacing it with the ability to add new classes, weapons and NPCs from directly inside the script editor. When you add a new script, the tree at the left refreshes and the script is automatically opened in a new tab.

[cbk1994]

Would be great if the tabbed script window was removed and replaced with a replica of RC now. I find the tabs very inconvenient since often I'm referencing another script.

[Skyld]

Originally Posted by cbk1994

Would be great if the tabbed script window was removed and replaced with a replica of RC now. I find the tabs very inconvenient since often I'm referencing another script.

I was thinking of making it optional; keeping the script list but making it possible to size it down and open scripts in external windows instead. Shouldn't be too difficult but there are more important fixes to make first.

[Matt]

Nice work, SKyld.

[xAndrewx]

oh wow- thats alot better. thanks

[Skyld]

Okay made the following updates.

• The file browser is improved:
  • Search has been added, click on the file list and just start typing;
  • Column sorting has been added, just click the column title to sort;
  • The Modified time is now an actual timestamp rather than just a big long horrible number;
  • The folder tree and the file list can now be resized.
• The script menu has been removed, allowing scripts to be added to NC in the Script Editor instead;
• HTML tags are now properly stripped.

It's now on Login 1 too, so all Mac/Linux and v6 users should have it right now.

[oo_jazz_oo]

Originally Posted by Skyld

Okay made the following updates.

• The script menu has been removed, allowing scripts to be added to NC in

Just curious, did you add a log out of rc button?

Because I believe the option was under the list you removed...so, there is no way to log out of client rc now?

[xAndrewx]

Originally Posted by oo_jazz_oo

Just curious, did you add a log out of rc button?

Because I believe the option was under the list you removed...so, there is no way to log out of client rc now?

press f6... it's a toggle!!

[oo_jazz_oo]

I always thought pressing f6 just hid the window. ^_^;;

I always used the logout button. lol

[cbk1994]

Originally Posted by oo_jazz_oo

I always thought pressing f6 just hid the window. ^_^;;

It does, but there's no reason to log out.

[Deas_Voice]

just reconnect if u dont want to be on clientrc :o

[LoneAngelIbesu]

Bug: Filebrowser doesn't output any log information in the bottom panel.

[Skyld]

The following updates have been made today:

• The ban window now supports global bans, is resizable and the drop down boxes are fixed.
• The attributes window is resizable and the drop down boxes are fixed.
• There is a new button (replacing toalls) which opens the global chat.
• Toggling the Scripted RC open and closed should be more reliable now, as should toggling the Scripted Playerlist.
• Admin messages have been added into the playerlist context menus.
• The options window is now working better and is saving the options in a different location so that they take effect on all servers that you have RC on.
• It's now possible to change the RC chat and script editor font sizes in the Scripted RC options window.
• The show account window is now showing a timestamp or (none) instead of a scary long number (in v6).
• In the file browser, sorting by size and modified defaults to descending rather than ascending. Click it again to reverse the sorting.
• The syntax highlighting has been changed in the script editor to more closely resemble the normal RC (although fully isn't possible yet).

Later on I will update the Scripted RC again to use a new monospaced font in the script editor which should be much easier to read. I'll also be checking the output in the file browser to check that it's showing information properly there, and also make it resizable.

I also tweaked the Scripted Playerlist for v6 users, it should open and close properly now but let me know if there are still problems.

[Fulg0reSama]

Skyld, You must be bored as **** to be doing this all of a sudden :P

[Skyld]

Originally Posted by Fulg0reSama

Skyld, You must be bored as **** to be doing this all of a sudden :P

Well it's needed finishing off for the last three years or so

[adam]

Idea: Favorite Scripts

Possible Implementation:
Right Click menu for scripts to select it as a favorite.
Checkbox in the scripts window to toggle "Only Show Favorites"


Possible: Use the same idea with levels or other files you are responsible for, possibly a separate window or tab that shows your favorite files in one place, greatly speeding up workflow.

[fowlplay4]

Personally I've always wanted to categorize scripts, and have collapsing lists. So on Zodiac I don't have to scroll through the 200 or so weapon scripts for skills and spells to get to the systems.

[born2kill]

Skyld first of all - nice updates - great work

Secondly - the saveings of weapons / npcs is bugged - if you save a npc the code is replaced with a "0"

Also a warning for all the others - firstly check out if the bug has been already fixed and make a new weapon before you start to edit your old one or you could delete your code with it

[Skyld]

Originally Posted by born2kill

Skyld first of all - nice updates - great work

Secondly - the saveings of weapons / npcs is bugged - if you save a npc the code is replaced with a "0"

Also a warning for all the others - firstly check out if the bug has been already fixed and make a new weapon before you start to edit your old one or you could delete your code with it

I tested this a bit more and there seemed a bit of a rare problem, fixed it though.

[Deas_Voice]

keep up the good work, skyld!

oh and, i found a "bug", the "add Weapon/npc/class" isn't at the top if you have a weapon that adds it self at the top, such as "!Weapon".
Perhaps make the "add" to a higher minus count?

[TSAdmin]

This seems a bit weird:

[cbk1994]

Originally Posted by TSAdmin

This seems a bit weird:

Pull out your glasses.

[Fulg0reSama]

Originally Posted by TSAdmin

This seems a bit weird:

Did you change the font by chance? Because from playing with HTML if you change the font without modifying size say for..

Comic Sans MS but you didn't change the font size it can end up being very very much smaller unlike the other because it seems like different fonts have different sizes (weird to me) but if it isn't this problem then I got nothing.

[TSAdmin]

Originally Posted by Fulg0reSama

Did you change the font by chance? Because from playing with HTML if you change the font without modifying size say for..

Comic Sans MS but you didn't change the font size it can end up being very very much smaller unlike the other because it seems like different fonts have different sizes (weird to me) but if it isn't this problem then I got nothing.

Sadly, no such change was made by my input.