Shovel Script

[Switch]

Originally Posted by Programmer

I suggest you look through the Graal Wikipedia. It will help you a lot quicker than asking for help here. It may also benefit you to collaborate with another scripter so you can learn more about the language.

Seriously, the GraalWiki needs some updates/changes. When I go on there to look for a function, I get about 200 unrelated pages and none of them having to do with what I'm looking for.

[Novice]

LOL'd at the deleted posts.

Jamerson, you may want to make a success rate on this. So maybe try

PHP Code:

temp.success = int(random(1,50));
if (success == 1) {
//continue
} 


Also use "setani(jamerson_shovel,null);" and "freezeplayer(1);"

[Pelikano]

Originally Posted by Novice

LOL'd at the deleted posts.

Jamerson, you may want to make a success rate on this. So maybe try

PHP Code:

temp.success = int(random(1,50));
if (success == 1) {
//continue
} 


Also use "setani(jamerson_shovel,null);" and "freezeplayer(1);"

That's not even his problem... yet a success rate is not bad. Even thought I think that's a little too low D:

[DustyPorViva]

Remember that random also creates a floating point, so you'd most likely want to check if 'success' was <=1, instead of just == 1. Can also simplify the matter by using int() on the random value.

[Pelikano]

Originally Posted by DustyPorViva

Remember that random also creates a floating point, so you'd most likely want to check if 'success' was <=1, instead of just == 1. Can also simplify the matter by using int() on the random value.

He is using int() :S

[DustyPorViva]

Hm... I don't remember seeing that before. Oh well! Still better to use <= though, as you can then create higher chances and such.

[cbk1994]

To clarify on what Dusty said, you really should have a player class with some basic item functions, e.g.

PHP Code:

public function addItem(item, quantity) {
  // checks to make sure quantity is valid, etc.
  
  this.clientr.item.(@ item) += quantity;
  this.addWeapon(item);
  
  // perhaps some logging?
}

public function removeItem(item, quantity) {
  // checks to make sure quantity is valid
  
  this.clientr.item.(@ item) = max(0, this.clientr.item.(@ item) - quantity); // the 'max' prevents the quantity from falling below zero
  if (this.clientr.item.(@ item) <= 0) {
    this.removeWeapon(item);
  }
  // perhaps some logging?
}

public function getItemQuantity(item) {
  return this.clientr.item.(@ item);
} 


You would create a class called "player" or so, then join it to the player in the onActionPlayerOnline function in the Control-NPC, like...

PHP Code:

function onActionPlayerOnline() {
  player.join("player");
} 


You could then do stuff like

PHP Code:

  temp.prizes = {"Treasure/Map", "Treasure/Chest", "Treasure/Key"}; 
  player.addItem(randomstring(prizes), 1); 


which would automatically handle adding the weapon, changing the quantity, and logging (if you added that).

Also, you should use player.level.name, not player.level. The former is a string, which is what you want, while the latter is an object. Unfortunately, Graal does some funny stuff which will let that work, but it's poor scripting to do so.

[DustyPorViva]

Originally Posted by cbk1994

Also, you should use player.level.name, not player.level. The former is a string, which is what you want, while the latter is an object. Unfortunately, Graal does some funny stuff which will let that work, but it's poor scripting to do so.

I think this is one of the most frequent problems I encounter... I never remember and using the former actually works most of the time until I randomly encounter the time that player.level won't work and I sit for a day or two trying to figure out why the **** my script isn't working correctly.

[cbk1994]

Originally Posted by DustyPorViva

I think this is one of the most frequent problems I encounter... I never remember and using the former actually works most of the time until I randomly encounter the time that player.level won't work and I sit for a day or two trying to figure out why the **** my script isn't working correctly.

It can be quite confusing, and understandably so. The same applies to player.ani.

[Novice]

Originally Posted by Pelikano

That's not even his problem... yet a success rate is not bad. Even thought I think that's a little too low D:

I know, I was just giving an example and an idea.