Help with bank script.

[[email protected]]

Ok, so I started making this bank script and I got a little confused.

Basically when you walk into a bank, you say '/create account' and when you say that, it adds a weapon called '-Bank/Account' to your attributes. Im trying to set it to where if you already have a bank account and you say '/create account' and you have the weapon '-Bank/Account' in your attributes already, it will say2 You already have a bank account. Here is what I have so far.

PHP Code:

//#CLIENTSIDE
function onPlayerchats()
{
if (player.chat="/open account")
{
if (hasweapon(-Bank/Account))
say2 You already have a bank account!;
}
else if (player.chat="/open account")
{
say2 You have created a bank account!;
player.addWeapon("-Bank/Account");
 }
} 


If you know the problem, please reply and tell me so I can finish this system.

Thanks alot

-Jamerson =]

[oo_jazz_oo]

First off, addweapon can only be done serverside, depending on if this is a level npc, or another weapon npc, you might just want to make the entire script serverside.

For detecting player chat, use if (player.chat == "chat")
One = sign denotes changing the variable.

And you shouldnt mix gs1 with gs2.

PHP Code:

say2 You already have a bank account!; 


should be

PHP Code:

say2("You already have a bank account!"); 


And for detecting if a player already has the weapon, you can use

PHP Code:

if (player.weapons.index(findweapon("Weapon Name")) > 0) 


Since if the player has the weapon, its index in the player.weapons array would be more than 0.

And you dont need to check the players chat again if the player doesnt have the weapon.
A simple "else" statement would do.


Edit: And i just read that the script is in the bank level, so you should just make the entire script serverside (Remove //#CLIENTSIDE), and it would work.

[cbk1994]

An easier way to do what Jazz said about finding if they have the weapon would be

PHP Code:

if (("Weapon Name") != null) {
  // code here
} 


or even

PHP Code:

if (findWeapon("Weapon Name") != null) {
  // code here
} 


though the findWeapon is technically unneeded.

[oo_jazz_oo]

I actually never thought of doing it that way.

I started detecting weapons my way when I saw it done on a friends server, and always used that method, since it worked.

Altho, i've seen alot of worse methods to detect it...I'll probably start doing it that way. Thanks. ;]

[[email protected]]

so is this right?


function onPlayerchats()
{
if (player.chat == "/open account")
{
if (player.weapons.index(findweapon("-Bank/Account")) > 0)
{
say2("You already have a bank account");
}
else
say2("You have opened a bank account!");
player.addWeapon("-Bank/Account");
}
}

[oo_jazz_oo]

PHP Code:

function onPlayerchats()
{
  if (player.chat == "/open account")
  {
    if (player.weapons.index(findweapon("-Bank/Account")) > 0) 
    {
      say2("You already have a bank account");
    }
    else
    {
      say2("You have opened a bank account!");
      player.addWeapon("-Bank/Account");
    }
} 


You should use php tags for your code, and styling the code makes it easier to read.

And you were also missing an opening bracket in your else statement.