Raelyn's Big Book of Scripting Questions.

[cbk1994]

Originally Posted by Raelyn

Awesome.

Another thing, I was under the impression that variable type is automatically detected, but it seems like setting a variable to a string of text doesn't work?

Trying to do something like this:

PHP Code:

clientr.weapon_img = weaponname.png;

if (trigger){
   showimg index,clientr.weapon_img,,,;
} 


Use:

PHP Code:

clientr.weapon_img = "weaponname.png"; 


for strings

Also, I tried using:

PHP Code:

function onKeyPressed(code, key, char) {
  if (key == "p") {
    temp.img = findImg(200);
    img.visible = ! img.visible;
  }
} 


Not sure how to implement this, as a function, isn't it redundant to do this?:

PHP Code:

if (keypressed){
  onKeyPressed(,p,);
} 


onKeyPressed is called on default. Basically all of the event if's were converted to "function onEvent", such as "onPlayerTouchsMe", "onCreated", and "onPlayerEnters". There's no need for the if (keypressed) statement.

Hrrm, am I doing this properly?


Doesn't this work?

PHP Code:

showimg 200,imagename.png,,,;
hideimg 200;

if (keypressed) {
  if (strequals(#p(1),p)) {
    temp.img = findImg(200);
    img.visible = ! img.visible;
  }
} 


hideimg might be actually destroying the image (actually, I'm pretty sure it does). Just hide it with findImg().visible. And, I don't think showimg has that many paramaters.

Plus.... you're combining GS1 and GS2 in a horrible way

Originally Posted by Raelyn

Ugh, I don't know how else to do this.

I want the weapon icon to be displayed dependant on the type of weapon equipped, so..

PHP Code:


if (clientr.weapon = 0001;){
   clientr.weapon_img = weaponicon.png;
}

showimg index, clientr.weapon_img,,,; 


Something like this I guess...

PHP Code:

//#CLIENTSIDE
function onCreated() {
  this.wep_type.sword = "sword.png";
}
function displayImage() {
  showimg(200, getImageForType(clientr.weaponType), 0, 0);
}
function getImageForType(wep) {
  return this.wep_type.(@ wep);
} 


and just set clientr.weaponType or another variable when you change the player's weapon. Also, there's really no reason to use clientr. for a weapon image.

And, I'm pretty sure you're adding an extra parameter to showimg almost everywhere. Press F2 and click on "Scripts", it may be giving an error.

[Raelyn]

Originally Posted by cbk1994

Use:

PHP Code:

clientr.weapon_img = "weaponname.png"; 


for strings


onKeyPressed is called on default. Basically all of the event if's were converted to "function onEvent", such as "onPlayerTouchsMe", "onCreated", and "onPlayerEnters". There's no need for the if (keypressed) statement.



hideimg might be actually destroying the image (actually, I'm pretty sure it does). Just hide it with findImg().visible. And, I don't think showimg has that many paramaters.

Plus.... you're combining GS1 and GS2 in a horrible way


Something like this I guess...

PHP Code:

//#CLIENTSIDE
function onCreated() {
  this.wep_type.sword = "sword.png";
}
function displayImage() {
  showimg(200, getImageForType(clientr.weaponType), 0, 0);
}
function getImageForType(wep) {
  return this.wep_type.(@ wep);
} 


and just set clientr.weaponType or another variable when you change the player's weapon. Also, there's really no reason to use clientr. for a weapon image.

And, I'm pretty sure you're adding an extra parameter to showimg almost everywhere. Press F2 and click on "Scripts", it may be giving an error.

Ahh thanks. And yea, I am not adding an extra parameter in the actual scripts, just mashing the comma here to represent that parameters DO follow.

Originally Posted by cbk1994

Use:

PHP Code:

clientr.weapon_img = "weaponname.png"; 


for strings

I did this:

PHP Code:

clientr.weapon_img = "raelyn_sword.png";

if (trigger){
  showimg index,clientr.weapon_img,x,y;
} 


Still not producing an image.

Edit: Bah, I got it to work with #s.

*slap forehead*

[cbk1994]

Originally Posted by Raelyn

Ahh thanks. And yea, I am not adding an extra parameter in the actual scripts, just mashing the comma here to represent that parameters DO follow.



I did this:

PHP Code:

clientr.weapon_img = "raelyn_sword.png";

if (trigger){
  showimg index,clientr.weapon_img,x,y;
} 


Still not producing an image.

Edit: Bah, I got it to work with #s.

*slap forehead*

GS1 requires that you use the string 'function' for strings to work, which is major failure.

PHP Code:

showimg(200, clientr.weapon_img, 30, 30); 


You can't expect GS2 to work if you don't use it correctly.

[Raelyn]

Originally Posted by cbk1994

onKeyPressed is called on default. Basically all of the event if's were converted to "function onEvent", such as "onPlayerTouchsMe", "onCreated", and "onPlayerEnters". There's no need for the if (keypressed) statement.

Ok, sorry to ask this again, but I am still having problems with this.. I am trying to use the GS2 solution and it's not working (I'm probably doing it wrong.)

Here is what I got..

PHP Code:

function onKeyPressed(code, key, char) {
  if (key == "i") {
    temp.img = findImg(209);
    img.visible = ! img.visible;
  }
} 


I have a function doing showimg 209, and trying to use the code snippet you suggested on key i, the image remains shown, and is not hid, as expected.

Is there a way in GS1 to do this?

PHP Code:

if (keypressed) {
   if (strequals(#p(1),I)){
      if (img 209 is visible){
         hideimg 209;
      } else {
         showimg 209,file,x,y;
      }
   }
} 


[Raelyn]

Originally Posted by Raelyn

Is there a way in GS1 to do this?

PHP Code:

if (keypressed) {
   if (strequals(#p(1),I)){
      if (img 209 is visible){
         hideimg 209;
      } else {
         showimg 209,file,x,y;
      }
   }
} 


Solved myself with

PHP Code:



this.inv_shown = 1;

if (keypressed) {
   if (strequals(#p(1),I)){
      Inventory();
   }
} 

function Inventory(){

  if (this.inv_shown == 0){

    // inventory pane
    showimg 209;
    this.inv_shown = 1;

  } else {

    hideimg 209;
    this.inv_shown = 0;
  }
} 


I have another question though, I am trying to change profilevars in server options, and I have

PHP Code:

profilevars=Level:=#v(clientr.level), 


Yet it is not picking up the clientr.level off my NPC...?