randomstring2

[LoneAngelIbesu]

Originally Posted by Tigairius

No upside to using a string, I just didn't feel like doing temp.source = {"A", "B", "C", etc};
I think it's generally bad practice to use a while() loop where a for() loop can be used, and right now it doesn't look like you have any loop protection, so if you input incorrect parameters you can break the loop limit.

I did use a for() loop, originally. However, that results in temp.i increasing, even though nothing is added to temp.output. That results in outputs that aren't the length defined by temp.limit.

Also, I have no clue what "loop protection" is. A search leads only to this topic.

[Tigairius]

Originally Posted by LoneAngelIbesu

Also, I have no clue what "loop protection" is. A search leads only to this topic.

Right now your while loop will go in to an infinite loop if your input limit is greater than the array size of the source.

[Chompy]

Originally Posted by Tigairius

Right now your while loop will go in to an infinite loop if your input limit is greater than the array size of the source.

If repeat is true then it will do that. Easy fix would be to return when output size equals source size

[Tigairius]

Originally Posted by Chompy

If repeat is true

Yes, that's what I meant

[LoneAngelIbesu]

Originally Posted by Tigairius

Right now your while loop will go in to an infinite loop if your input limit is greater than the array size of the source.

Oh, I see. Perhaps something like this?

PHP Code:

function randomstring2(source, limit, repeat) {
  if(temp.limit == null) {
    temp.limit = temp.source.size();
  }
  if(temp.limit > temp.source.size()) {
    temp.limit = temp.source.size();
  }
  while(temp.i < temp.limit) {
    temp.trial = temp.source[random(0, temp.source.size())];
    if(temp.repeat) {
      temp.output @= temp.trial;
      temp.i++;
    }
    else {
      if(temp.output.pos(temp.trial) < 0) {
        temp.output @= temp.trial;
        temp.i++;
      }
    }
  }
  return temp.output;
} 


Originally Posted by DustyPorViva

I agree that arrays are terrible for this sort of thing, simply because of the time it takes to set them up. I much prefer strings.

Well, I provided a source array that contains all possible single characters. So, it shouldn't take too much time to edit it, if you're simply looking to generate something from a list of single characters. Arrays offer the possibility of doing something like this:

PHP Code:

function onCreated() {
  temp.source = {
    "test",
    "sources",
    "foo bar",
    "foo bar baz",
    "foo!bar!baz"
  };
  echo(randomstring2(temp.source, 3, true));
  echo(randomstring2(temp.source, 3, false));
} 


Which outputs:

foo!bar!bazfoo bar bazsources
sourcestestfoo bar baz