booleans, can I do this?

[Frankie]

PHP Code:

setlevel2((player.guild == "Convict" && player.level != "era_prison-break.nw"? "era_present_00-00.nw": "era_prison-break.nw"), 30, 30); 


with the 2 checks?

[cbk1994]

Try this:

PHP Code:

setlevel2(((player.guild == "Convict" && player.level.name != "era_prison-break.nw" ) ? "era_presemt_00-00.nw" : "era_prison-break.nw"), 30, 30); 


[xXziroXx]

Originally Posted by cbk1994

Try this:

PHP Code:

setlevel2(((player.guild == "Convict" && player.level.name != "era_prison-break.nw" ) ? "era_presemt_00-00.nw" : "era_prison-break.nw"), 30, 30); 


I agree on the player.level.name fix, but adding another bracket around it was just stupid.

[zokemon]

Originally Posted by xXziroXx

I agree on the player.level.name fix, but adding another bracket around it was just stupid.

It wasn't stupid, adding a parentheses around the entire expression was the pointless part.

This will work just find:

PHP Code:

 setlevel2((player.guild == "Convict" && player.level != "era_prison-break.nw") ? "era_present_00-00.nw" : "era_prison-break.nw", 30, 30); 


If you did want to keep those parentheses though, you could do something even cooler:

PHP Code:

 setlevel2("era_" @ ((player.guild == "Convict" && player.level != "era_prison-break.nw") ? "present_00-00" : "prison-break") @ ".nw", 30, 30); 


The comma operator will automatically parse the whole set of arguments and end whatever expression you put in the first argument of the function unless there is an unbalanced/unclosed parentheses (which should be fixed anyways). You can leave extra parentheses though, it just can be rather difficult (or at least annoying) when dealing with 3+ sets of them nested together.

[Inverness]

Holy crap what's wrong with you people.

That script may work but it looks horrible.

PHP Code:

if (player.guild == "Convict" && player.level.name != "era_prison-break.nw") {
  player.setlevel2("era_present_00-00.nw", 30, 30);
} 


When you script you need to consider that other people will be reading your script in the future. Don't over-complicate things just because you can.

[xXziroXx]

Originally Posted by Inverness

PHP Code:

if (player.guild == "Convict" && player.level.name != "era_prison-break.nw") {
  player.setlevel2("era_present_00-00.nw", 30, 30);
} else player.setlevel2("era_prison-break.nw", 30, 30); 


Fixed.


Also, I'm not agreeing with the way he did it, but the thread wasn't made to argue about that.

[Inverness]

Originally Posted by xXziroXx

Fixed.

PHP Code:

if (player.guild == "Convict" && player.level.name != "era_prison-break.nw") {
  player.setlevel2("era_present_00-00.nw", 30, 30);
}
else {
  player.setlevel2("era_prison-break.nw", 30, 30);
} 


Now it's fixed. Mixing styles like you did looks bad too.

Originally Posted by xXziroXx

Also, I'm not agreeing with the way he did it, but the thread wasn't made to argue about that.

Doesn't matter why the thread was made. A bad habit (imho) shouldn't be encouraged.

[xXziroXx]

Originally Posted by Inverness

Doesn't matter why the thread was made. A bad habit (imho) shouldn't be encouraged.

Ignoring it completely isn't the same as encouraging, which I definitely wasn't doing, as you can see in my first post in the thread.

[zokemon]

Originally Posted by Inverness

Holy crap what's wrong with you people.

That script may work but it looks horrible.

PHP Code:

if (player.guild == "Convict" && player.level.name != "era_prison-break.nw") {
  player.setlevel2("era_present_00-00.nw", 30, 30);
} 


When you script you need to consider that other people will be reading your script in the future. Don't over-complicate things just because you can.

Wow.

[Tigairius]

Originally Posted by Inverness

Don't over-complicate things just because you can.

It may be over complicated for you, but it looks fine to me.

[WhiteDragon]

Originally Posted by Tigairius

It may be over complicated for you, but it looks fine to me.

I agree. I fail to understand how a common alternative syntax to if statements would be "complicated" to anyone. If they fail to read it correctly then I don't want them touching my code anyways.

I do agree that they should not be used beyond one level of nesting though, because then the same syntax is being used multiple times in one line which can be an eyesore.

[Switch]

Originally Posted by Inverness

Holy crap what's wrong with you people.

That script may work but it looks horrible.

PHP Code:

if (player.guild == "Convict" && player.level.name != "era_prison-break.nw") {
  player.setlevel2("era_present_00-00.nw", 30, 30);
} 


When you script you need to consider that other people will be reading your script in the future. Don't over-complicate things just because you can.

He was asking for if he could do it with booleans, as in not an if(){}else{}.

[Codein]

Originally Posted by Switch

He was asking for if he could do it with booleans, as in not an if(){}else{}.

If you think about it, if statements are just a form of writing booleans. I can understand something==somethingelse?function:anotherfunction, but if else statements are much easier to read.

[TheStan]

Originally Posted by Codein

If you think about it, if statements are just a form of writing booleans. I can understand something==somethingelse?function:anotherfunction, but if else statements are much easier to read.

It's all opinion in the end of it.

[xXziroXx]

Originally Posted by TheStan

It's all opinion in the end of it.

And guess which version 95% of all programmers would chose?