GUI Tool

[Inverness]

Originally Posted by [email protected]

no NAT on UN knew of any such command

That explains alot.

You also could have easily scripted it yourself instead of doing what you did.

PHP Code:

function hideimgs(start, end) {
  for (temp.i = start; i <= end; i ++) {
    hideimg(i);
  }
} 


[cbk1994]

Originally Posted by Inverness

On Windows you can use Wordpad to view most .doc files, and Microsoft Word can view any that Wordpad can't view. .docx is viewed with Microsoft Word 2007 and above.

I know, I easily use Windows twice as much as Mac ...

[[email protected]]

Oh wow, durr, I feel stupid.
I did that for the boots and the player's outfit colors, but I just didn't think
of using that for the imgs.. z.z

Thanks for bringing that up. ;o

[cbk1994]

Originally Posted by [email protected]

Oh wow, durr, I feel stupid.
I did that for the boots and the player's outfit colors, but I just didn't think
of using that for the imgs.. z.z

Thanks for bringing that up. ;o

You're letting staff change player's appearance with a staff tool ... ?

I fail to see how that could ever be productive.

[[email protected]]

Actually I was referring to the view attributes part I've added, that shows
your current outfit that you're wearing.
Please check things before you make comments like that please. =x
I mean I wouldn't mind really, but I sorta took your post in a negative manner while you mentioned that about my script before checking it. o.o

And second, it actually does set player's outfits though anyways, though that's not what I was referring to in that post. But what I did, was set this up as a serverside action like this, to save up space...

"findplayer(params[1]).params[2] = params[3];"

So you can set basically all player.strings, and add/remove/edit clientr.strings for the player using that.

It's not like I set this up individually... z.z

"findplayer(params[1]).headimg = params[2];"

Now having a whole bunch of that ^ nonsense, is useless. ;p
But even though, I do say I've found myself in GP related situations where I've had to change someone's head, or shield, as an
uploader over looked an inappropriate image while uploading or w/e.

[cbk1994]

Originally Posted by [email protected]

"findplayer(params[1]).params[2] = params[3];"

That is extremely insecure, I would never, ever use that.

For changing look, use RC. Staff tools should not be anything other than making things convenient, for example, jailing, summoning, adding weapons (where you have to deal with adding strings to the player, or editing a file, or whatever), etc. RC should be used for setting player strings such as client and clientr.

RC is there for a reason. Playerworld rules actually state that RC functions shouldn't be replaced with insecure scripted ones generally.

[[email protected]]

This tool is mainly to help Admins and Managers of the server get along
quick and easy on player as they come across situations.
Shame if an Admin or Manager finds a way to abuse it.

I just made this to help them go along easier on player, not having to log
onto RC or anything if they didn't want to at the moment. If you don't want
it on your server due to staff you cannot trust, then just don't have it? o.O
The staff that use this on the server I play on, surely aren't as low, and are
highly trust worthy.

So any thoughts like that never came across my mind, I just wanted to share
something I made, that responsible Admins can use for easy get around on player.

[Edit]: But I wasn't aware of this, that you've mentioned "Playerworld rules actually state that RC functions shouldn't be replaced with insecure scripted ones generally"
I'll get to finding a more secure method.

[cbk1994]

A few snippets from Playerworld Rules

NO NPC Should be abusive such as changing players names, changing players looks etc. IF you really need this then it should have security measures such as account and guild checking. And the NPC should log all users actions.

NPCs should not be used to substitute RC rights if they can’t be made secure.

It does mention that things like warpto, summon, etc are okay however, but something like a complete player control NPC is just not secure enough.

[[email protected]]

Well I'll get to adding logs asap then, as well as changing/removing some features too.
Thanks for showing me those, I wasn't aware. ;x

[cbk1994]

May also want to disable some things, maybe have an array like this:

PHP Code:

temp.notAllowed = { "rupees", "hearts", "fullhearts", "kills", "deaths", "clientr.sacred" }; 


or whatever to protect certain scared variables that would most be targeted.

[zokemon]

Originally Posted by Inverness

That explains alot.

Originally Posted by [email protected]

But what I did, was set this up as a serverside action like this, to save up space...

"findplayer(params[1]).params[2] = params[3];"

LOL!
I'll remember that when Unholy Nation explodes one day from "hacking".

[cbk1994]

Originally Posted by zokemon

LOL!
I'll remember that when Unholy Nation explodes one day from "hacking".

Exactly.

[bscharff]

Originally Posted by [email protected]

Please don't get an image of "BlooTool" or anything like that.

Yay?!
I'm popular!
NOT

[cbk1994]

Originally Posted by bscharff

Yay?!
I'm popular!
NOT

Sad when abusive ****ty scripts make you popular ...

[Chompy]

Hmm, I decided to read over your script, and came across a few things.

1.

PHP Code:

Line  984: showPoly( -4 + player.account, {player.x, player.y, player.x + 3, player.y}); 


Why do you use player.account?


2.

Line 1019: say2() -> use of #b, that's gs1


3.

Line 1089: "if (timeout && this.ison == true) {", should be

PHP Code:

function onTimeout() {
  if (this.ison == true) { // or just 'if (this.ison) {'
    ...
  }
} 


4.

Stuff like player.ap, player.fullhearts etc. should be set serverside.


5.

Line 12: Space between function and parenthesis


6.

Line 19: "if (temp.Online = true) {" -> use '=='
And it could even just be

PHP Code:

if (temp.Online) {
  ...
} 


7.

On a server like Unholy Nation I don't think a global say2 command for staff is needed, nor any fun for a player, f.ex durring pk or sparring


8.

Line 339 & 339: Use of object.level should be object.level.name


9.

Line 688: 0.05 is the smallest a timeout can be clientside, 0.1 serverside



Just some stuff I found, hope this can improve your script !