Troubles with gani scripts

[coreys]

I'm using gani scripts for the display heart and nick/chat display on Maloria, but I'm running into trouble. For one thing, they don't always show up for everyone...sometimes they do, sometimes they don't, for no apparent reason. They also don't always work in the GMAP, but, like the other problem, sometimes they do.

It's all very frustrating, and I'm not entirely experienced with gani scripts, so if anyone has an idea, please help. D:

[napo_p2p]

I had pretty much the same problem a while back. It had to do with image objects getting destroyed. Hell Raven helped me out with it. I'm not sure if it applies in your case (you didn't provide a script :P), but here's a link to that thread:

http://forums.graalonline.com/forums...ad.php?t=72305

[coreys]

Well, it's not a problem with playerenters, since I'm not using that. Most of the scripts aren't entirely mine, but rather old maloria script, but I edited them.

The Heart display script:

PHP Code:

function onCreated() {
  showimg(200, "mal_heartanim.gif", (player.x + 0.5)%64, (player.y - 2)%64);
  setTimer(0.05);
}

function onTimeout() {
  findimg(200).x = player.x + 0.5;
  findimg(200).y = player.y - 2;

  if (player.attr[8] == NULL) {
    temp.healthcheck = 0;

    findimg(100).x = player.x + 0.5;
    findimg(100).y = player.y - 2;
  
    temp.healthcheck = player.attr[4] * 100;

    if (temp.healthcheck in |96, 100|) findimg(200).red = 0.1;
    else if (temp.healthcheck in |91, 95|) findimg(200).red = 0.2;
    else if (temp.healthcheck in |86, 90|) findimg(200).red = 0.3;
    else if (temp.healthcheck in |81, 85|) findimg(200).red = 0.4;
    else if (temp.healthcheck in |76, 80|) findimg(200).red = 0.5;
    else if (temp.healthcheck in |71, 75|) findimg(200).red = 0.6;
    else if (temp.healthcheck in |66, 70|) findimg(200).red = 0.7;
    else if (temp.healthcheck in |61, 65|) findimg(200).red = 0.8;
    else if (temp.healthcheck in |56, 60|) findimg(200).red = 0.9;
    else if (temp.healthcheck in |51, 55|) findimg(200).red = 1;
    else if (temp.healthcheck in |46, 50|) findimg(200).green = 0.9;
    else if (temp.healthcheck in |41, 45|) findimg(200).green = 0.8;
    else if (temp.healthcheck in |36, 40|) findimg(200).green = 0.7;
    else if (temp.healthcheck in |31, 35|) findimg(200).green = 0.6;
    else if (temp.healthcheck in |26, 30|) findimg(200).green = 0.5;
    else if (temp.healthcheck in |21, 25|) findimg(200).green = 0.4;
    else if (temp.healthcheck in |16, 20|) findimg(200).green = 0.3;
    else if (temp.healthcheck in |11, 15|) findimg(200).green = 0.2;
    else if (temp.healthcheck in |6, 10|) findimg(200).green = 0.1;
    else if (temp.healthcheck in |1, 5|) findimg(200).green = 0;
  }
  else if (player.attr[8] == "black") {
    with (findimg(200)) {
      mode = red = green = blue = 0;
    }
  }
  else if (player.attr[8] == "white") {
    with (findimg(200)) {
      mode = red = green = blue = 1;
    }
  }
    
  
  setTimer(0.05);
} 


player.attr[4] is hp/maxhp (ignore the part with player.attr[8], I'm probably gonna remove it)

Here's the nickname display script:

PHP Code:

function onCreated() onTimeOut();
function onTimeOut() {
  if (!clientr.stealth) {
    temp.nick = player.attr[10].tokenize("(");
    temp.width1 = (temp.nick[0].length()*6)/16;
    temp.width2 = (player.attr[11].length()*6)/16;
    showtext(200, player.x+1.5-(temp.width1/2), player.y+3, "Verdana", "b", temp.nick[0]);
    changeimgcolors(200, 1, 1, 1, .85);
    changeimgzoom(200, .6);
    showtext(201, player.x+1.5-(temp.width2/2), player.y+3.75, "Verdana", "b", player.attr[11]);
    changeimgcolors(201, 1, 1, 1, .85);
    changeimgzoom(201, .6);
  }
  else hideimgs(200, 201);
  setTimer(0.05);
} 


player.attr[10] is the players nickname

And then this is the chat display script. (It's quite messy, the guy who originally made it wasn't the best scripter)

PHP Code:

function onPlayerEnters() Init();
function onTimeOut() Init();
function Init() {
  if (player.chat.length() > 0) {
    if(this.mode != 1)
      this.mode=1;
    if(this.char != player.attr[16].length()) {
      this.char = player.attr[16].length();
      hideimgs(200,400);
    }
    if(this.text != player.attr[16] || this.chatx != (player.x) ||this.chaty != (player.y+2) || this.chatz != (player.z+2.5)) {
      this.text = player.attr[16];
      temp.tokens = wraptext(56,NULL,player.chat);
      this.chatx = player.x;
      this.chaty = player.y+2;
      this.chatz = player.z+2.5;
      for(i=0;i<temp.tokens.size();i++) {
    temp.width = (temp.tokens[i].length()*4)/16;
        showtext2(200+i,this.chatx-(temp.width/2),this.chaty,this.chatz+(temp.tokens.size()-1)-i,"Comic Sans","b",temp.tokens[i]);
        //Temporary color
        changeimgcolors(200+i,1,1,1,1);
        changeimgzoom(200+i,client.textsize);
        findImg(200+i).layer++;
        showtext2(300+i,this.chatx+.2-(temp.width/2),this.chaty+.2,this.chatz+(temp.tokens.size()-1)-i,"Comic Sans","b",temp.tokens[i]);
        changeimgcolors(300+i,0,0,0,.5);
        changeimgzoom(300+i,client.textsize);
      }
    }
  }
  else {
    if(this.mode == 1) {
      this.mode = 0;
      hideimgs(200,400);
    }
  }
  setTimer(0.05);
} 


I do, however, use onPlayerEnters() in the main system script. I do something like this:

PHP Code:

player.attr[7] = "";
player.attr[7] = "ganiname.gani"; 


To reset the gani script.

[zokemon]

You should be using onPlayerEnters, not onCreated. Gani scripts don't function very well with onCreated and onPlayerEnters is only called when the player seeing the gani first sees it for that instance, not when you actually enter a level.

Also, you should check for every player what their attrs are.

Like if I was doing it and was using you as a test subject, in a clientside test npc I would put:

PHP Code:

//#CLIENTSIDE
function onCreated() {
  player.chat = findplayer("zokemon").attr[2]; // (2 as an example)
} 


I would see if both me and you had the same result in our chats. Then I would just replace zokemon with coreys and again check both of our chat's. Kinda hard to do that when you have chat disabled though so maybe a trigger serverside and an echo(account @ ": " @ result);

[coreys]

Well, I can always enable chat to test that, but also I have another problem. The function textwidth() doesn't work in gani scripts for some reason, and...it's a bit of a problem. I need the width of the text to properly center it. Is there some other way to accurately get the text width?

Oh, also, in the Heart Display gani it's showing an animated heart above the player. But for some reason, under the animation, it shows an un-animated version of that heart (the first frame of it, I guess)

[Crow]

Originally Posted by coreys

Is there some other way to accurately get the text width?

wraptext2() ?

[coreys]

wraptext and wraptext2 don't get the width.

[Crow]

Well, wraptext2 works with the width set in pixels, so you could maybe get what you want with it.

[Chompy]

what you need is gettextwidth() instead of textwidth()

[zokemon]

Originally Posted by Chompy

what you need is gettextwidth() instead of textwidth()

Exactly. textwidth is from GS1 and thus does not use quotes for the string within it (just like most gs1 string related commands).

If you try to do textwidth(this.chat, params) (don't know the placement of the arguements) you would simply get 9 all the time .

[coreys]

Actually it was returning 0. I just didn't work at all. lol
But yeah, thanks Chompy!

Now to get that display heart to work right. >.<
It disappears whenever you go into a different level or whenever the WNPC that sets the player.attr[] for the gani is updated, or sometimes just not at all.

[zokemon]

Did you use onPlayerEnters like I said?

[coreys]

Yes, I did.

[Crow]

Try something like this:

PHP Code:

function onCreated()
  onPlayerEnters();
function onPlayerEnters()
  functionThatLeadsToCoreScript(); 


Doing that in all my gani scripts.

[zokemon]

Originally Posted by Crow

Try something like this:

PHP Code:

function onCreated()
  onPlayerEnters();
function onPlayerEnters()
  functionThatLeadsToCoreScript(); 


Doing that in all my gani scripts.

Like I said, onCreated is pointless in gani scripts. Just don't use it.

[coreys]

Blah, I'm still having trouble with peoples names and display hearts not always showing up and problems with GMAPs.

[Crow]

Originally Posted by zokemon

Like I said, onCreated is pointless in gani scripts. Just don't use it.

That was actually the tiny part that got my gani scripts to work, so I have no idea what you are talking about.

[coreys]

Yeah, I've figured that the nick display gani stops showing when you go into the overworld, even if you come back into another level.
This is what I have for that script:

PHP Code:

function onPlayerEnters() {
  this.nick = "";
  this.guild = "";
  onTimeOut();
}
function onTimeOut() {
  if (!clientr.stealth) {
    if (this.nick != player.attr[10] || this.guild != player.attr[11])
      updateNick();
    for (i=0; i<4; i++) {
      changeimgcolors(200+i, player.attr[17], player.attr[18], player.attr[19], .8);
      changeimgzoom(200+i, this.size);
    }
    changeimgcolors(202, 0, 0, 0, .3);
    changeimgcolors(203, 0, 0, 0, .3);
  }
  else hideimgs(200,203);
  if (this.font != player.attr[21] || this.style != player.attr[22] || this.size != player.attr[23])
    updateNick();
  setTimer(0.05);
}
function updateNick() {
  hideimgs(200,203);
  this.font = player.attr[21];
  this.style = player.attr[22];
  this.size = player.attr[23];
  this.nick = player.attr[10];
  this.guild = player.attr[11];
  temp.n = this.nick.tokenize("(");
  temp.width1 = gettextwidth(this.size, this.font, this.style, temp.n[0])/16;
  temp.width2 = gettextwidth(this.size, this.font, this.style, this.guild)/16;
  showtext(200, player.x+1.5-(temp.width1/2), player.y+3, this.font, this.style, temp.n[0]);
  showtext(201, player.x+1.5-(temp.width2/2), player.y+3.75, this.font, this.style, this.guild);
  showtext(202, player.x+1.5+(1/8)-(temp.width1/2), player.y+3+(1/8), this.font, this.style, temp.n[0]);
  showtext(203, player.x+1.5+(1/8)-(temp.width2/2), player.y+3.75+(1/8), this.font, this.style, this.guild);
  for (i=0; i<4; i++) {
    changeimgcolors(200+i, player.attr[17], player.attr[18], player.attr[19], .85);
    changeimgzoom(200+i, this.size);
    findImg(200+i).attachtoowner = true;
  }
  changeimgcolors(202, 0, 0, 0, .85);
  changeimgcolors(203, 0, 0, 0, .85);
  findImg(200).layer++;
  findImg(201).layer++;
} 


Also, my heart display keeps turning black at random times, and I can't really figure out why...

PHP Code:

function onCreated() {
  showimg(200, "mal_heartanim.gif", (player.x + 0.5)%64, (player.y - 2)%64);
  setTimer(0.05);
}
function onPlayerEnters() {
  showimg(200, "mal_heartanim.gif", (player.x + 0.5)%64, (player.y - 2)%64);
  setTimer(0.05);
}
function onTimeout() {
  findimg(200).x = player.x + 0.5;
  findimg(200).y = player.y - 2;

  temp.healthcheck = player.attr[4]*100;

  findimg(200).x = player.x + 0.5;
  findimg(200).y = player.y - 2;
  if (temp.healthcheck in |96, 100|) temp.colors = {0,1};
  else if (temp.healthcheck in |91, 95|) temp.colors = {.05,.95};
  else if (temp.healthcheck in |86, 90|) temp.colors = {.1,.9};
  else if (temp.healthcheck in |81, 85|) temp.colors = {.15,.85};
  else if (temp.healthcheck in |76, 80|) temp.colors = {.2,.8};
  else if (temp.healthcheck in |71, 75|) temp.colors = {.25,.75};
  else if (temp.healthcheck in |66, 70|) temp.colors = {.3,.7};
  else if (temp.healthcheck in |61, 65|) temp.colors = {.35,.65};
  else if (temp.healthcheck in |56, 60|) temp.colors = {.4,.6};
  else if (temp.healthcheck in |51, 55|) temp.colors = {.45,.55};
  else if (temp.healthcheck in |46, 50|) temp.colors = {.5,.5};
  else if (temp.healthcheck in |41, 45|) temp.colors = {.55,.45};
  else if (temp.healthcheck in |36, 40|) temp.colors = {.6,.4};
  else if (temp.healthcheck in |31, 35|) temp.colors = {.65,.35};
  else if (temp.healthcheck in |26, 30|) temp.colors = {.7,.3};
  else if (temp.healthcheck in |21, 25|) temp.colors = {.75,.25};
  else if (temp.healthcheck in |16, 20|) temp.colors = {.8,.2};
  else if (temp.healthcheck in |11, 15|) temp.colors = {.85,.15};
  else if (temp.healthcheck in |6, 10|) temp.colors = {.9,.1};
  else if (temp.healthcheck in |1, 5|) temp.colors = {.95,.05};
  findImg(200).red = temp.colors[0];
  findImg(200).green = temp.colors[1];
  findImg(200).blue = 0;
  setTimer(0.05);
}