Custom Classes! - Page 2

Inverness · #16 12-09-2007, 10:13 PM

If we had support for global functions the way I wanted (including Control-NPC in the function lookup), it would be a simple and easy deal to have global functions (temp.var = TObjectType();) to return the new object instance.

Novo · #17 12-09-2007, 10:32 PM

Quote:

Originally Posted by Inverness

If...

Anyhow...

I made an addition to my TMap set. For those of you who want to use it, I've made a static function for it:

class_tmap_static (Class)

PHP Code:


			
public function merge( map1, map2, mergeRules )
{
  // Sanity Check
  if ( !map1.instanceOf( TMap ) || !map2.instanceOf( TMap ))
  {
    echo("Input aren't TMaps!");
    return null; // Force programmer to input CORRECT Data!
  }

  // Change Merger to supplied one
  temp.oldMerger = this.mergeValue;
  if ( mergeRules != null )
    this.mergeValue = mergeRules;

  // Copy first Map to a new map
  temp.sum = this.newInstance( map1.toArray() );
  temp.keys = temp.sum.keySet();

  // Add second map to new map
  temp.mapSet = map2.toArray();
  for ( temp.mapValue: temp.mapSet )
  {
    // If new map contains given key
    if ( temp.mapValue[0] in temp.keys )
    {
      // Merge them together
      temp.newValue = mergeValue(
        temp.mapValue[0], // key
          temp.mapValue[1], // val1
          temp.sum.get( temp.mapValue[0] ) // val2
        );
      
      temp.sum.put( temp.mapValue[0], temp.newValue );
    } else {
      // Otherwise, put second map data to the new map.
      temp.sum.put( temp.mapValue[0], temp.mapValue[1] );
    }
  }
  
  // Revert back to old merger
  this.mergeValue = temp.oldMerger;  

  return temp.sum;
}

function mergeValue( key, val1, val2 )
{ // Default
  // val1 + val2 should be the same as val2 + val1.
  return (val1 + val2);
}

Example of Usage:

PHP Code:


			
function onCreated()
{
  mod1 = TMap.newInstance({{"a",3}, {"b", 1}} );
  mod2 = TMap.newInstance({{"a",2}, {"b", 1}, {"c", 1}} );

  temp.merger = function( key, val1, val2 ) {
    switch ( key )
    {
      case "a":
        return val1 * val2;
      default:
        return val1 + val2;
    }
  };

  mod3 = TMap.merge( mod1, mod2, temp.merger );
  echo( mod3.toArray() ); // "a,6","b,2","c,1"
}

Inverness · #18 12-09-2007, 10:37 PM

Quote:

Originally Posted by Novo

Anyhow...

Too complex for average use.

Novo · #19 12-09-2007, 10:53 PM

Quote:

Originally Posted by Inverness

Too complex for average use.

But Powerful for those who know how to use it. Additionally, the merger comes with a default way of merging. It isn't necessary to define your own function, but the power is there if you do!

PHP Code:


			
function onCreated()
{
  mod1 = TMap.newInstance({{"a",3}, {"b", 1}} );
  mod2 = TMap.newInstance({{"a",2}, {"b", 1}, {"c", 1}} );

  mod3 = TMap.merge( mod1, mod2 );
  echo( mod3.toArray() ); // "a,5","b,2","c,1"
}

Simple for those who don't need more.

Inverness · #20 12-09-2007, 11:31 PM

Quote:

Originally Posted by Novo

But Powerful for those who know how to use it. Additionally, the merger comes with a default way of merging. It isn't necessary to define your own function, but the power is there if you do!

PHP Code:


			
function onCreated()

{

  mod1 = TMap.newInstance({{"a",3}, {"b", 1}} );

  mod2 = TMap.newInstance({{"a",2}, {"b", 1}, {"c", 1}} );



  mod3 = TMap.merge( mod1, mod2 );

  echo( mod3.toArray() ); // "a,5","b,2","c,1"

}

Simple for those who don't need more.

Can you tell me an instance where it would be used in-game?

Novo · #21 12-09-2007, 11:37 PM

Sure... Phone-Address look-up. In Era.

PHP Code:


			
Phones.phoneMap = TMap.newInstance();

// In various locations around the world
Phones.phoneMap.put("553-4234", this );


// To phone...
otherPhone = Phones.phoneMap.get( "553-4234" );
otherPhone.chat = "*ring* *ring*";

Merger...
Item System:

PHP Code:


			
items = TMap.newInstance();
items.put( itemID, {quant, state});

merger = function( key, val1, val2 ){ return {val1[0] + val2[0], val1[1] || val2[1]}; }
items = TMap.merge( items, TMap.newInstance( {{ itemID, quant, 0 }}, merger );

... There are many situations that it could come up.

What I use it for is to have a cumulative effects from the clothing that the player uses.
For instance, let's say 'Speed'...

PHP Code:


			
Special Boots = TMap.newInstance( {{"Speed", 5}});
Other Clothing = TMap.n... ...

mods = playerMods;
mods = TMap.merge( mods, racialMods );
for ( clothes: all worn clothes )
  mods = TMap.merge( mods, clothes.mods );

player.speed = mods.get("Speed");

This is done FOR-ALL possible (and future) attributes:

PHP Code:


			
  temp.modList = temp.mod.toArray();
  for ( temp.mod: temp.modList )
    clientr.(@ temp.mod[0] ) = temp.mod[1];

Inverness · #22 12-10-2007, 12:49 AM

Quote:

Originally Posted by Novo

Sure... Phone-Address look-up. In Era.

That may 'work' but using a specialized function is much simpler and to the point.

Quote:

Originally Posted by Novo

What I use it for is to have a cumulative effects from the clothing that the player uses.

I just scan equipped items in the mud object and add their affects to the player's.

You're really over-complicating things that are simple to do with regular scripts. Thats not a good way to bring new scripters into the scene.

Novo · #23 12-10-2007, 01:05 AM

Quote:

Originally Posted by Inverness

That may 'work' but using a specialized function is much simpler and to the point.
I just scan equipped items in the mud object and add their affects to the player's.

You're really over-complicating things that are simple to do with regular scripts. Thats not a good way to bring new scripters into the scene.

Inverness, I've provided quite a dynamic way to do a variety of things. If you don't appreciate it for whatever reason you have (which seems to be whatever you can seem to think of), then that's that. Otherwise... There are MANY ways to skin a cat. This is one of them...

I don't think introducing new programmers to concepts such as these will help... But alternatively, for those in the know, these techniques could be used with a wide range of successful usage. Ultimately, by my publishing the code, I didn't make it ANY HARDER to learn to script. In fact, that wasn't even my targeted audience. (Additionally, new programmers could learn by example, so they might not see the full utility, but something like that could let them see how reflective programming could be done )

Whether it is overcomplicating something, or providing a bigger re-usability... It doesn't matter that much. Sure, some things just need a little function to work. Others will need more. And in the end, everything can be hard-coded as one massive monolith. In fact, you could program Graal in ONE FUNCTION.

Now, if you want to argue the value of TMap... I just provided it as a quick freebie and numerous incidents it could be used. If you're debating about Class System... I think you would already be in a level where you can use it if you considered that it is beneficial to use it in the first place. I provided quite a bit of flexibility.

Ultimately, I AM SORRY FOR GIVING YOU FREE CODE, go cry me a river. ( I refuse to feed your troll habits any further. )

cbk1994 · #24 12-10-2007, 01:21 AM

Quote:

Originally Posted by Novo

I AM SORRY FOR GIVING YOU FREE CODE

You should be!

Inverness · #25 12-10-2007, 02:12 AM

Quote:

Originally Posted by Novo

<snip>

My issue is because I did exact same thing about a year ago and found that it wasted too much time and CPU making things super flexible and modular rather than just scripting it to do what it needs to do in less time.

Though it seems our situations are different if you don't have something you need to be working on and are just scripting for fun. Though, if you do have something you need to do with this all (like making the system for a server) I wouldn't suggest such things.

I'm just trying to save you from wasting time overdoing it :P, redesigning systems and such can kill a server under construction.

Quote:

Originally Posted by cbkbud

You should be!

Go away, the grown-up scripters are talking now.