Playerworld Inspections: Scripting

[Andy0687]

How can styling and readbility be judged?

I dont get the basis for doing that, if the scripts work and are not computer intensive, who cares who can read it, chances are everyone on the server has an idea what is going on, and thats all that is importaint. Right?

[Skyld]

Originally Posted by Andy0687

How can styling and readbility be judged?

I dont get the basis for doing that, if the scripts work and are not computer intensive, who cares who can read it, chances are everyone on the server has an idea what is going on, and thats all that is importaint. Right?

Styling and readability can easily be judged on whether the script's structure is immediately obvious when you open a script.
For example, a script like this...

PHP Code:

function oncreated()
{if (this.foo==this.bar)
{this.something=somethingelse;
this.otherFunction();}
} 


... is much less readable than:

PHP Code:

function onCreated()
{
  if (this.foo == this.bar)
  {
    this.something = this.somethingelse;
  }
} 


... especially with longer scripts.

If you have to sit and think out the structure of a script, i.e. how many code blocks you've ventured into at a given point and for what conditions, then it's badly structured.

[Projectshifter]

Originally Posted by Andy0687

How can styling and readbility be judged?

That's one of the reasons I don't like what is on the wiki right now. You don't get judged on that, but if you can't read it you can't evaluate the script. I have seen too many servers that have scripts that aren't indented at all. It makes it virtually impossible to read, and it isn't the job of the GST to go through and style everything. If someone wants their server up, then they should have no problem styling their scripts, even if it's after the fact and they do it with NC or the offline editor. It's kind of a lesson they need to learn. If you plan to continue coding, regardless of what language, you're not going to be taken seriously if you don't style, no matter how good your stuff is.

[napo_p2p]

Originally Posted by Projectshifter

That's one of the reasons I don't like what is on the wiki right now. You don't get judged on that, but if you can't read it you can't evaluate the script. I have seen too many servers that have scripts that aren't indented at all. It makes it virtually impossible to read, and it isn't the job of the GST to go through and style everything. If someone wants their server up, then they should have no problem styling their scripts, even if it's after the fact and they do it with NC or the offline editor. It's kind of a lesson they need to learn. If you plan to continue coding, regardless of what language, you're not going to be taken seriously if you don't style, no matter how good your stuff is.

I remember a long time ago, I asked Projectshifter to help me with some pickaxe script, but I had it all on one line, and I think it killed him.

But then I used:
with(getplayer(Projectshifter)) {playerhearts += 20;}

So he breathes again.

[Projectshifter]

Originally Posted by napo_p2p

I remember a long time ago, I asked Projectshifter to help me with some pickaxe script, but I had it all on one line, and I think it killed him.

But then I used:
with(getplayer(Projectshifter)) {playerhearts += 20;}

So he breathes again.

I was revived and then promptly arrested for strangling napo and his lack of styling