hmmmm

[Lance]

Originally Posted by napo_p2p

'toweapons' is bad with an NPC server...

Correct.

Having 'isweapon' and 'strequals(#w,Lightning2)' is redundant.

Incorrect. isweapon has nothing to do with the currently selected weapon. It is a deprecated flag which returns true if the script is a weapon script and false if it is not.

[napo_p2p]

Originally Posted by Lance

Incorrect. isweapon has nothing to do with the currently selected weapon. It is a deprecated flag which returns true if the script is a weapon script and false if it is not.

I meant in the sense that if the weapon is the currently selected weapon, then it obviously is a weapon :P.

[Lance]

Originally Posted by napo_p2p

I meant in the sense that if the weapon is the currently selected weapon, then it obviously is a weapon :P.

Using the deprecated isweapon flag in a weapon is in and of itself redundant. Whether or not you are checking the currently selected weapon is irrelevant and adds nothing to this statement but misrepresentation.

[napo_p2p]

Originally Posted by Lance

Using the deprecated isweapon flag in a weapon is in and of itself redundant. Whether or not you are checking what the currently selected weapon is irrelevant and adds nothing to this statement but misrepresentation.

You're too good .

[excaliber7388]

still dun work

NPC Code:

---

//NPC made By Excaliber

//#CLIENTSIDE

if (isweapon && strequals(#w,Lightning) && weaponfired && playermp>4 || isweapon && strequals(#w,Lightning) && mousedown && playermp>4){

  disabledefmovement;

  showimg 300,dr-crosshairs.png,mousex-.5,mousey-.35;

  this.shooting = 1;

  timeout=.05;

}

if(isweapon && this.shooting==1 && timeout){

  replaceani idle,grab;

  setani grab,;

  showimg 300,dr-crosshairs.png,mousex-.5,mousey-.35;

  timeout=.05;

}

if(this.shooting==1&&keypressed&&strequals(#p(1),A  )){

  this.shooting = 0;

  hideimg 300;

  enabledefmovement;

  replaceani idle,idle;

  setani idle,;

}



if(strequals(#w,Lightning) && this.shooting==1 && mousedown && leftmousebutton){

  this.shooting = 0;

  playermp=playermp-5;

  showimg 400,dr-lightning.png,mousex-.5,mousey-8;

  newx2 = mousex;

  newy2 = mousey;

   for(i=1;i<100;i=i+25){

     changeimgpart 400,0,0,35,i;

     sleep .05;

   }

  putexplosion2  3,2,newx2-.75,newy2-.75;

  hideimg 400;

  hitobjects 2,mousex,mousey;

  hitobjects 2,mousex-.25,mousey-.25;

  hitobjects 2,mousex+.25,mousey-.25;

  hitobjects 2,mousex-.25,mousey+.25;

  hideimg 300;

  timeout=.05;

  replaceani idle,idle;

  setani idle,;

  this.shooting = 0;

  enabledefmovement;

  hideimg 302;

  sleep 3;

  hideimg 301;

}

if(timeout&&!litshooting){

  hideimg 300;

}

---

[Skyld]

i=i+25 should be i += 25.

Also, you should also stop mixing things in if statements that are not related.
i.e. isweapon and playermp are in no way related, so stop putting them in the same check.

Finally, what the hell are you doing with replaceani idle,idle;?

[excaliber7388]

Originally Posted by Skyld

i=i+25 should be i += 25.

Same thing

Originally Posted by Skyld

Also, you should also stop mixing things in if statements that are not related.
i.e. isweapon and playermp are in no way related, so stop putting them in the same check.

it works for everything else, and is a quick way to make sure that th player has enough MP and is doing the attack

Finally, what the hell are you doing with replaceani idle,idle;?

XD make sure idle is the gani XD not fully necessary

[Skyld]

Originally Posted by excaliber7388

Same thing

Why not make it easier to read?

Originally Posted by excaliber7388

it works for everything else, and is a quick way to make sure that th player has enough MP and is doing the attack

Whether it works is not the point. You should not be mixing things like that; it's bad practice.

[excaliber7388]

still, not the problem here

[napo_p2p]

Originally Posted by excaliber7388

still, not the problem here

Skyld is just saying that it would be easier for people to help you if they could easily read the script without having to figure out things because of bad formatting.

[Skyld]

Originally Posted by napo_p2p

Skyld is just saying that it would be easier for people to help you if they could easily read the script without having to figure out things because of bad formatting.

Yes.

People don't like looking at badly formatted code, and therefore you stand less chance of being helped since people just can't work with it.

[Torankusu_2002]

yeah, it's almost impossible to help pinpoint errors if your code is as bull****-formatted as yours is.

read the guide.

[excaliber7388]

See there's the problem I guess, I have no trouble reading badly formatted scripts. Guess I'll have to get reading

[excaliber7388]

This script does not work aroung NPC baddies either It works everywhere else, but not around a baddie when used around a baddie, the water stays beneither the player

NPC Code:

---

//#CLIENTSIDE

if(weaponfired&&playermp>4){

  playermp=playermp-5;

    if(playerdir=0){

      for(i=1;i<31;i=i+2){

        sleep .05;

        putleaps 5,playerx+.5,playery-i;

        hitobjects 2,playerx+.5,playery-i;

     

  }

}

   if(playerdir=2){

     for(i=3;i<31;i=i+2){

      sleep .05;

      putleaps 5,playerx+.5,playery+i;

      hitobjects 2,playerx+.5,playery+i;

    

   }

 }

   if(playerdir=1){

     for(i=3;i<31;i=i+2){

       sleep .05;

       putleaps 5,playerx-i,playery+1.5;

       hitobjects 2,playerx-i,playery+1.5;

    

   }

 }

  if(playerdir=3){

    for(i=3;i<31;i=i+2){

      sleep .05;

      putleaps 5,playerx+i,playery+1.5;

      hitobjects 2,playerx+i,playery+1.5;

    

   }

 }

enabledefmovement

  }

}

---