with(npcs[npcscount-1]) Priority ? - Page 3

Lance · #31 01-25-2005, 07:37 AM

Quote:

Originally Posted by Projectshifter

I'm going to have to side with Stefan now in the assumption that it is something else with your script. I got on UN and tried it and it works fine. if (created) in the new NPC is called after the 1st NPC (the one that created the new one) finishes it's loop or so. It set the strings and worked fine with if (created). You could do something like this if it's perhaps not adding them

NPC Code:



oldnpcscount = npcscount;

while (npcscount == oldnpcscount)

 create();

with(npcs[npcscount-1])

 blah;



function create()

 putnpc2 x,y,{blah;}

This way it would ensure it really adds the NPC before continuing, and if it doesn't add it, it will try to add it again.

Not to burst your bubble, but the placement of your while is not very good.

Kaimetsu · #32 01-25-2005, 08:05 AM

Quote:

Originally Posted by Slash-P2P

I agree (kind of) but I still don't see anything about bashing in "Show off your best NPCs or ask the experts"

Nor do I see anything about answering questions or helping to solve problems. Should we be banned from doing that also?

You really should think about your arguments before you use them.

Projectshifter · #33 01-25-2005, 08:16 AM

Quote:

Originally Posted by Lance

Not to burst your bubble, but the placement of your while is not very good.

I disagree, as it checks to make sure if it's created, not that it sets the things. If what he said is true, then it's not adding the NPCs (as stefan said), and it basically replaces Stefan's if (npcscount > oldnpcscount) by continually trying to add it if it fails. Perhaps I've been doing java too much lately, but I think it is in a fine place? But I'm open to other opinions

TB3 · #34 01-25-2005, 08:57 AM

Quote:

Originally Posted by Projectshifter

I'm going to have to side with Stefan now in the assumption that it is something else with your script. I got on UN and tried it and it works fine. if (created) in the new NPC is called after the 1st NPC (the one that created the new one) finishes it's loop or so. It set the strings and worked fine with if (created). You could do something like this if it's perhaps not adding them

NPC Code:



oldnpcscount = npcscount;

while (npcscount == oldnpcscount)

 create();

with(npcs[npcscount-1])

 blah;



function create()

 putnpc2 x,y,{blah;}

This way it would ensure it really adds the NPC before continuing, and if it doesn't add it, it will try to add it again.

The problem was not that the npc was not being added (or my script), it was that the newly added npc was not having its strings set. And as I said stefans code

NPC Code:



oldnpcscount = npcscount;

putnpc2 ...

if (npcscount>oldnpcscount) with (npcs[oldnpcsount]) { ... }

Did not work at first , he came on to the server and removed the
if (npcscount>oldnpcscount)
And then it worked ( thats when he posted "works for me" )

The real problem is that after the putnpc2 the npcscount was increasing (on very small occasions) do some local npcs loading into memory a bit farther than it should , before the with() took place, even though it was directly following the putnpc2 command. Thus the wrong npc was getting the strings set. So the new way

PHP Code:


			
  oldnpcscount = npcscount;

  putnpc2 x,y,{

    join baddy;

  };

  with(npcs[oldnpcscount]) {

    //code....

  }

Works fine now. These problems however don't seem to occur in regular maps / levels just in gmaps for some reason. (As I have yet to have a problem with the npcs in regular levels)

Projectshifter · #35 01-25-2005, 09:13 AM

Quote:

Originally Posted by TB3

The real problem is that after the putnpc2 the npcscount was increasing (on very small occasions) do some local npcs loading into memory a bit farther than it should , before the with() took place, even though it was directly following the putnpc2 command. Thus the wrong npc was getting the strings set. So the new way

That is rather odd, but makes sense as to why it wouldn't work. Seems strange though that it wouldn't be adding the # properly or what-not. I'm tired, but glad you figured it out.

TB3 · #36 01-25-2005, 09:17 AM

Quote:

Originally Posted by Projectshifter

That is rather odd, but makes sense as to why it wouldn't work. Seems strange though that it wouldn't be adding the # properly or what-not. I'm tired, but glad you figured it out.

Yes it is , I'm still a bit unsure what to think of it still lolz
And thanks for trying to help
If I find anything else out or the script bugs anymore I'll post again
Im gone to bed l8 l8 and i have get up in 2.75 hours cooolege

Admins · #37 01-25-2005, 04:57 PM

The most important thing is that you are accessing npcscount before adding the npc, because accessing npcscount is causing the local npcs to be loaded, all local npcs in a radius of 1 level.
Most of the time the local npcs are already loaded, because several script commands have the side effect of the npcs being loaded, but in special cases it can happen that you are adding an npc into an area where there is no player and no npc activity. Before adding the npc the local npcs of the current level are loaded (radius 0), but not of the surrounding levels, may be I should change that.
It might sound simple, but I must keep care to not cause a chain reaction, e.g. a local npc putting an npc, the surrounding levels are loaded, the local npcs of the surrounding levels are putting new npcs, at the end the whole gmap is loaded into memory. With putnpc2 it should not be a problem though since I don't expect local npcs to use that command when they are loaded.

Ok will make putnpc2 load all surrounding levels before adding the new npc, then it should work better.