Graal Forums  

Go Back   Graal Forums > Graal V6 forums > Bug Report
FAQ Members List Calendar Today's Posts

Reply
 
Thread Tools Search this Thread Rate Thread Display Modes
  #1  
Old 10-04-2010, 07:03 AM
xXziroXx xXziroXx is offline
Master of Puppets
xXziroXx's Avatar
Join Date: May 2004
Location: Sweden
Posts: 5,288
xXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant future
Send a message via AIM to xXziroXx Send a message via MSN to xXziroXx
player.communityname

This is the most major bug that makes people on servers not work with community names at all, and I don't think it would be too hard for Stefan to do something about it.

On accounts that hasn't chosen a community name for their account yet, player.communityname equals "". Could it be made so that in those instances, it instead equals player.account (which would be Graal######)?

Examples:

PHP Code:
Account Type: [account name][community name]
---------------------------------------------
Lifetime Classic account: [xXziroXx][xXziroXx]

Gold account with defined community name: [Graal766206][MaloriaDev1]

Guest: [pc:4419][guest]

Trial account without defined community name: [Graal766276][]

Gold account without defined community name: [Graal766276][] 
As you can see, the result speaks for itself.
__________________

"A delayed game is eventually good, but a rushed game is forever bad." - Shigeru Miyamoto
Reply With Quote
  #2  
Old 10-04-2010, 07:06 AM
iSlayer iSlayer is offline
Snk for manager
iSlayer's Avatar
Join Date: Feb 2010
Location: Room 7, Era Hotel, Era
Posts: 202
iSlayer will become famous soon enough
How is it a bug
__________________
Snk for manager




Quote:
Originally Posted by Admins View Post
Snk for manager of Era
Reply With Quote
  #3  
Old 10-04-2010, 07:16 AM
MrDumbledore MrDumbledore is offline
Headmaster of Hogwarts
MrDumbledore's Avatar
Join Date: Oct 2010
Location: The Leaky Cauldron
Posts: 31
MrDumbledore is on a distinguished road
Also, guests shouldn't have the "guest" community name. They need some kind of unique identifier that is also player-friendly.
__________________
It is our choices, Harry, that show what we truly are, far more than our abilities.
Reply With Quote
  #4  
Old 10-04-2010, 07:17 AM
xXziroXx xXziroXx is offline
Master of Puppets
xXziroXx's Avatar
Join Date: May 2004
Location: Sweden
Posts: 5,288
xXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant future
Send a message via AIM to xXziroXx Send a message via MSN to xXziroXx
Quote:
Originally Posted by iSlayer View Post
How is it a bug
Because doing findPlayerByCommunityName("") wouldn't work for accounts that doesn't have one defined.

The most common workaround for servers right now is to use a custom community name string, like...

NPC Code:
client.communityName = (player.communityname == "" ? player.account : player.communityname);

__________________

"A delayed game is eventually good, but a rushed game is forever bad." - Shigeru Miyamoto
Reply With Quote
  #5  
Old 10-04-2010, 08:02 AM
Tigairius Tigairius is offline
The Cat
Tigairius's Avatar
Join Date: Jan 2007
Location: Missouri, USA
Posts: 4,240
Tigairius has a brilliant futureTigairius has a brilliant futureTigairius has a brilliant futureTigairius has a brilliant futureTigairius has a brilliant futureTigairius has a brilliant futureTigairius has a brilliant futureTigairius has a brilliant future
Yes, it would be nice if player.communityname returned the account name if no communityname is set. I know this has always been a big hassle with using player.communityname.
__________________


“Shoot for the moon. Even if you miss, you'll land among the stars.”
Reply With Quote
  #6  
Old 10-04-2010, 08:08 AM
xXziroXx xXziroXx is offline
Master of Puppets
xXziroXx's Avatar
Join Date: May 2004
Location: Sweden
Posts: 5,288
xXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant futurexXziroXx has a brilliant future
Send a message via AIM to xXziroXx Send a message via MSN to xXziroXx
Quote:
Originally Posted by MrDumbledore View Post
Also, guests shouldn't have the "guest" community name. They need some kind of unique identifier that is also player-friendly.
I agree with this. I haven't tried it, but imagine trying to use findPlayerByCommunityName("guest") on a server with 10+ guests online?
__________________

"A delayed game is eventually good, but a rushed game is forever bad." - Shigeru Miyamoto
Reply With Quote
  #7  
Old 10-11-2010, 06:16 PM
Admins Admins is offline
Graal Administration
Join Date: Jan 2000
Location: Admins
Posts: 11,693
Admins has much to be proud ofAdmins has much to be proud ofAdmins has much to be proud ofAdmins has much to be proud ofAdmins has much to be proud ofAdmins has much to be proud of
Use account name for identification and nick name (or community name) for displaying.
Reply With Quote
  #8  
Old 10-11-2010, 07:05 PM
fowlplay4 fowlplay4 is offline
team canada
fowlplay4's Avatar
Join Date: Jul 2004
Location: Canada
Posts: 5,200
fowlplay4 has a reputation beyond reputefowlplay4 has a reputation beyond reputefowlplay4 has a reputation beyond reputefowlplay4 has a reputation beyond reputefowlplay4 has a reputation beyond reputefowlplay4 has a reputation beyond reputefowlplay4 has a reputation beyond reputefowlplay4 has a reputation beyond reputefowlplay4 has a reputation beyond reputefowlplay4 has a reputation beyond reputefowlplay4 has a reputation beyond repute
Quote:
Originally Posted by Stefan View Post
Use account name for identification and nick name (or community name) for displaying.
We do... It's the inconsistencies that are the problem (clearly labeled in the original post), and here's one simple way to fix that.

1. Force new players (without a community name) to pick a community name off the bat (first client login).

a. Allows players to be more memorable within the community.
b. Fixes the issue with player.communityname equaling ""

2. Guest (pc:######) accounts should community name should default to something like Guest######.

The way it's setup right now makes us jump unnecessary hoops when a presentable default identifier could easily be provided without having to use a hack like this:

PHP Code:
public function getProperName() {
  if (
player.account.starts("pc:")) {
    return 
"Guest" player.substring(3);
  }
  return (
player.communityname player.communityname player.account);

__________________
Quote:
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +2. The time now is 08:41 AM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.
Copyright (C) 1998-2019 Toonslab All Rights Reserved.