Shared functions pack

[DustyPorViva]

Originally Posted by cbk1994

temp variables are specific to the function, so no.

Good point! Completely forgot about that.

[MrOmega]

Hey, I'm getting an error sometimes that 'shared.roundto()' not found. Any thought as to why?

[DustyPorViva]

Originally Posted by MrOmega

Hey, I'm getting an error sometimes that 'shared.roundto()' not found. Any thought as to why?

Are you using it clientside?

[MrOmega]

Originally Posted by DustyPorViva

Are you using it clientside?

Yes

[MrOmega]

sorry for this... but bump, why do I sometimes get this error?

[fowlplay4]

You could try referencing the weapon directly: (@"-Shared").roundto()

Then maybe just make a copy of the function so your code looks a little neater:

PHP Code:

function roundto() {
  return (@"-Shared").roundto();
} 


[ffcmike]

Originally Posted by Skyld

shared.getAlignmentColor(ap)
Returns an array of {red, green, blue} for the given AP color, allowing you to recreate the default nickname colors.

PHP Code:

shared.getAlignmentColor(player.ap); 


shared.getAlignmentShadowColor(red, green, blue)
Returns an array of {red, green, blue} for the shadow of the given color, allowing you to recreate the default nickname shadows.

PHP Code:

shared.getAlignmentShadowColor(0.75, 0.1, 0.3); 


I recently did some testing comparing the time it takes to loop through 0-100 between these shared functions and what we were using to calculate it on Classic.
It turns out that Classic's method was roughly twice as fast as the shared function, though some (wouldn't rule out all) of this time may have been down to the fact that public functions take a little bit longer.

Me/WhiteDragon then decided to try storing all of the values within an array like this:

PHP Code:

//#CLIENTSIDE
function onCreated(){
  this.apv = {
    {64,0,0},
    {128,64,64},
    {133,62,62},
    {138,59,59},
    {143,57,57},
    {148,54,54},
    {153,52,52},
    {158,49,49},
    {163,47,47},
    {168,44,44},
    {173,41,41},
    {178,39,39},
    {183,36,36},
    {188,34,34},
    {194,31,31},
    {199,29,29},
    {204,26,26},
    {209,24,24},
    {214,21,21},
    {219,18,18},
    {224,16,16},
    {229,13,13},
    {234,11,11},
    {239,8,8},
    {244,6,6},
    {249,3,3},
    {255,0,0},
    {255,10,10},
    {255,21,21},
    {255,31,31},
    {255,42,42},
    {255,53,53},
    {255,63,63},
    {255,74,74},
    {255,85,85},
    {255,95,95},
    {255,106,106},
    {255,116,116},
    {255,127,127},
    {255,138,138},
    {255,148,148},
    {255,159,159},
    {255,170,170},
    {255,180,180},
    {255,191,191},
    {255,201,201},
    {255,212,212},
    {255,223,223},
    {255,233,233},
    {255,244,244},
    {255,255,255},
    {255,255,255},
    {255,255,255},
    {255,255,255},
    {255,255,255},
    {255,255,255},
    {230,255,230},
    {205,255,205},
    {179,255,179},
    {154,255,154},
    {128,255,128},
    {128,255,128},
    {116,255,140},
    {103,255,153},
    {90,255,166},
    {77,255,178},
    {64,255,191},
    {52,255,204},
    {39,255,216},
    {26,255,229},
    {13,255,242},
    {0,247,255},
    {0,238,255},
    {0,229,255},
    {0,220,255},
    {0,212,255},
    {0,203,255},
    {0,194,255},
    {0,185,255},
    {0,176,255},
    {0,168,255},
    {0,159,255},
    {0,150,255},
    {0,141,255},
    {0,132,255},
    {0,124,255},
    {0,115,255},
    {0,106,255},
    {0,97,255},
    {0,88,255},
    {0,80,255},
    {0,71,255},
    {0,62,255},
    {0,53,255},
    {0,44,255},
    {0,36,255},
    {0,27,255},
    {0,18,255},
    {0,9,255},
    {0,0,255},
    {231,199,0}
  };
}

public function getAlignmentColors(temp.ap) {
  temp.ac = this.getAlignmentColor(temp.ap);
  if(temp.ap == 100){
    temp.sc = {255, 255, 0};
  }
  else{
    temp.c = 255 * !(temp.ac[0]>191.25 || temp.ac[1]>191.25);
    temp.sc = {temp.c, temp.c, temp.ac[2]};
  } 
  return {temp.ac, temp.sc};
  //Alignment Color, Shadow Color
} 

public function getAlignmentColor(temp.ap) {
  return this.apv[temp.ap];
} 


I guess this would be exchanging some memory and an increased amount of weapon data sent to the client for a save on script time. This turned out to be significantly faster than what we were previously using if the class is joined within the script using it. It is also still slightly faster than our previous method if used as a public function.

[Mark Sir Link]

does shared.getAlignmentShadowColor(r, g, b) even work? What are the expected values? A float 0-1 or an int 0-255?

I have tried

PHP Code:

temp.c = shared.getAlignmentColor(player.ap);
temp.cs = shared.getAlignmentShadowColor(c[0], c[1], c[2]);

temp.c = shared.getAlignmentColor(player.ap);
temp.cs = shared.getAlignmentShadowColor(c[0]/255, c[1]/255, c[2]/255);

temp.cs = shared.getAlignmentShadowColor(player.ap); 


and all are returning an array of {0, 0, 0}

The few times I've gotten it to return something besides that (by first methodology), it returns something entirely wrong, like {0, 0, 255} should the player's AP be 90 (which appears to be a white outline, while the returned is just blue)

seems as if both of these functions need work, I'm not sure why different params are passed to one versus the other anyway

[Crow]

What's wrong with rgbtohex()? shared.rgbtohex(1, 0, 0) returns #0F0000 for me; should be #FF0000 instead. Also, how come rgbtohex() and hextorgb() seem to return more than they should using v6? I always get stuff like "#0F0000 1 0 1" as a return value.

[DrakilorP2P]

Originally Posted by Crow

What's wrong with rgbtohex()? shared.rgbtohex(1, 0, 0) returns #0F0000 for me; should be #FF0000 instead. Also, how come rgbtohex() and hextorgb() seem to return more than they should using v6? I always get stuff like "#0F0000 1 0 1" as a return value.

rgbtohex() returns the wrong hex for me too.

[Crow]

Originally Posted by DrakilorP2P

rgbtohex() returns the wrong hex for me too.

Well, however it is written, it should probably just use format() instead:

PHP Code:

function RGBtoHex(red, green, blue)
  return format("#%.2x%.2x%.2x", red * 255, green * 255, blue * 255); 


[Skyld]

Originally Posted by Crow

What's wrong with rgbtohex()? shared.rgbtohex(1, 0, 0) returns #0F0000 for me; should be #FF0000 instead. Also, how come rgbtohex() and hextorgb() seem to return more than they should using v6? I always get stuff like "#0F0000 1 0 1" as a return value.

I'll investigate this afternoon.

Edit: should be fixed now.