Invisibility

[salesman]

Originally Posted by BlueMelon

Just a tip, your code lacks of comments.

I'd rather see clear code and functions/variables with appropriate names. Comments should only really be used when it might be unclear to another coder what you're trying to do.

I hate seeing stuff like this:

PHP Code:

// set hp to 100
this.hp = 100; 


Unless you're trying to explain an algorithm to someone who isn't familiar with the language, having too many comments is just annoying.

[callimuc]

You should use something like this:

Originally Posted by Twinny

This is what I did for Classic iPhone stealth (removed some other parts to provide this),

Weapon: -Staff/Stealth

PHP Code:

//#CLIENTSIDE
function onCreated() {
  player.attr[22] = "unstealth.gani";
}

function ChatBar.onAction() {
  if (ChatBar.text == "/stealth") {
    toggleStealth();
    ChatBar.text = "";
  }
}

function toggleStealth() {
  this.stealth = !this.stealth;
  if (this.stealth)
    player.attr[22] = "stealth.gani";
  else
    player.attr[22] = "unstealth.gani";
} 


in the gani,

PHP Code:

function onPlayerEnters() {
  if (clientr.isStaff)
    player.alpha = 0.4;
  else
    player.alpha = 0;
} 


So, all staff can see the stealthed person at half alpha while no-one else can see them.

also, something like this

Originally Posted by boolean

PHP Code:

function onPlayerChats()
{    
   if(player.chat.starts("/add"))
      triggerServer("gui", this.name, "add", NULL, player.chat.tokenize()[1]);
 
   if(player.chat.starts("/remove"))
      triggerServer("gui", this.name, "remove", NULL, player.chat.tokenize()[1]);
 
   if(player.chat == "/exceptions")
   {
      triggerServer("gui", this.name, "view");
      player.chat = "";
   }
 
   if(player.chat.starts("/add") || player.chat.starts("/remove"))
      player.chat = "";
} 


should be changed to something like this

PHP Code:

function onPlayerChats() {
  temp.toks = player.chat.tokenize();  
  if (player.chat.starts("/add")) {
    triggerServer("gui", this.name, "add", NULL, temp.toks[1]);
    player.chat = " ";
  }
 
  else if (player.chat.starts("/remove")) {
    triggerServer("gui", this.name, "remove", NULL, temp.toks[1]);
    player.chat = " ";
  }
  else if (player.chat == "/exceptions") {
    triggerServer("gui", this.name, "view");
    player.chat = " ";
  }
} 


styling your codes would also be something you should try out

[boolean]

Originally Posted by callimuc

styling your codes would also be something you should try out

lol

and yes it is changing the opacity for the players within the list of "exceptions"

PHP Code:

temp.pl.triggerClient("gui", this.helper, player.account, temp.exists ? temp.alpha : temp.alpha == 0 ? 0.5 : 1); 


Honestly, I think the onPlayerChats() event becomes so boilerplate at this point I could care less as to how I interact with it

[callimuc]

Originally Posted by boolean

lol

sorry, just realized it was the styling (with the brackets in a new line, etc.) which has been irritating me