shop script help once again

[GULTHEX]

PHP Code:

function onCreated()
{
  setshape 1,32,32;
}
function onActionbuy()
{
  if(playerrupees>=100)
  {
    addweapon Event/Headbob;
    playerrupees-=100;
  }
}
//#CLIENTSIDE
function onPlayerchats()
{
  if(player.chat=="buy Headbob")
  {
    triggeraction(x,y,"buy","buy");
    //the level npc triggeraction type
  }
} 


when i put this in a lvl npc and say buy Headbob nothing happens

how do i fix it???

[[email protected]]

Don't use that
Use this

function onPlayerChats() {
  if (player.chat != "buy headbob") return false;
  if (player.rupees < 100) return false;
  if (player.findWeapon("headbob") != false) return false;
  player.addWeapon("headbob");
  player.rupees -= 100;
}

[Kristi]

Originally Posted by [email protected]

Don't use that
Use this

function onPlayerChats() {
  if (player.chat != "buy headbob") return false;
  if (player.rupees < 100) return false;
  if (player.findWeapon("headbob") != false) return false;
  player.addWeapon("headbob");
  player.rupees -= 100;
}

Your code assumes his shopkeeper will only be selling that one item (which will most likely be false)

[[email protected]]

Originally Posted by Kristi

Your code assumes his shopkeeper will only be selling that one item (which will most likely be false)

you've not seen his server. it will, trust me

[Chompy]

Originally Posted by [email protected]

That doesn't make sense, we were helping him by teaching him a better method.

Wut?

Originally Posted by [email protected]

Don't use that
Use this

...

Very "teachy"

[Chompy]

Judging from what scripts he have provided and scripting questions asked, I can safetly say that he is new to gscript2.

[GULTHEX]

Nope im selling 3 items lolz
and i scripted them myself
*note they just play ganis well thats good for me *
IM LEARNING HOW TO SCRIPT YAY YAY YAY

[Frankie]

I was really bored so I made this. It supports multiple items sold. I stopped testing it once I got to the rupee and weapon check, but the command works fine.

Up for grabs, wasn't really making it specifically for Gulthex, I was just really bored and thought I would try it.

PHP Code:

function onPlayerChats()
{
  if (player.chat.starts("buy"))
  {
    this.saleItems = {
      {"headbob", 100, "Event/Headbob"},
      {"anotheritem", 250, "Event/Item"},
      {"dance item", 50, "Event/Dance"}
    };

    for (temp.i: this.saleItems)
    {
      if (player.chat.substring(4) == temp.i[0])
      {
        this.buyItem(temp.i[0], temp.i[1], temp.i[2]);
        break;
      }
    }
  }
}

function buyItem(itemName, itemPrice, itemWeapon)
{
  if (player.findWeapon(temp.itemWeapon) != false)
  {
    return;
  }
  if (player.rupees < temp.itemPrice)
  {
    player.chat = "You don't have enough money!";
    return;
  }
  
  player.rupees -= temp.itemPrice;
  player.addWeapon(temp.itemWeapon;
  
  player.chat = "You have bought" SPC temp.itemName SPC "for" SPC temp.itemPrice SPC "dollars!";
} 


[Inverness]

Why are you tokenizing the array in buyItem()?

Also, since findweapon() is returning an object methinks you should compare it to null not false so its clear that it is not boolean.

[Frankie]

not sure. i'll change it

I also took the findweapon part from andy's script because I've never really done anything like that before :P

[[email protected]]

nice method at Frankie, would have made it a temp. flag and parsed the array as an array, not individual, but other than that it's cool

[Inverness]

PHP Code:

function onCreated() {
  this.saleitems = {
    {"headbob", 100, "Event/Headbob"},
    {"anotheritem", 250, "Event/Item"},
    {"dance item", 50, "Event/Dance"}
  };
}
function onPlayerChats() {
  if (player.chat.starts("buy ")) {
    for (temp.i: this.saleitems) {
      if (player.chat.substring(4) == temp.i[0]) {
        this.buyitem(temp.i.link());
        break;
      }
    }
  }
}
function buyitem(item) {
  if (player.findweapon(temp.item[2]) != null) {
    return false;
  }
  if (player.rupees < temp.item[1]) {
    player.chat = "You don't have enough money!";
    return false;
  }
  player.rupees -= temp.item[1];
  player.addweapon(temp.item[2]);
  player.chat = format("You have bought <percentsign>s for $<percentsign>s", temp.item[0], temp.item[1]);
  return true;
} 


You would replace <percentsign> with an actual percent sign because the stupid forum has issues when you try to put it in a post.

[Tigairius]

Why are you giving him a bunch of confusing methods, the kid's trying to learn how to script, not asking the best way to script his system.
Try this, Gulthex:

PHP Code:

triggeraction(x + 0.5, y + 0.5, "buy", null); 


Also, here you are mixing GS1 with GS2 again... do this:

PHP Code:

function onCreated() { 
  setshape(1, 32, 32); 
} 

function onActionbuy() { 
  if (player.rupees >= 100) { 
    addweapon("Event/Headbob"); 
    player.rupees -= 100; 
  } 
} 


[[email protected]]

Originally Posted by Tigairius

Why are you giving him a bunch of confusing methods, the kid's trying to learn how to script, not asking the best way to script his system.

That doesn't make sense, we were helping him by teaching him a better method.

[Inverness]

Originally Posted by [email protected]

That doesn't make sense, we were helping him by teaching him a better method.

He needs to understand the basics first.