Drag and Drop

[LoneAngelIbesu]

For Valikorlia's trading GUI, I'm wanting to implement dragging and dropping. So far, I've gotten dragging down. However, I can't seem to figure out dropping. The "3" is arbitrary; I just copied another NAT's method (which obviously isn't working in this case ).

This is how I'm doing it. First, we have onRecordSelection(obj), which is just obj.onSelect(). This triggers onDragIcon(obj). (I do it this way to prevent a different icon from being selected when dragging the mouse over it.) From there, a GuiShowImgCtrl is created, which is the floating icon that the user's dragging around. The problem I'm having is detecting when the mouse is over TradeOfferScroll.

PHP Code:

function onDragIcon(obj) {
  if(this.dragging) {
    return;
  }
  new GuiShowImgCtrl("TradeInventoryFloater") {
    this.width = 32;
    this.height = 32;
    System.parseimage(this, staticdata.tradeitems[(@ obj).itemid].icon);
    this.x = mousescreenx;
    this.y = mousescreeny;
  }
  setTimer(0.05);
} 


PHP Code:

function onTimeout() {
  if(leftmousebuttonglobal) {
    with(TradeInventoryFloater) {
      this.x = mousescreenx;
      this.y = mousescreeny;
    }
    this.dragging = true;
    setTimer(0.05);
  }
  else {
    if(mousescreenx in  |TradeOfferScroll.x, TradeOfferScroll.x + 3|) {
      if(mousescreeny in |TradeOfferScroll.y, TradeOfferScroll.y + 3|) {
        echo("Added to offer");
      }
    }
    else {
      echo("Destroyed");
    }
    this.dragging = false;
    System.destroyobject("TradeInventoryFloater");
    setTimer(0);
  }
} 


Another NAT on Valikorlia suggested using showimg() instead of a GuiShowImgCtrl. Is there any benefit with doing this, as opposed to using a GUI control?

[_Z3phyr_]

i only see this code breaking down on the else block after the leftmousebuttonglobal bit and/or the in || requirements inside that else block.

my experience tells me that your tradeofferscroll.x/y are not equal to what you think they are.

[cbk1994]

mousescreenx/y are relevant to the screen. Your scroll is relevant to the control it is in.

The scroll might have an x of 10, but it's really at 450 x on the screen.

Try using control.globaltolocalcoord( { x, y } )

I'm assuming that the scroll actually is in a control (besides GraalControl), however.

[LoneAngelIbesu]

Thank you, Chris. That worked.

PHP Code:

function onTimeout() {
  if(leftmousebuttonglobal) {
    with(TradeInventoryFloater) {
      this.x = mousescreenx;
      this.y = mousescreeny;
    }
    this.dragging = true;
    setTimer(0.05);
  }
  else {
    temp.target = TradeOfferScroll.globaltolocalcoord({mousescreenx,mousescreeny});
    if(temp.target[0] in  |0, 138|) { //TradeOfferScroll.width
      if(temp.target[1] in |0, 260|) { //TradeOfferScroll.height
        echo("Added to offer");
      }
    }
    else {
      echo("Destroyed");
    }
    this.dragging = false;
    System.destroyobject("TradeInventoryFloater");
    setTimer(0);
  }
} 


[DustyPorViva]

For note, showimgs can not be shown over GUI's, so there's a problem with that method, for future reference.

[cbk1994]

Originally Posted by DustyPorViva

For note, showimgs can not be shown over GUI's, so there's a problem with that method, for future reference.

GuiShowImgCtrl's can.

[DustyPorViva]

Originally Posted by cbk1994

GuiShowImgCtrl's can.

Yes they can, but they're treated like GUI's, which result in having the same problems GUI's have with catching mouse info and all.

[LoneAngelIbesu]

Originally Posted by LoneAngelIbesu

Another NAT on Valikorlia suggested using showimg() instead of a GuiShowImgCtrl. Is there any benefit with doing this, as opposed to using a GUI control?

Dusty was addressing this. Thanks for the info, though, Dusty.

[[email protected]]

hmm generally i'd use a while button in this case

while (mousebuttons > 0) { //Mouse down
  Showimg[data]
}
if (mousex in |player.x - 5, player.x + 5| && mousey in |player.y - 5, player.y + 5|) {
  //drop the item
}

no need for a timeout, personal preference i suppose

[DustyPorViva]

Originally Posted by [email protected]

hmm generally i'd use a while button in this case

while (mousebuttons > 0) { //Mouse down
  Showimg[data]
}
if (mousex in |player.x - 5, player.x + 5| && mousey in |player.y - 5, player.y + 5|) {
  //drop the item
}

no need for a timeout, personal preference i suppose

A loop is a loop, whether it's a timeout or while, right?

[cbk1994]

Originally Posted by [email protected]

hmm generally i'd use a while button in this case

while (mousebuttons > 0) { //Mouse down
  Showimg[data]
}
if (mousex in |player.x - 5, player.x + 5| && mousey in |player.y - 5, player.y + 5|) {
  //drop the item
}

no need for a timeout, personal preference i suppose

You could eventually hit a loop limit; also, it would stop any other functions in that script.

[[email protected]]

add a sleep to avoid the loop limit, you wouldn't need to do any other functions in the script whilst moving an object.

[xXziroXx]

Originally Posted by [email protected]

add a sleep to avoid the loop limit, you wouldn't need to do any other functions in the script whilst moving an object.

Sleeps are evil.

[cbk1994]

Originally Posted by xXziroXx

Sleeps are evil.

I agree, they kill timeouts

[LoneAngelIbesu]

I'll stick with a timeout.