shooting part of rc helicopter wont work

[callimuc]

hey guys. i made a rc helicopter and it works just like i want it. now i added a shooting part but it hurts only a few people not everyone (i think just the people who have it). here is the part i think where the problem could be:

PHP Code:

     if(key = "d"){
      setshootparams("callihelimissle", player.account);
      shoot(this.plane_x + vecx(this.plane_dir), this.plane_y + vecy(this.plane_dir), playerz, (this.plane_dir+1) * pi / 2 + random( 0,0), NULL, NULL, "callihelimissle", 2);
     }
     function onActionProjectile()
      {
        player.hearts-=0.5;
        setAni("hurt",NULL);
    } 


could anyone help me or tell me what i should fix?

[cbk1994]

You need to move the onActionProjectile stuff to a system weapon which every player has.

Also, use == for comparison, = is for assigning.

PHP Code:

if(key = "d"){ 


needs to be

PHP Code:

if(key == "d"){ 


You should also use player.z instead of playerz, although either works.

[callimuc]

so you mean i should just add a new weapon for the callihelimissle?

if yes do i have to change anything in the script than or is it ok than

[cbk1994]

Originally Posted by callimuc

so you mean i should just add a new weapon for the callihelimissle?

if yes do i have to change anything in the script than or is it ok than

You should probably just have a weapon named "-Projectiles" or so that deals with all projectiles. All players need to have this weapon.

PHP Code:

//#CLIENTSIDE
function onActionProjectile(projType) {
  switch (projType) {
    case "callihelimissile":
      player.hearts-=0.5; 
      setAni("hurt",NULL); 
    break;
  }
} 


Once you've done that you just need to remove the onActionProjectile stuff from the helicopter script and fix the == thing I pointed out.

[callimuc]

ok i´ve fixed the == and made a projectile weapon for all weapons. but what you mean with remove that one part? could you give an example what you mean?

[cbk1994]

PHP Code:

     if(key = "d"){ 
      setshootparams("callihelimissle", player.account); 
      shoot(this.plane_x + vecx(this.plane_dir), this.plane_y + vecy(this.plane_dir), playerz, (this.plane_dir+1) * pi / 2 + random( 0,0), NULL, NULL, "callihelimissle", 2); 
     } 
     function onActionProjectile() 
      { 
        player.hearts-=0.5; 
        setAni("hurt",NULL); 
    } 


becomes

PHP Code:

     if(key == "d"){ 
      setshootparams("callihelimissle", player.account); 
      shoot(this.plane_x + vecx(this.plane_dir), this.plane_y + vecy(this.plane_dir), player.z, (this.plane_dir+1) * pi / 2 + random( 0,0), NULL, NULL, "callihelimissle", 2); 
     } 


You should learn to script rather than just taking other peoples' code without understanding it.

[callimuc]

ok thank you for it and i´m learning to script xP