My Scripting Problem.

[[email protected]]

Hello, I am working on a Shop Safe Script and it functions perfectly, but when you update the level or edit it with graal editor, it resets automatically to 0. I Need some help on this please for all you excellent scripters out there.

Here is the script.

//Scripted By Jamerson61894!
if (created) {
}
if (playertouchsme) {
}
if (playerchats && strcontains(#c,/deposit)){
tokenize #c;
this.rupeeadd = strtofloat(#t(1));
if (playerrupees >= this.rupeeadd){
if (this.rupeeadd > 0){
playerrupees -= this.rupeeadd;
this.safemoney += this.rupeeadd;
setcharprop #c,#v(this.safemoney) dollars in safe!;
}
}
}

if (playerchats && strcontains(#c,/withdraw)){
tokenize #c;
this.takemoney = strtofloat(#t(1));
if (this.safemoney >= this.takemoney){
if (this.takemoney > 0){
if (strequals(#a,GULTHEX)){

playerrupees += this.takemoney;
this.safemoney -= this.takemoney;
setplayerprop #c, Took #v(this.takemoney) dollars out of safe!;
setcharprop #c, #v(this.safemoney) dollars in safe!
}
}
}
}
if (playerchats && strcontains(#c,/balance)){
tokenize #c;
setcharprop #c, #v(this.safemoney) dollars in safe!
}
if (timeout){
setcharprop #c, ;}



If you could help me fix the problem with the update level part, I would be most greatful.

Thanks,

-Jamerson61894

[Codein]

Originally Posted by [email protected]

stuff
-Jamerson61894

You have to use a DB NPC for it save. Basically, using NC, create NPC in the same position where this script is, and copy and paste the script inside it. Then delete level NPC.

I don't really like how you've combined events and flags. I think that's a bit of a taboo and shouldn't be done. Do this:

if (playerchats) {
	tokenize #c;
	
	if (strcontains(#c,/withdraw)) {
		this.takemoney = strtofloat(#t(1));
		if (this.safemoney >= this.takemoney){
			if (this.takemoney > 0){
				if (strequals(#a,GULTHEX)){
					playerrupees += this.takemoney;
					this.safemoney -= this.takemoney;
					setplayerprop #c, Took #v(this.takemoney) dollars out of safe!;
					setcharprop #c, #v(this.safemoney) dollars in safe!
	            }
			}
		}
	}
	
	elseif (strcontains(#c, /deposit)) {
		this.rupeeadd = strtofloat(#t(1));
		if (playerrupees >= this.rupeeadd){
			if (this.rupeeadd > 0){
				playerrupees -= this.rupeeadd;
				this.safemoney += this.rupeeadd;
				setcharprop #c,#v(this.safemoney) dollars in safe!;
			}
		}
	}
	
	elseif (strcontains(#c, /balance)) {
		setcharprop #c, #v(this.safemoney) dollars in safe!
	}
}

if (timeout){
  setcharprop #c, ;
}

Also, try learning GS2

[xXziroXx]

Originally Posted by [email protected]

Hello, I am working on a Shop Safe Script and it functions perfectly, but when you update the level or edit it with graal editor, it resets automatically to 0.

As Codein said, store the data in Database NPC's or serverr. flags, the first being recommended. And you can't save data in the Graal Editor.

[[email protected]]

So this should fix the problem?

[[email protected]]

Could I use a class and join the script?

Example

join safe;

[Codein]

Originally Posted by [email protected]

Could I use a class and join the script?

Example

join safe;

To a DB NPC, yeah.

[Pelikano]

You could also just use putnpc2 and then your this.vars won't reset anymore.

[xXziroXx]

Originally Posted by Pelikano

You could also just use putnpc2 and then your this.vars won't reset anymore.

What a great idea!

Originally Posted by Newly Hired NAT

/clearnpcs levelname.nw

Oops, I just deleted all NPC's in that level.

[Tigairius]

Originally Posted by xXziroXx

What a great idea!

Meh, give the man props for originality.