Curiosity...

[Kristi]

Am I the only person that avoids using "with" as much as possible?

Whenever I create an object of any sort, I assign it a pointer. If the object is already created, I give it a pointer.

ex: temp.ani = showani(...);
temp.ani.prop = value;

When I have long lists of things, it seems easier to just glance at my code and see exactly what is going on, instead of tracing back with blocks.

What do you do and why? Discuss!

[Crono]

I never use with.

[Stryke]

I use with only with findimgs

[DrakilorP2P]

thiso. eww.

[DustyPorViva]

It depends on how many values of the object I am changing.

[Chompy]

Originally Posted by DustyPorViva

It depends on how many values of the object I am changing.

Same here

[cbk1994]

Originally Posted by Chompy

Same here

Agreed.

[Crow]

Originally Posted by cbk1994

Agreed.

Seconded.

[LoneAngelIbesu]

Originally Posted by DustyPorViva

It depends on how many values of the object I am changing.

Yup, same here. As a rule of thumb, if I'm changing three or more values, I use with.

I mean, really... which one looks better? It may be more lines, but I guess I'm a block kind of guy.

PHP Code:

function TheParentObject.onMove(newx, newy) {
  TheObject.x = newx + TheParentObject.width + 10;
  TheObject.y = newy;
  TheObject.text = "Has been moved with parent object";
}
function TheParentObject.onMove(newx, newy) {
  with(TheObject) {
    this.x = newx + TheParentObject.width + 10;
    this.y = newy;
    this.text = "Has been moved with parent object";
  }
} 


[Kristi]

The top one looks better, and would look even better if you lined up your equal signs *tsktsk*

[Crow]

Originally Posted by Kristi

The top one looks better, and would look even better if you lined up your equal signs *tsktsk*

Lining up equal signs doesn't look cool if you ask me. I agree that the top one looks better in that case though. I only use with when I have to change more than 4 or 5 things.

[LoneAngelIbesu]

Originally Posted by Kristi

The top one looks better, and would look even better if you lined up your equal signs *tsktsk*

I'm too lazy to press my space bar that many times. Another thing that I like about using with() is when there are really long object names. I try as hard as possible not make the horizontal scrollbar appear... but, I do that with everything.

[Crow]

Originally Posted by LoneAngelIbesu

I'm too lazy to press my space bar that many times. Another thing that I like about using with() is when there are really long object names. I try as hard as possible not make the horizontal scrollbar appear... but, I do that with everything.

Tab key adds 2 spaces, and I don't think long object names are an excuse. You could just do something like this:

PHP Code:

temp.obj = PrettyDamnLongObjectNameHere;
temp.obj.doStuff(); 


[Dan]

For me it kind of depends on the length of the object name, I found out (but never thought about).

Example;

PHP Code:

temp.object = putnpc2(params[1][0],params[1][1],"");
temp.object.image = params[2][0];
if (params[2][1] == "")
  return;
temp.object.join(params[2][1]); 


or;

PHP Code:

with (@ genGUIName("Window_Scroll_EditMission_Scroll_List")) {
  clearRows();
  for (temp.i = 1; temp.i <= mission.missionslist.size(); temp.i ++)
    addRow(- 1,"Mission " @ temp.i);
} 


[Tigairius]

I use with() just about as much as I assign a pointer. Some functions on GK don't even work properly unless you use with(), and as many other people said it depends how many values I'm editing at once.

[cbk1994]

Originally Posted by Tigairius

Some functions on GK don't even work properly unless you use with()

GK's functions.

[xXziroXx]

Originally Posted by Tigairius

it depends how many values I'm editing at once.

Agreed.

[Inverness]

Using with() on serverside is how you change the calling player.

[Admins]

It can reduce problems with typing errors (typing the same object name over and over again), it can also make scripts look easier to understand. If you need to write very efficient code then it should probably be avoided (e.g. loops inside with() are not optimized), but that should not happen often.
Making scripts look easier to understand is often more important than you think, because code often needs to be understood by other scripters to be able to fix or improve stuff (or by yourself in the future).

[Cloven]

Originally Posted by Stefan

It can reduce problems with typing errors (typing the same object name over and over again), it can also make scripts look easier to understand. If you need to write very efficient code then it should probably be avoided (e.g. loops inside with() are not optimized), but that should not happen often.
Making scripts look easier to understand is often more important than you think, because code often needs to be understood by other scripters to be able to fix or improve stuff (or by yourself in the future).

In my opinion, the first (and possibly best thing) people can do in general is use practical, logical names for their variables and/or functions as they apply to the npc they're being used in. This makes it 10x easier on any future scripter who may have to edit/debug your work if they can relate easily to the code in front of them.

[zokemon]

I use with when creating objects (like GUIs) to make it match with the new blocks.

Originally Posted by Kristi

Preference or not, it is what is generally taught as standard coding practices in computer science.

Not a single CIS class I've taken has taught such a practice, though it does make sense.

[Kristi]

Originally Posted by zokemon

i use with when creating objects (like guis) to make it match with the new blocks.



Not a single cis class i've taken has taught such a practice, though it does make sense.

cis <> cs

[Loriel]

Originally Posted by Kristi

cis <> cs

I am watching CSI: Miami every week and have yet to see them line up any equal signs.

[Inverness]

Originally Posted by Loriel

I am watching CSI: Miami every week and have yet to see them line up any equal signs.

I tried to find the humor in that but I just couldn't do it.

[Loriel]

Originally Posted by Inverness

I tried to find the humor in that but I just couldn't do it.

I tried to find the humor in your mom but I just could not do that either

[zokemon]

Originally Posted by Kristi

cis <> cs

CIS = Computer Information Sciences

It just means the department also include more then just programming classes. I was however, referring to the programming classes that I've taken.

[Kristi]

Originally Posted by zokemon

CIS = Computer Information Sciences

It just means the department also include more then just programming classes. I was however, referring to the programming classes that I've taken.

CIS = Computer Information Systems....

[Crow]

Originally Posted by Kristi

CIS = Computer Information Systems....

CIS = Cancer Information Service!

[zokemon]

Originally Posted by Kristi

CIS = Computer Information Systems....

You go to a different school.

[Mark Sir Link]

I've yet to be taught to line up equal signs after Computer Science, AP Computer Science AB, and Computer Systems, but perhaps year 4 will be my lucky year!

[Kappa00p2p]

Computer Systems Engineer ftw

[Googi]

Seeing someone going out of their way to line up equal signs or any other operator unless they're assigning some huge number of variables/array indices/etc always strikes me of showoffish. Even if there is a huge number of assignments I still don't like it. It might make the code marginally more readable, but it makes it a pain to edit.

[cbk1994]

Originally Posted by Googi

Seeing someone going out of their way to line up equal signs or any other operator unless they're assigning some huge number of variables/array indices/etc always strikes me of showoffish. Even if there is a huge number of assignments I still don't like it. It might make the code marginally more readable, but it makes it a pain to edit.

The problem with code readability is that people don't agree what is readable.

PHP Code:

function foo( bar )
{
  doSomething( pi );
} 


is perfectly readable for myself and Jave (who also scripts on Vesporia, albeit lightly). However, most think that's hard to read

[xXziroXx]

Originally Posted by cbk1994

The problem with code readability is that people don't agree what is readable.

PHP Code:

function foo( bar )
{
  doSomething( pi );
} 


is perfectly readable for myself and Jave (who also scripts on Vesporia, albeit lightly). However, most think that's hard to read

The only occasion I add ugly spaces like that, is if I have an array within two (), such as:

PHP Code:

randomFunction( { "Foo", "Bar", "Baz" } ); 


EDIT: Actually, when I scan through my scripts, I haven't done that for a looooong time. It seems I do like this:

PHP Code:

randomFunction({ "Foo", "Bar", "Baz" }); 


[cbk1994]

Originally Posted by xXziroXx

The only occasion I add ugly spaces like that, is if I have an array within two (), such as:

PHP Code:

randomFunction( { "Foo", "Bar", "Baz" } ); 


EDIT: Actually, when I scan through my scripts, I haven't done that for a looooong time. It seems I do like this:

PHP Code:

randomFunction({ "Foo", "Bar", "Baz" }); 


PHP Code:

temp.foo = {
                  "Foo", // Probably wouldn't do this for a short list like this, mainly for multi-dimensional arrays.
                  "Bar",
                  "Baz"
                };
randomFunction( foo ); 


Sorry, can't open RC right now (or anything with a fixed-width font), so they aren't aligned.

[Inverness]

Originally Posted by cbk1994

is perfectly readable for myself and Jave (who also scripts on Vesporia, albeit lightly). However, most think that's hard to read

That hurts my eyes.

[cbk1994]

Originally Posted by Inverness

That hurts my eyes.

Yeah, like I said, most people don't like it.