Confirmation box troubles

[BlueMelon]

function WarpAIS_Button.onAction(){

confirm("WarptoAIS");
if(this.flag ==1){
this.chat = "test";
}else if (this.flag == 0)
{
this.chat = "no";
}
}



function confirm(action){
this.flag = 0;
	new GuiWindowCtrl("ConfirmationBox"){
		profile = "GuiBlueWindowProfile";
		width = 131;
		height = 110;
		x = player.x;
		y = player.y;
		text = "Confirmation";
		canMaximize=false;
		canMinimize=false;
		destroyonhide=true;
		canresize = false;

	new GuiTextCtrl("AlertConfirm_l") {
	  profile = GuiBlueTextProfile;
	  x = 11;
	  y = 27;
	  height = 15;
	  width = 130;
	  text = "Proceed with:";
	}

	new GuiTextCtrl("AlertConfirm_l_action") {
	  profile = GuiBlueTextProfile;
	  x = 30;
	  y = 42;
	  height = 15;
	  width = 130;
	  text = action;
	}

	new GuiButtonCtrl("cYes_Button") {
	   profile = GuiBlueButtonProfile;
	   x = 11;
	   y = 67;
	   width = 50;
	   height = 30;
	   text = "Yes";
	 }

	new GuiButtonCtrl("cNo_Button") {
	   profile = GuiBlueButtonProfile;
	   x = 71;
	   y = 67;
	   width = 50;
	   height = 30;
	   text = "No";
	 }

	}
}

function cYes_Button.onAction()
{
ConfirmationBox.destroy();
this.flag = 1;
}
function cNo_Button.onAction()
{
ConfirmationBox.destroy();
this.flag = 0;
}

Here is a snippet of a script I created. The problem is, when I click the WarptoAIS button, yes the confirmation box does popup, but the value that the WarpAIS_Button.onAction() is always false because when the confirm box is created.. How can I make a function to confirm an action before performing it?

in short...
Action --> Confirm --> If true, do action

[callimuc]

You should style the code first. Can often help to find errors.

Now what you could do is (as far as I understood it correctly):

PHP Code:

function ButtonBeenPressed.onAction() {
  DoEvent();
  //For example: you pressed the confirmation button (you need to change the name on this event for that
}

function DoEvent() {
  player.chat = "Hell jea I just pressed that wonderful button.";
  //here you can do your stuff, you want the player to do after confirming
} 


[fowlplay4]

It is of utter importance that you style your code before posting it. If you don't know how please learn and use my GS2 Style in the mean time: http://fp4.ca/gs2beautifier

Sounds like you want to create a 'confirm' dialog window. You need to use waitfor to accomplish that. I explain in my guide below:

http://forums.graalonline.com/forums...hp?t=134261899

[BlueMelon]

Originally Posted by fowlplay4

It is of utter importance that you style your code before posting it. If you don't know how please learn and use my GS2 Style in the mean time: http://fp4.ca/gs2beautifier

Sounds like you want to create a 'confirm' dialog window. You need to use waitfor to accomplish that. I explain in my guide below:

http://forums.graalonline.com/forums...hp?t=134261899

Perfect. Problem solved, thanks.

[BlueMelon]

Actually, no problem not solved yet...

PHP Code:

function WarptoAIS_Button.onAction() {
    if (confirm("Warp to AIS")) {
        this.chat = "Works?";
    }
}

function confirm(action) {
    new GuiWindowCtrl("ConfirmationBox") {
        profile = "GuiBlueWindowProfile";
        width = 131;
        height = 110;
        x = player.x;
        y = player.y;
        text = "Confirmation";
        canMaximize = false;
        canMinimize = false;
        destroyonhide = true;
        canresize = false;
        this.returnvalue = false;
        new GuiTextCtrl("AlertConfirm_l") {
            profile = GuiBlueTextProfile;
            x = 11;
            y = 27;
            height = 15;
            width = 130;
            text = "Proceed with:";
        }
        new GuiTextCtrl("AlertConfirm_l_action") {
            profile = GuiBlueTextProfile;
            x = 30;
            y = 42;
            height = 15;
            width = 130;
            text = action;
        }
        new GuiButtonCtrl("cYes_Button") {
            profile = GuiBlueButtonProfile;
            x = 11;
            y = 67;
            width = 50;
            height = 30;
            text = "Yes";
            thiso.catchevent(this.name, "onAction", "onReplied");
        }
        new GuiButtonCtrl("cNo_Button") {
            profile = GuiBlueButtonProfile;
            x = 71;
            y = 67;
            width = 50;
            height = 30;
            text = "No";
            thiso.catchevent(this.name, "onAction", "onReplied");
        }
    }
    waitfor(this, "AnsweredDialog", 3600);
    return ConfirmationBox.returnvalue;
}

function onReplied(obj) {
    ConfirmationBox.returnvalue = (obj.text == "Yes" ? true : false);
    ConfirmationBox.hide();
    this.trigger("AnsweredDialog", "");
} 


The confirmation box does popup and it does hide when I click yes or no, but it wont return a value, If I take off the hide() then it does return the value...

[fowlplay4]

Originally Posted by BlueMelon

The confirmation box does popup and it does hide when I click yes or no, but it wont return a value, If I take off the hide() then it does return the value...

It's been said twice before but please do a better job of styling your code.

Try setting visible to false instead of using hide().

If that doesn't work you can get around that by removing the hide() code in the onReplied event and doing this instead:

PHP Code:

// other code
    waitfor(this,"AnsweredDialog",3600);
    temp.value = ConfirmationBox.returnvalue;
    ConfirmationBox.hide();
    return temp.value;
// other code 


[BlueMelon]

Originally Posted by fowlplay4

It's been said twice before but please do a better job of styling your code.

Try setting visible to false instead of using hide().

If that doesn't work you can get around that by removing the hide() code in the onReplied event and doing this instead:

PHP Code:

// other code
    waitfor(this,"AnsweredDialog",3600);
    temp.value = ConfirmationBox.returnvalue;
    ConfirmationBox.hide();
    return temp.value;
// other code 


My code is styled? I style it like I do in C++... standardized style.
(Except for the last function in my latest post)

[Tolnaftate2004]

Originally Posted by BlueMelon

My code is styled? I style it like I do in C++... standardized style.

I see a clusterfudge of 1TBS and Allman styles.

We use 1TBS, 2 (hard) space tabstop or you will be eaten alive.

Also, there is no standard style for C++ and I am not gonna open that bucket of worms. But 1TBS 4 lyfe.

[BlueMelon]

Originally Posted by Tolnaftate2004

I see a clusterfudge of 1TBS and Allman styles.

We use 1TBS, 2 (hard) space tabstop or you will be eaten alive.

Also, there is no standard style for C++ and I am not gonna open that bucket of worms. But 1TBS 4 lyfe.

x=1;
and
x = 1;

Same thing. And if anyone really gets confused by that... I don't even know what to say.

[Tolnaftate2004]

Originally Posted by BlueMelon

x=1;
and
x = 1;

Same thing. And if anyone really gets confused by that... I don't even know what to say.

That is not even close to what we're talking about.

[BlueMelon]

Originally Posted by Tolnaftate2004

That is not even close to what we're talking about.

Then I have no clue what your saying.

If you can't read my script (not the first post the latest post, cause first post is C&P error)
I would reconsider your ability in programming.

[Tolnaftate2004]

Originally Posted by BlueMelon

not the first post the latest post, cause first post is C&P error

Ah....

[iBeatz]

Originally Posted by BlueMelon

Then I have no clue what your saying.

If you can't read my script (not the first post the latest post, cause first post is C&P error)
I would reconsider your ability in programming.

That's not obnoxious at all...
I think you'd be better just listening to the advice given to you by people who know what they're talking about.

[Emera]

Styling helps with the debug process and makes the code look neat and readable overall. I didn't style my code, but I started having issues reading long lines of code and I often got confused. Now, I do it automatically. It doesn't take long to get to grips with it and it makes it more readable to people trying to help you (like on this occasion)

If you really want the help, then you should really follow advice from more experienced coders. Take fowlplay for instance. He's been coding for a very long time now. If he says that styling your code will help, then it probably will help. I had issues reading that thing.

[BlueMelon]

Originally Posted by iBeatz

That's not obnoxious at all...
I think you'd be better just listening to the advice given to you by people who know what they're talking about.

Yea it was a little rude, but when people comment on my programming I get iffy.

I've programming in C++ and python for over 3 years, I know what I'm talking about.

I am also well capable of "styling" my code and finding errors on my own its just that there is no GScript doc excepting Graal Bible and Wiki, but even those don't have every single function you can use.

I appreciate the help I got, no further replys should be made.

Originally Posted by Emera

Styling helps with the debug process and makes the code look neat and readable overall. I didn't style my code, but I started having issues reading long lines of code and I often got confused. Now, I do it automatically. It doesn't take long to get to grips with it and it makes it more readable to people trying to help you (like on this occasion)

If you really want the help, then you should really follow advice from more experienced coders. Take fowlplay for instance. He's been coding for a very long time now. If he says that styling your code will help, then it probably will help. I had issues reading that thing.

That is because you didn't take the time to scroll down and read that it was a copy/paste error with the [html] tags, I don't actually code like that >.>