New NPCServer Bug: return in switch statements

[cbk1994]

This started happening after Era was restarted earlier today.

PHP Code:

function onCreated() {
  temp.key = "abc";
  
  switch (temp.key) {
    case "foo":
      echo("key=foo");
      return; // this line is problematic
    break;
    
    case "abc":
      echo("key=abc");
    break;
  }
} 


If you run the following code, nothing will echo. If you comment out the return statement, then it will echo "key=abc" as expected.

It appears that a return statement in a switch causes everything below it to be ignored, even if that case shouldn't have been executed. This is new functionality which is breaking a few things on Era. It did not happen before the server restart today.

This bug also appears to exist clientside on both v5 and v6.

[fowlplay4]

Zodiac's (npcserver) is ****ed and won't even start up without crashing now.

[Admins]

Zodiac: needed to restart the gserver.
Switch statement: seems to be an optimization bug, if you correctly put case "123": { blabla } then it will not happen, didn't had any problem on era and classic iphone will fix it today though

[fowlplay4]

This bug pretty much broke everything on Zodiac.

[cbk1994]

Originally Posted by Stefan

if you correctly put case "123": { blabla } then it will not happen

Why is this the "correct" syntax? C++/C#/Java/Groovy/PHP/JavaScript all prefer to do it without braces, and they're misleading to new scripters (and reduce readability for all scripters) because they give you the false impression that execution stops at the end of the braces, which may not be true if you're falling through.

[Admins]

Ok fixed the problem and uploaded a new npcserver, may be should restart all servers sometime soon.

[cbk1994]

Originally Posted by Stefan

Ok fixed the problem and uploaded a new npcserver, may be should restart all servers sometime soon.

Our NPC-server is crashing every 20 minutes or so since the new NPCserver.

edit: era is offline until you can fix this!
edit 2: restarting the gserver seems to have fixed it...for now...

[fowlplay4]

Having issues with the NPC-Server again, whenever we update:

levels/icons/icons.txt

It causes the NPC-Server to crash. I've also caused it to crash by uploading a large text file and deleting it. Attached it.

[Admins]

Is it possible that some script is catching the onLevelFileUpdated event and then doing nasty things? I can check the problem sometime soon.

[fowlplay4]

Originally Posted by Stefan

Is it possible that some script is catching the onLevelFileUpdated event and then doing nasty things? I can check the problem sometime soon.

I placed echos in the onLevelFileUpdated functions and they don't even appear. It seems like right after the file is saved or deleted it crashes the (npcserver).

[Admins]

Ok the problem was not the file size, it was the problem that there were at least 3 versions of the same file (same filename) on the server. I'm fixing it in this moment.

Update: fixed on Zodiac and uploaded a new version.

[fowlplay4]

NPC is crashing every 30 minutes to an hour again, getting very tired of backups slowing down the playerworlds servers and the lack of stability as of late.

[Admins]

It shows in the logs that it got disconnected, and didn't crash. I will try to debug the npcserver tomorrow.

[ffcmike]

Originally Posted by fowlplay4

Zodiac's (npcserver) is ****ed and won't even start up without crashing now.

Same now for Classic. (presumably might happen for other servers whenever they restart their NPC-Server)

[Admins]

Restart your gserver. The new problem on Zodiac was related to a script adding tons of array members to a client. variable, might need to add limit of array length at least for client and clientr variables.