Bug: The max loop limit can no longer be avoided serverside with a sleep.

[cbk1994]

In the past, this code would not have hit the max loop limit because of the sleep.

PHP Code:

function onCreated() {
  for (temp.i = 0; temp.i < 100000; temp.i ++) {
    echo(temp.i);
    
    if ((temp.i + 1) % this.maxlooplimit == 0) {
      echo("sleeping");
      sleep(10);
    }
  }
} 


Now, the loop limit is hit on the next iteration after the sleep, regardless of the length of the sleep; the result is the same with a 0.1 second sleep and a 10 second one.

Originally Posted by RC Output

9996
9997
9998
9999
sleeping
Script: Loop limit exceeded at line 2 in script of TempLoopTest

This bug exists on at least Era Dev, Era, and Kingdoms Debug.

[ffcmike]

I encountered this problem on Classic too.

[scriptless]

I've never received a max loop error. Is that anything similar to how php breaks when it takes to long to execute a script? and times out?

or what exactly causes this problem? 1000 loops?

[cbk1994]

Originally Posted by scriptless

I've never received a max loop error. Is that anything similar to how php breaks when it takes to long to execute a script? and times out?

or what exactly causes this problem? 1000 loops?

10,000 by default. I don't know exactly how it works, Stefan's said it's more complicated than just loop counters, but basically a loop exceeding 10,000 iterations is halted and the entire script stops.

[xXziroXx]

Bump, also seems to happen clientside.

[Devil_Lord2]

Is this of the same problem?

I added more for loops because it use to be only this.tempStaff, and 20 strings in the array..

Then the original code only had this one else if for loop checking through the staff. :/

It would then say there was an error in the RC but the level editor still worked.. I didn't really know how to fix the problem but to split the work out into different else ifs...

It still doesn't work all that well but does work.
Sadly, I think the RC will state a lot of errors, but the people will not know...


Is there a way to fix this, or is it the same error as everyone else?
I tried to fix it, but I thought the problem was going through all the arrays..
It just says reached a loop limit at 0, 0.

Original (20 people / levels)

PHP Code:

this.tempStaff  = { //This will be deleted after the contest.
    "Graal774127","lat-01.nw", "Graal781370","lat-02.nw", "Graal779529","lat-03.nw", "acc","lat-04.nw", "acc","lat-05.nw",
  }; 



else if (player.account in this.tempStaff){
        for (i=0; i < this.tempStaff.size(); i++){
          if  (player.account == this.tempStaff[i] && player.level == this.tempStaff[i+1]){
            for (temp.i=0; temp.i < params[1].size(); temp.i ++){
              player.level.tiles[(temp.i%params[2])+params[3],int(temp.i/params[2])+params[4]] = params[1][temp.i];
              player.level.updateboard2(params[3],params[4],params[2],params[1].size()/params[2]);
            }
          }
        }  
      } 


Code now.

PHP Code:

  this.tempStaff  = { //This will be deleted after the contest.
    "Graal774127","lat-01.nw", "Graal781370","lat-02.nw", "Graal779529","lat-03.nw", "acc","lat-04.nw", "acc","lat-05.nw",
  };    
  this.tempStaff2  = { //This will be deleted after the contest.
    "acc","lat-06.nw", "acc","lat-07.nw", "acc","lat-08.nw", "acc","lat-09.nw", "acc","lat-10.nw",  
  };
  this.tempStaff3  = {
    "acc","lat-11.nw", "acc","lat-12.nw", "acc","lat-13.nw", "acc","lat-14.nw", "acc","lat-15.nw",
  };
  this.tempStaff4  = {  
    "acc","lat-16.nw", "acc","lat-17.nw", "acc","lat-18.nw", "acc","lat-19.nw", "acc","lat-20.nw", 
  };                  // Can only edit certain levels 
  
  
  switch (action) {
    case "SaveLevel":
      if (player.account in this.regStaff || player.account in this.trialStaff) {
        for (temp.i=0; temp.i < params[1].size(); temp.i ++)
          player.level.tiles[(temp.i%params[2])+params[3],int(temp.i/params[2])+params[4]] = params[1][temp.i];
          player.level.updateboard2(params[3],params[4],params[2],params[1].size()/params[2]);
      } 
      
      
      //Deleting this after the contest
      else if (player.account in this.tempStaff){
        for (i=0; i < this.tempStaff.size(); i++){
          if  (player.account == this.tempStaff[i] && player.level == this.tempStaff[i+1]){
            for (temp.i=0; temp.i < params[1].size(); temp.i ++){
              player.level.tiles[(temp.i%params[2])+params[3],int(temp.i/params[2])+params[4]] = params[1][temp.i];
              player.level.updateboard2(params[3],params[4],params[2],params[1].size()/params[2]);
            }
          }
        }  
      }
      else if (player.account in this.tempStaff2){
        for (i=0; i < this.tempStaff.size(); i++){
          if  (player.account == this.tempStaff2[i] && player.level == this.tempStaff2[i+1]){
            for (temp.i=0; temp.i < params[1].size(); temp.i ++){
              player.level.tiles[(temp.i%params[2])+params[3],int(temp.i/params[2])+params[4]] = params[1][temp.i];
              player.level.updateboard2(params[3],params[4],params[2],params[1].size()/params[2]);
            }
          }
        }  
      }
      else if (player.account in this.tempStaff3){
        for (i=0; i < this.tempStaff.size(); i++){
          if  (player.account == this.tempStaff3[i] && player.level == this.tempStaff3[i+1]){
            for (temp.i=0; temp.i < params[1].size(); temp.i ++){
              player.level.tiles[(temp.i%params[2])+params[3],int(temp.i/params[2])+params[4]] = params[1][temp.i];
              player.level.updateboard2(params[3],params[4],params[2],params[1].size()/params[2]);
            }
          }
        }  
      }
      else if (player.account in this.tempStaff4){
        for (i=0; i < this.tempStaff.size(); i++){
          if  (player.account == this.tempStaff4[i] && player.level == this.tempStaff4[i+1]){
            for (temp.i=0; temp.i < params[1].size(); temp.i ++){
              player.level.tiles[(temp.i%params[2])+params[3],int(temp.i/params[2])+params[4]] = params[1][temp.i];
              player.level.updateboard2(params[3],params[4],params[2],params[1].size()/params[2]);
            }
          }
        }  
      } 


[ffcmike]

Originally Posted by Devil_Lord2

Is this of the same problem?

No, it's because you're attempting to use the same 'i' variable within loops contained within loops, which basically resets the first loop back to 0 and repeats infinitely until the engine cancels it.

The rest of the code is also terribly inefficient, can be accomplished by much easier means, and it doesn't really make sense that you're defining this. variables as if they're a temp. variable while using a prefix in the name. Those arrays should be set one time onCreated.

[Tolnaftate2004]

Oh boy

PHP Code:

function onCreated() {
  this.trigger("YourTerribleCodeFixed", 0, this.maxlooplimit*2);
}

function onYourTerribleCodeFixed(start, total) {
  temp.sub = min(total, this.maxlooplimit);
  for (temp.i = 0; temp.i < temp.sub; temp.i++) {
    echo(start + temp.i);
  }
  total -= temp.sub;
  if (total > 0) {
    this.scheduleevent(1, "YourTerribleCodeFixed",
                       start + temp.sub, total);
  }
} 


e: You could also forgo the scheduleevent, but triggers have their own per-frame limit (10 or so).
e2: but at least if you do it will fail silently!

[Devil_Lord2]

Originally Posted by ffcmike

No, it's because you're attempting to use the same 'i' variable within loops contained within loops, which basically resets the first loop back to 0 and repeats infinitely until the engine cancels it.

The rest of the code is also terribly inefficient, can be accomplished by much easier means, and it doesn't really make sense that you're defining this. variables as if they're a temp. variable while using a prefix in the name. Those arrays should be set one time onCreated.

Ahh, didn't see the same 'i' being used, I'll have to add temp later.
My much easier means that I thought of was doing the .index() but I didn't know how. ^.^; didn't feel like bothering you so I did it with a for loop.

Also, they are temp since most of the staff will be deleted after the LAT contest. o.O; I put temp for my own purposes.


I believe this was all I had to do. ^.^;;
I don't know why I used 'i' twice. Late at night I do stupid things.
Added temp. as well, not sure why I left that out either.

PHP Code:

      else if (player.account in this.tempStaff){
        for (temp.a=0; a < this.tempStaff.size(); a++){
          if  (player.account == this.tempStaff[a] && player.level == this.tempStaff[a+1]){
            for (temp.i=0; i < params[1].size(); i++){ 


Thank you all, lets see if it works on the fourth. o.O;;
I guess my problem was stupidity and drowsiness.

-EDIT-

However, my friend is trying to create a baddy using a specific algorithm and he is having problems with maxing out the loop only if he doesn't add a sleep .05 in..

I believe he wants something like an onTimeout calling an onTimeout right after the end of checking... Perhaps that is the same problem? I don't know. I doubt he will post on the forums though..

[ffcmike]

Originally Posted by Devil_Lord2

PHP Code:

      else if (player.account in this.tempStaff){
        for (temp.a=0; a < this.tempStaff.size(); a++){
          if  (player.account == this.tempStaff[a] && player.level == this.tempStaff[a+1]){
            for (temp.i=0; i < params[1].size(); i++){ 


Do you realise you have 2 conditions which are exactly the same?
If you were to remove the first line of player.account in this.tempStaff, it would still work.

player.level is an object rather than a string, the correct value to check is 'player.level.name'.

It's a bad practise to loop through non-changing arrays and use .size(); for every cycle, as the function will occur every time rather than once, this can generate a lot of overhead with very large arrays. The array size can be defined as a temporary variable beforehand, which can then be used in the loop condition.

Originally Posted by Devil_Lord2

However, my friend is trying to create a baddy using a specific algorithm and he is having problems with maxing out the loop only if he doesn't add a sleep .05 in..

I believe he wants something like an onTimeout calling an onTimeout right after the end of checking... Perhaps that is the same problem? I don't know. I doubt he will post on the forums though..

onTimeout(); occuring within function onTimeout(){} without any specification for it would run infinitely until cancelled by the engine/NPC-Server.

[Devil_Lord2]

Originally Posted by ffcmike

Do you realise you have 2 conditions which are exactly the same?
If you were to remove the first line of player.account in this.tempStaff, it would still work.

Yes, I did that so if the first part didn't check, it wouldn't have to do the for loop, I assumed it would speed up what ever else it is doing if the first part was not correct.

The second part is only to add +1 to whatever the i is for the level, which I believe I could do with .index() but don't know how...

Originally Posted by ffcmike

player.level is an object rather than a string, the correct value to check is 'player.level.name'.

I have been told this many times, and I still don't quite understand it since the results are always the same. :[

Originally Posted by ffcmike

It's a bad practise to loop through non-changing arrays and use .size(); for every cycle, as the function will occur every time rather than once, this can generate a lot of overhead with very large arrays. The array size can be defined as a temporary variable beforehand, which can then be used in the loop condition.

for instance temp.num = something.size(); and stick that in the loop?
I shall do that!

Originally Posted by ffcmike

onTimeout(); occuring within function onTimeout(){} without any specification for it would run infinitely until cancelled by the engine/NPC-Server.

I'll ask you later, he says it does not work but I don't know what he had done. All I know is he had many loops inside of his and said it kept maxing out or something...

He is not on for me to ask. :[

-Correction-
He gave it to me to see, but I don't know if I have the right to expose it. :X
So I must ask.

[cbk1994]

Originally Posted by Devil_Lord2

I have been told this many times, and I still don't quite understand it since the results are always the same. :[

I feel like I've explained this before to you. Objects are typically coerced into strings (using their name property) when you abuse them like strings. It's better to compare the strings yourself for clarity.

[Devil_Lord2]

Originally Posted by cbk1994

I feel like I've explained this before to you. Objects are typically coerced into strings (using their name property) when you abuse them like strings. It's better to compare the strings yourself for clarity.

You probably have and I still don't get it..
They just equal the same things in testing, unless I see an error of some kind giving physical evidence why it shouldn't be used I'll probably never fully understand. D:



ZeroG's algorithm I'll explain but won't show. It checks every tile within 32x32 of a level spreading out from the NPC. It finds the nearest path to the player, and comes back to it self in the check. After that it moves once...

This process repeats over and over and over until it moves towards the player.

It uses MANY for loops in the timeout, however, at the end it seems to NOT work if you do not have a sleep(.05); and having that makes it seriously slow...

Yet this algorythm works fine on another game that he is making in Simple. He doesn't want me to post it because he doesn't believe anyone else has tried it, nor does he believe anyone can fix it.

Is Graal not fast enough to do these type of things?

He uses V5 and it slowly comes to him, I use V6 and it seems to do the loop about 3 times before stopping.. if it finds me and I'm close to it then it will move to me once or twice... if I'm about 6 tiles away the finding part of the gets to me and stops... if I'm farther it stops in the same spot too..

If this cannot be helped without images or code than it is fine.

[Skyld]

Originally Posted by Devil_Lord2

You probably have and I still don't get it..
They just equal the same things in testing, unless I see an error of some kind giving physical evidence why it shouldn't be used I'll probably never fully understand. D:

PHP Code:

function onCreated()
{
  temp.obj = new TStaticVar("SomeObject");
  
  temp.one = new SomeObject();
  temp.two = new SomeObject();
  
  temp.one.asdf = "hi";
  temp.two.asdf = "foo";
  
  echo(format("Object one is '%s'", temp.one));
  echo(format("Object two is '%s'", temp.two));
  echo(format("Object keys: '%s', '%s'", temp.one.asdf, temp.two.asdf));
  
  // Compare the objects as objects
  if (temp.one == temp.two)
    echo("Objects are the same");
  else
    echo("Objects are different");
  
  // Compare the objects after being coerced to strings
  if (@temp.one == @temp.two)
    echo("Object names are equal");
  else
    echo("Object names are different");  
} 


Output:

NPC Code:

---

Object one is 'SomeObject'

Object two is 'SomeObject'

Object keys: 'hi', 'foo'

Objects are different

Object names are equal

---

When the objects are coerced into strings, you get the object names only typically. In this example, it results in two objects appearing to be the same (because their object names are the same) even though we have just proven them to be different.

This is something you MUST be aware of when coercing objects into strings in GScript. It doesn't always work how you expect.

[Devil_Lord2]

Originally Posted by Skyld

PHP Code:

function onCreated()
{
  temp.obj = new TStaticVar("SomeObject");
  
  temp.one = new SomeObject();
  temp.two = new SomeObject();
  
  temp.one.asdf = "hi";
  temp.two.asdf = "foo";
  
  echo(format("Object one is '%s'", temp.one));
  echo(format("Object two is '%s'", temp.two));
  echo(format("Object keys: '%s', '%s'", temp.one.asdf, temp.two.asdf));
  
  // Compare the objects as objects
  if (temp.one == temp.two)
    echo("Objects are the same");
  else
    echo("Objects are different");
  
  // Compare the objects after being coerced to strings
  if (@temp.one == @temp.two)
    echo("Object names are equal");
  else
    echo("Object names are different");  
} 


Output:

NPC Code:

---

Object one is 'SomeObject'

Object two is 'SomeObject'

Object keys: 'hi', 'foo'

Objects are different

Object names are equal

---

When the objects are coerced into strings, you get the object names only typically. In this example, it results in two objects appearing to be the same (because their object names are the same) even though we have just proven them to be different.

This is something you MUST be aware of when coercing objects into strings in GScript. It doesn't always work how you expect.

Sorry, I know you are trying to help, but I'm confused as to what any of that means..

Can you do it in layman's terms and possibly actually use levels?
Also, why are levels objects and not only strings?
I thought levels were only names of a textfiles converted to .nw..