Help

[Rapidwolve]

I just recently scripted a mailing system and I am now scripting the part that states who has the most letters sent.

PHP Code:

for (i: allplayers){
temp.player = findPlayer(i);
this.sentmail.(@temp.player) = temp.player.clientr.sentmailamt;
} 


I get it to output in the flags of the npc 'Mail':

PHP Code:

sentmail.MandangoP2P=19
sentmail.rapidwolve=2
sentmail.Spike5656=0 


I then use a function 'calcMostSent' to determine who sent the most I am stumped at this part, I have no clue what to do. I've tried:

PHP Code:

for (j: this.sentmail.getdynamicvarnames()){
if (this.sentmail.(@j) > this.sentmail(@j[j+j-1]){
this.mostsent = this.sentmail.(@j);
this.mostsentacc = j;
}
} 


Don't even ask why I did that, because I was just guessing X_x. I tried alot of other ways but it hasn't worked. Can somebody help me?

[Inverness]

PHP Code:

temp.keys = getstringkeys("this.sentmail.");
setarray(temp.mostsent, 2); // account & number sent
for (temp.i = 0; temp.i < temp.keys.size(); temp.i ++) {
  temp.current = makevar("this.sentmail." @ temp.keys[temp.i]);
  if (temp.current > temp.mostsent[1]) {
    temp.mostsent[1] = temp.current;
    temp.mostsent[0] = temp.keys[temp.i];
  }
}
return temp.mostsent[0]; 


I prefer using makevar() since the other way seems to get funky sometimes.

[Rapidwolve]

Once again you helped me

[projectigi]

PHP Code:

for (j: this.sentmail.getdynamicvarnames()){
if (this.sentmail.(@j) > this.sentmail(@j[j+j-1]){
this.mostsent = this.sentmail.(@j);
this.mostsentacc = j;
}
} 


PHP Code:

if (this.sentmail.(@j) > this.sentmail(@j[j+j-1]){ 


i guess it could work if you change it to, and you forgot a closing )

PHP Code:

if (this.sentmail.(@j) > this.(@ "sentmail" @ j[j+j-1])){ 


or did you try to do this

PHP Code:

if (this.sentmail.(@j) > this.sentmail.(@j[j+j-1])){ 


[Chompy]

Originally Posted by projectigi

PHP Code:

for (j: this.sentmail.getdynamicvarnames()){
if (this.sentmail.(@j) > this.sentmail(@j[j+j-1]){
this.mostsent = this.sentmail.(@j);
this.mostsentacc = j;
}
} 


PHP Code:

if (this.sentmail.(@j) > this.sentmail(@j[j+j-1]){ 


i guess it could work if you change it to, and you forgot a closing )

PHP Code:

if (this.sentmail.(@j) > this.(@ "sentmail" @ j[j+j-1])){ 


or did you try to do this

PHP Code:

if (this.sentmail.(@j) > this.sentmail.(@j[j+j-1])){ 


he only missed a bracet :O

if (this.sentmail.(@j) > this.sentmail(@j[j+j-1]){

should be

if (this.sentmail.(@j) > this.sentmail(@j[j+j-1])){

NPC Code:

---

if (this.sentmail.(@j) > this.sentmail(@j[j+j-1])){

---

[ApothiX]

Originally Posted by Chompy

NPC Code:

---

if (this.sentmail.(@j) > this.sentmail(@j[j+j-1])){

---

That wouldn't work, because it would be trying to call the 'sentmail' function, the correct way to do it was already stated: this.(@"sentmail" @ j[j+j-1]), or by using makevar()

[Tolnaftate2004]

Originally Posted by Inverness

I prefer using makevar() since the other way seems to get funky sometimes.

this.(@varname) is more efficient and less cluttered. It's 'funky' in the original post because he's using the for-each loop variables incorrectly.

Originally Posted by projectigi

i guess it could work if you change it to, and you forgot a closing )

PHP Code:

if (this.sentmail.(@j) > this.(@ "sentmail" @ j[j+j-1])){ 


or did you try to do this

PHP Code:

if (this.sentmail.(@j) > this.sentmail.(@j[j+j-1])){ 


Neither works. j is most likely a string. I don't know what str + str -1 makes. Nor can I be certain what str[str+str-1] does.

Originally Posted by Chompy

NPC Code:

---

if (this.sentmail.(@j) > this.sentmail(@j[j+j-1])){

---

PHP Code:

temp.arr = this.sentmail.getdynamicvarnames();
temp.max = {-1,{""}};
for (j: temp.arr) {
  temp.sent = this.sentmail.(@j);
  if (temp.sent > temp.max[0]) {
    temp.max = {temp.sent,{j}};
  } elseif (temp.sent == temp.max[0]) temp.max[1].add(j);
}
return temp.max[1]; 


Or something of that sort.

[Inverness]

Originally Posted by Tolnaftate2004

this.(@varname) is more efficient and less cluttered. It's 'funky' in the original post because he's using the for-each loop variables incorrectly.

How exactly is it more efficient?

[napo_p2p]

Originally Posted by Inverness

How exactly is it more efficient?

My guess is that is just has to access the variable, rather than have to call a function.

Not a big difference really ... I was just never a big fan of makevar.... (but you know that already :P).

[Rapidwolve]

Originally Posted by Inverness

How exactly is it more efficient?

I never understood how it was more efficient either but I use it now because I dont want to type makevar all the time

[Tolnaftate2004]

Originally Posted by Inverness

How exactly is it more efficient?

I think Stefan said it somewhere. I went looking for it, but I couldn't find it.

But logically, one could assume that the makevar function is just doing a (@var) thing anyway.

[Skyld]

Originally Posted by Tolnaftate2004

I think Stefan said it somewhere. I went looking for it, but I couldn't find it.

But logically, one could assume that the makevar function is just doing a (@var) thing anyway.

Logically it would perform (@ var) in iteration for each part.of.the.variable, I suppose, not sure if that is how it is actually working though.

[Inverness]

Originally Posted by Rapidwolve

I never understood how it was more efficient either but I use it now because I dont want to type makevar all the time

Typeing makevar is not a problem with me it takes no time at all. And I don't need to use makevar in the mudlib anyhow since I have functions for that. I like makevar because it looks better to me than the other option.