New accounts

[Chompy]

Originally Posted by Robin

player.account > player.communityname

• new player attribute player.communityname which displays the name the player is using for the forums etc.
  
  • by default players have now an account name which is basicly just a number (Graal12345) and can later register a communityname which is then used for the fourms, wiki etc.
  • on the playerlist and PMs it will display the community name instead of the account name, scripts are supposed to do the same

1. I haven't done much testing but I'm assuming it's safe to just use community name where you would previously just use account.

2. Unless of course, those with old account names but never had any access to the forum and thus have never registered a community name, makes the community name return null?

If the same goes with new accounts who have not yet registered a community name (which of course does suck) but a simple fix would be to fall back to the account name or even the nickname of the player to assertain identity.

However, nicknames are not as secure as the previous two options.

I'll do some testing later today and post my findings in the scripting forum if you like Crow?

1. You can't use findplayer() on communitynames..
2. Old accounts before the comunitynames will get their community name set to their account so account == communityname in their case

[Crow]

Thanks for the offer Robin, but I have done enough and I might also say too much testing on this already. It just sucks. Think about commands like /itemtrade on Era. It's asking for the account to trade to (or did so in the past). Nobody wants to use Graalxxxxxx accounts for that, but if people don't have a community name I also have to code something that allows people to put both account and community name. That's just ****in complicated.

[Robin]

Originally Posted by Chompy

1. You can't use findplayer() on communitynames..
2. Old accounts before the comunitynames will get their community name set to their account so account == communityname in their case

1. findplayerbycommunityname(str) returns object
2. What about new accounts?

[blazeingonix]

Lot of accounts with Graal1349595 , Graa19394 and i can't remember who they're this suck .

[Chompy]

Originally Posted by Crow

Thanks for the offer Robin, but I have done enough and I might also say too much testing on this already. It just sucks. Think about commands like /itemtrade on Era. It's asking for the account to trade to (or did so in the past). Nobody wants to use Graalxxxxxx accounts for that, but if people don't have a community name I also have to code something that allows people to put both account and community name. That's just ****in complicated.

I always use something like this or something :o

PHP Code:

  a = pl.communityname;
  if (a == 0) a = pl.account;
  else if (a == "guest") a = pl.account; 


so..

PHP Code:

function checkPlayer(plyr) {
  temp.a = findplayer(plyr);
  if (a == 0) a = findplayerbycommunityname(plyr);
  if (a == 0) return 0;
  return 1;
} 


something like that would do it, but I haven't tested it though..

Originally Posted by Robin

1. findplayerbycommunityname(str) returns object
2. What about new accounts?

1. You stated that we could just use communityname where we used accounts, not true as I stated that you can't use findplayer() and that has been used since gs2 came out. findplayerbycommunityname() was added some weeks after the communitynames came out because of complaints in the scripting forum..

2. New accounts can choose their own communityname once logged on graalonline.com and then by editing their profile from there if I recall.

I would like findplayer() to work with both findplayerbycommunityname() is too long.. and I don't like to make something like

PHP Code:

public function findcommunityplayer(a) {
  return findplayerbycommunityname(a);
} 


or something like that..

[Robin]

Originally Posted by Chompy

PHP Code:

function checkPlayer(plyr) {
  temp.a = findplayer(plyr);
  if (a == 0) a = findplayerbycommunityname(plyr);
  if (a == 0) return 0;
  return 1;
} 


Jesus chompy what are you doing to me man, you scared the crap out of me.

Before you edited your post I had this in the quick reply box:

PHP Code:

function _getPlayer(pl) {
  temp.p = findplayerbycommunityname(pl);
  if (temp.p == 0) {
    temp.p = findplayer(pl);
    if (temp.p == 0) {
      return 0;
    } else {
      return temp.p;
    }
  } else {
    return temp.p;
  }
} 


[EDIT]
Actually that can probably be optimised:

PHP Code:

function _getPlayer(pl) {
  temp.p = findplayerbycommunityname(pl);
  return p == 0 ? findplayer(pl) : p;
} 


[/EDIT]

[Chompy]

Originally Posted by Robin

Jesus chompy what are you doing to me man, you scared the crap out of me.

Before you edited your post I had this in the quick reply box:

PHP Code:

function _getPlayer(pl) {
  temp.p = findplayerbycommunityname(pl);
  if (temp.p == 0) {
    temp.p = findplayer(pl);
    if (temp.p == 0) {
      return 0;
    } else {
      return temp.p;
    }
  } else {
    return temp.p;
  }
} 


[EDIT]
Actually that can probably be optimised:

PHP Code:

function _getPlayer(pl) {
  temp.p = findplayerbycommunityname(pl);
  return p == 0 ? findplayer(pl) : p;
} 


[/EDIT]

hehe


and, about your edit, that's not optimised though, as it does the same amount of checks .. linecount however is smaller

[Robin]

two is the smallest amount of checks but if you notice it only does one if statement instead of two, hence optimised (although not by much)

[Crow]

Originally Posted by Robin

two is the smallest amount of checks but if you notice it only does one if statement instead of two, hence optimised (although not by much)

Still needs Chompsters "guest" check included, thats really important. Chompy, yes, I'm using something similar. Still annoying me thinks.

[Chompy]

Originally Posted by Robin

two is the smallest amount of checks but if you notice it only does one if statement instead of two, hence optimised (although not by much)

There's an 'else' in there though

return p == 0 ? findplayer(pl) : p
if (p == 0) return findplayer(pl) else return p;

[Frankie]

I honestly don't see what potential Stefan/Unix saw in this dumb account system.

[Crow]

Originally Posted by Chompy

There's an 'else' in there though

return p == 0 ? findplayer(pl) : p
if (p == 0) return findplayer(pl) else return p;

Those two lines equal.

Originally Posted by Frankie

I honestly don't see what potential Stefan/Unix saw in this dumb account system.

Original idea was that trials can't take "good" account names anymore but still keep what they have done while playing without a community name.

[Robin]

Note the nested if in the if statement in my other post. I saved amount of if statements x 2.

ANYWAY, Back to topic, Why don't they remove trials completely, you have a guest account, and then when you sign up properly you can sign up a proper account name?

The graal14289452359234534258234905839024589239045 crap is really awful.

[Crow]

Originally Posted by Robin

Note the nested if in the if statement in my other post. I saved amount of if statements x 2.

ANYWAY, Back to topic, Why don't they remove trials completely, you have a guest account, and then when you sign up properly you can sign up a proper account name?

The graal14289452359234534258234905839024589239045 crap is really awful.

Eh, trials are removed, when I said trial I meant guests. Actually, yea, doing that wouldn't be a problem at all. I mean, people could register custom account names for years. Why not now? This was never a problem, your account is not your nickname or something.

[Elizabeth]

Originally Posted by kia345

That has to be the stupidest update yet. Good job

agreed