Script errors

[Inverness]

Originally Posted by cbkbud

Maybe something like this:

PHP Code:

this.attr[2] = findnpc("BlooIntercoms").(@this.intid).( @ "message" ); 


Absolutely not.

[cbk1994]

What's yucky about it?

[Inverness]

Originally Posted by cbkbud

What's yucky about it?

Compare mine to yours.

[Chompy]

PHP Code:

function onCreated() {
  echo(findnpc("rawr").message); // If the npc exists or not doesn't matter
}
/*
Script compiler output for ChompyTest:
Weapon/GUI-script ChompyTest added/updated by Chompy
*/ 


So, actually Chris' script wouldn't output the 'Script compiler ...' line ;o

[cbk1994]

I thought the problem was that it was rejecting any string named message, therefor, it wouldn't let you do x.message ... ?

[Chompy]

Originally Posted by cbkbud

I thought the problem was that it was rejecting any string named message, therefor, it wouldn't let you do x.message ... ?

Actually it only only happens when using findnpc, findplayer, findlevel, actually, any function like object, odd huh?

All these scripts will produce the line

PHP Code:

function onCreated() {
  echo(findplayer("Chompy").message); // if the player exists or not doesn't matter
}
/*
Script compiler output for ChompyTest:
Weapon/GUI-script ChompyTest added/updated by Chompy
*/ 


PHP Code:

function onCreated() {
  echo(findad("pepsi").message); // doesn't matter if the function exists
}
/*
Script compiler output for ChompyTest:
Weapon/GUI-script ChompyTest added/updated by Chompy
*/ 


PHP Code:

function onCreated() {
    echo(findbirdandpatit().message); // you get the point..
}
/*
Script compiler output for ChompyTest:
Weapon/GUI-script ChompyTest added/updated by Chompy
*/ 


Now, the weird thing about it is..

this works:

PHP Code:

function onCreated() {
  temp.a_b = new TStaticVar();
  temp.a_b.c = "foo";
  
  temp.b = "_b";
  
  echo(makevar("a"@b).c);
}
/*
foo
*/ 


while this doesn't

PHP Code:

function onCreated() {
  temp.a_b = new TStaticVar();
  temp.a_b.message = "foo";
  
  temp.b = "_b";
  
  echo(makevar("a"@b).message);
}
/*
Script compiler output for ChompyTest:
Weapon/GUI-script ChompyTest added/updated by Chompy
*/ 


[Skyld]

It is possibly something to do with function prototyping (whereby functions are child members of an object with the same name). I guess if some object has a message() function, you can probably not use the same variable name.

Not sure why that would happen with objects returned from findplayer() though.

[Admins]

Hmmm doesn't seem to be a new problem, same error on older servers. It has the same problem with any funcname().oldscriptcommand, e.g. funcname().loadmap, seeing loadmap as the GS1 loadmap() function and ignoring funcname(). (and giving error when being put in echo() or similar). I will check if that can be fixed easily.

[xXziroXx]

Originally Posted by Inverness

PHP Code:

this.attr[2] = findnpc("BlooIntercoms").(@ this.intid).message;
or
this.attr[2] = BlooIntercoms.(@ this.intid).message; 


You don't put a period inside the parenthesis thingy. You can only do that with makevar().

Wrong. I'm using it on multiple places.

TStaticVar() = this.attr[2] = findnpc("BlooIntercoms").(@ this.intid).message
Normal var = this.attr[2] = findnpc("BlooIntercoms").(@ this.intid ".message")

[Inverness]

Originally Posted by xXziroXx

Wrong. I'm using it on multiple places.

TStaticVar() = this.attr[2] = findnpc("BlooIntercoms").(@ this.intid).message
Normal var = this.attr[2] = findnpc("BlooIntercoms").(@ this.intid ".message")

Well okay then, feel free to promote bad habits.

[Tolnaftate2004]

Originally Posted by xXziroXx

Normal var = this.attr[2] = findnpc("BlooIntercoms").(@ this.intid ".message")

This doesn't work.

[xXziroXx]

Inverness, Pfa - sorry. I scaned some of my older scripts where I was sooo sure I used it, and only examples I could find was with makevar().

l2think, right?

[zokemon]

Originally Posted by xXziroXx

Inverness, Pfa - sorry. I scaned some of my older scripts where I was sooo sure I used it, and only examples I could find was with makevar().

l2think, right?

I'm pretty sure PFA is referring to that fact that you did not concatenate this.intid and ".message" together which would cause a compiler (syntax) error, not a run-time error.

[xXziroXx]

Originally Posted by zokemon

I'm pretty sure PFA is referring to that fact that you did not concatenate this.intid and ".message" together which would cause a compiler (syntax) error, not a run-time error.

I wasn't even looking at the var names or anything, I simply took what was written and showed the syntax I was so sure I had used in the past.

[Admins]

Ok fixed the problem, the new npcserver will be uploaded in a few days. It was accepting GS1 commands after closing brackets ")", but not correctly handling the case "functioncall().variablename".