NPC checking for player

[cbk1994]

Originally Posted by i8bit

Oh yeah, good observation. What if I don't make it loop and it just checks for players/NPCs in that 0.05 time range, triggers the actions, then destroys?

Should work if you only want it to send the trigger once. Just call this.destroy(); after sending the trigger.

[i8bit]

Originally Posted by cbk1994

Should work if you only want it to send the trigger once. Just call this.destroy(); after sending the trigger.

So I ran into a little bit of issues. I discovered I need to destroy the block serverside. How would I trigger a serverside function in clientside?

I tried this in the clientside

PHP Code:

triggerserver("npc", this.name, "destroy") 


and this in the serverside..

PHP Code:

function onActionServerSide(){
 if (params[0] == "destroy"){
  destroy();
  }
 } 


it doesn't work so can you tell me what I'm doing wrong please?

[Torankusu]

Is this in a class or level npc?

Also, are you going to be using this in a situation where the blocks appearance and location needs to be:
A.) The same for all players in the level
Or
B.) Can be different for all players in the level.

Some good suggestions previously listed here, but there are potentially a lot of ways to cheat this on the clientside as well.

[i8bit]

Originally Posted by Torankusu

Is this in a class or level npc?

Also, are you going to be using this in a situation where the blocks appearance and location needs to be:
A.) The same for all players in the level
Or
B.) Can be different for all players in the level.

Some good suggestions previously listed here, but there are potentially a lot of ways to cheat this on the clientside as well.

It is a class.

[callimuc]

triggerserver() does not work inside level NPCs, you would need to use triggerAction() for this case

[cbk1994]

I still don't really know what you're doing so it's hard to give advice, but if your NPCs are created via putnpc2, they do have a name, and you can trigger them via triggerServer (but you have to get the name clientside; normally it isn't available). That might be the best approach.

[callimuc]

Originally Posted by callimuc

triggerserver() does not work inside level NPCs, you would need to use triggerAction() for this case

Have to fix this statement, you can use triggerServer() inside level NPCs to trigger DB NPCs or weapons (and classes being joined to those). I figured this would be the best solution if you also want to receive the onActionServerSide() inside level NPCs (or NPCs created via putNPC2()) and classes being joined to those

Originally Posted by cbk1994

You can also do

PHP Code:

function onCreated() {
  this.level.tapThis = this;
}

function onPow() {
  this.chat = "ouch!";
}

//#CLIENTSIDE
function onPlayerChats() {
  triggerServer("npc", "TriggerControl", "Trigger", this.level.name, "tapThis", "Pow");
} 


and then in an NPC TriggerControl

PHP Code:

function onActionTrigger(levelName, npcName, command) {
  findLevel(levelName).(@ npcName).trigger(command);
} 


Though you'd want to add some security features. Usually something like this is preferable since you never know if a trigger will be received when using x/y.

[i8bit]

Allow me to clarify exactly what I'm doing.

When the player presses 'a', the player creates an NPC that I'm using as a damage block. The NPC is functional through joining a class.

Perhaps it'd be easier to explain if I did step by step what I'm doing, so I can get some better, more specific advice.

1. Player presses 'A' and creates the "damage block" NPC.
This is the code from the Weapon

PHP Code:

function onActionServerSide(){
if (params[0] == "dmgblock"){
 temp.npc = this.level.putNPC2(player.x, player.y, "");
 temp.npc.join("damageblock");
 }
}

//#CLIENTSIDE
function onKeyPressed(code, key){
 if (key == "c"){
  player.chat = "Placed!";
   triggerserver("weapon", this.name, "dmgblock");
   }
  } 


I realize the placement with the x and y is off and the player will collide instantly within placing. Ignore that.

2. The NPC preforms it's function, then deletes
This is where I'm Having issues. I need the block to destroy serverside.
This is the script from the CLASS it joined

PHP Code:

function onActionServerside(){
 if (params[0] == "destroy"){
  destroy();
  }
  }

//#CLIENTSIDE
function onCreated(){
 dontblock();
 setImg("block.png");
 onTimeOut();
 scheduleEvent(1, "onDestroy");
}


function onTimeOut(){
 if (player.x in |this.x, this.x + 2| && player.y in |this.y, this.y + 2|) { 
 player.chat = "HIT";}
 //Trigger Actions in the player to make him lose HP and Whatever else
 setTimer(0.05);
}

function onDestroy(){
 triggerAction("npc", this.name, "destroy");
} 


[BlueMelon]

Consider this example:

PHP Code:

function onCreated() {
  setshape(1,32,32);
}
function onActionTest() {
  this.chat = random(0,100);
}

//#CLIENTSIDE

function onCreated() {
  setTimer(0.05);
}
function onTimeout() {
  triggeraction(this.x,this.y,"test");
  setTimer(1);
} 


[callimuc]

Weapon script:
changed your this.level.putNPC2(...) to player.level.putNPC2(...), this. would refer to the weapon while player. refers to the player)

PHP Code:

function onActionServerSide(){
  if (params[0] == "dmgblock"){
    temp.npc = player.level.putNPC2(player.x, player.y, ""); //should be player.level instead of this.level
    temp.npc.join("damageblock");
  }
}

//#CLIENTSIDE
function onKeyPressed(code, key){
  if (key == "c"){
    player.chat = "Placed!";
    triggerserver("weapon", this.name, "dmgblock");
  }
} 


Class script:
removed your dontBlock() as it needs to be a blocking NPC I believe
fixed your triggerAction()
and other stuff

PHP Code:

function onCreated() {
    //1=blocking, 32=width in pixel, 32=height in pixel
  setshape(1, 32, 32);
}

function onActionDestroyBlock() {
  this.destroy();
}

//#CLIENTSIDE
function onCreated() {
  setshape(1, 32, 32);
  this.setImg("block.png");
  onTimeOut();
}


function onTimeOut(){
    //if player is within the square, trigger the actions
  if (player.x in |this.x, this.x + 2| && player.y in |this.y, this.y + 2|) { 
    player.chat = "HIT";
      //stop the script and call the 'onDestroyObject()' function
    return onDestroyObject();
  }
    //keep running the script as the player hasnt been inside the block range yet
  setTimer(0.05);
}

function onDestroyObject() {
    //x, y, onAction...., parameters
  triggerAction(this.x, this.y, "DestroyBlock", NULL);
} 


[i8bit]

[QUOTE=BlueMelon;1724944]Consider this example:


Thanks for the tip. Here's what I got

PHP Code:

function onCreated() {
  setshape(1,32,32);
  setImg("block.png");
}

function onActionTest(){
  destroy();
  }

//#CLIENTSIDE
function onCreated(){
 dontblock();
 setTimer(1);
  if (player.x in |this.x, this.x + 2| && player.y in |this.y, this.y + 2|) { 
  player.chat = "HIT";} 
}


function onTimeOut(){
 triggeraction(this.x,this.y,"Test");
} 


PROBLEM:
It sometimes works, and sometimes doesn't. It seems to only destroy half the time... Anything I can modify to make it more reliable?

[BlueMelon]

Take a look at what you posted, and what callimuc and I have posted.

You are checking the collision when the npc is created. Meaning it is comparing the coordinates once... this is not what you want.

[callimuc]

Originally Posted by i8bit

PROBLEM:
It sometimes works, and sometimes doesn't. It seems to only destroy half the time... Anything I can modify to make it more reliable?

you need to put the players location check into the loop, check my example. else it will only work when the block is being placed but it never checks back again.

[Torankusu]

What they said
Plus, its also probably noteworthy to make sure you use setTimer (0.05 or however long...) in the onTimeout function to continue the loop -- you don't have it this way in your example.

Also, not necessary, but if you wanted to start the loop as immediately as it was created just call onTimeout (); in the on created function.

edit: sorry, missed it on my phone.
callimuc's example is spot on -- disregard my post if you follow his examples -- or just take them as an explanation for what he did. :]

[i8bit]

I wanna thank everyone for all the advice! I have been really learning a lot!
So far I have it running correct with the tests I have put it through. But if I run in to any trouble I will be sure to add on to this thread with my questions.