Clean Coding - Common Sense

[Inverness]

Heres a sample of my coding, I'm extremely picky about the formatting.

PHP Code:

public function loadRefs(obj) {
  temp.i;
  temp.e;
  temp.vars;
  temp.count;
  temp.ref;
  
  vars = obj.getVarNames();
  count = 0;
  for (i = 0; i < vars.size(); i ++) {
    if (obj.(@ vars[i]).type() == 1) {
      if (MudControl.isRefStr(obj.(@ vars[i]))) {
        ref = obj.(@ vars[i]);
        obj.(@ vars[i]) = MudControl.parseRef(ref);
        obj.(@ vars[i]).addRef(obj);
        count ++;
      }
    }
    else if (obj.(@ vars[i]).type() == 3) {
      for (e = 0; e < obj.(@ vars[i]).size(); e ++) {
        if (obj.(@ vars[i])[e].type() == 1) {
          if (MudControl.isRefStr(obj.(@ vars[i])[e])) {
            ref = obj.(@ vars[i])[e];
            obj.(@ vars[i])[e] = MudControl.parseRef(ref);
            obj.(@ vars[i])[e].addRef(obj);
            count ++;
          }
        }
      }
    }
  }
  echo(format("References Loaded (%s): %s %s", count, obj.mudtype, obj.mudid));
} 


[xXziroXx]

Originally Posted by Inverness

Heres a sample of my coding, I'm extremely picky about the formatting.

PHP Code:

public function loadRefs(obj) {
  temp.i;
  temp.e;
  temp.vars;
  temp.count;
  temp.ref;
  
  vars = obj.getVarNames();
  count = 0;
  for (i = 0; i < vars.size(); i ++) {
    if (obj.(@ vars[i]).type() == 1) {
      if (this.isRefStr(obj.(@ vars[i]))) {
        ref = obj.(@ vars[i]);
        obj.(@ vars[i]) = parseRef(ref);
        obj.(@ vars[i]).addRef(obj);
        count ++;
      }
    }
    else if (obj.(@ vars[i]).type() == 3) {
      for (e = 0; e < obj.(@ vars[i]).size(); e ++) {
        if (obj.(@ vars[i])[e].type() == 1) {
          if (this.isRefStr(obj.(@ vars[i])[e])) {
            ref = obj.(@ vars[i])[e];
            obj.(@ vars[i])[e] = parseRef(ref);
            obj.(@ vars[i])[e].addRef(obj);
            count ++;
          }
        }
      }
    }
  }
  echo(format("References Loaded (%s): %s %s", count, obj.mudtype, obj.mudid));
} 


Your styling is practically the same as mine

[Inverness]

Originally Posted by xXziroXx

Your styling is practically the same as mine

Note how I use temp variables. It is something I began doing only recently and it makes the script look much more organized rather than using temp. repeatedly before all the temp variable names.

[xXziroXx]

Originally Posted by Inverness

Note how I use temp variables. It is something I began doing only recently and it makes the script look much more organized rather than using temp. repeatedly before all the temp variable names.

I use temp variables all the time too!

[Kristi]

Originally Posted by Inverness

Note how I use temp variables. It is something I began doing only recently and it makes the script look much more organized rather than using temp. repeatedly before all the temp variable names.

Um, you can't do that, when you say vars = something, you're actually assinging it to vars, not temp.vars

PHP Code:

function onCreated() {
  temp.hello;
  hello = 2;
  sendtorc("TEST:" @ temp.hello);
  sendtorc("TEST2:" @ hello);
} 


Yields the following:
The best idler is the (Server): TEST:
The best idler is the (Server): TEST2:2

note that temp.hello is still null. The only way to drop the temp is if the var was passed as a paremeter, it will take presedence over an already global var.

On another note, ziro, grey, and inver all have good styling imho

[Riot]

Originally Posted by Kristi

Um, you can't do that, when you say vars = something, you're actually assinging it to vars, not test vars

PHP Code:

function onCreated() {
  temp.hello;
  hello = 2;
  sendtorc("TEST:" @ temp.hello);
  sendtorc("TEST2:" @ hello);
} 


Yields the following:
The best idler is the (Server): TEST:
The best idler is the (Server): TEST2:2

note that temp.hello is still null.

On another note, ziro, grey, and inver all have good styling imho

I was about to comment on this too:

PHP Code:

function onCreated() {
  temp.i;
  
  i = 34;
  echo("onCreated(): i =" SPC i SPC "temp.i=" SPC temp.i);
  test();
  
  this.setTimer(1);
}

function onTimeout() {
  echo("onTimeout(): i =" SPC i);
}

function test() {
  echo("test(): i =" SPC i);
} 


Returns:

onCreated(): i = 34 temp.i= 
test(): i = 34
onTimeout(): i = 34

[DrakilorP2P]

A general guideline is to keep the formatting as similar to the rest of the project as possible. It might be a good idea to write a general guideline that all developers abide to.
Here's how the Angband source code is styled:

PHP Code:

written by Robert Ruehlmann, Ben Harrison, and Gwidon S. Naskrent

There are lots of things that are commonly considered good style for Angband code. The Vanilla Angband source code is the general guideline.

Here are some of the "rules":

    * Don't use floating point calculations.
    * Don't break savefile compatibility (if not absolutely necessary).
    * No C++ code. That also means no '//' comments.
    * Put system dependent code between #ifdef xyz ... #endif /* xyz */ .
    * No "magic numbers". Use #defines. The #defines should be in defines.h rather than the source file, unless they're very local (such as dungeon generation parameters). 

And some code-style guidelines:

    * Comments, comments, comments. Multi-line comments should look like:

      /*
       * A multi-line
       * comment.
       */

      instead of:

      /* A multi-line
       * comment */

    * Indentation with tabs. But generally avoid getting lines over 80 characters.
    * Put curly braces ('{', '}') on an extra line with the same indentation level as the previous line. Example:

      if (value == 0)
      {
          do_something();
      }

    * Put empty lines between code-blocks. Example:

      /* Do something */
      do_something();

      /* Do something else */
      do_something_else();

    * Spaces around the mathematical, comparison, and assignment operators ('+', '-', '*', '/', '=', '!=', '==', '>', ...).
    * Spaces between C-identifiers like 'if', 'while', 'for', and 'return' and the opening brackets ('if (foo)', 'while (bar)', ...).
    * No spaces between function names and brackets and between brackets and function arguments (function(1, 2) instead of function ( 1, 2 )).
    * If the precedence of operations is ambiguous then put brackets around them. Also try to insert parentheses whenever necessary for readability, eg. around (foo & RF3_SOME_DEFINE). There is usually no ambiguity and no macro resolution, but this is an aesthetic detail.
    * If a function takes no arguments then it should be declared with a void argument list. Example: int foo(void) instead of int foo().
    * Function declaration and definition should look the same.
    * Don't assume that functions declared without a return type return int. Specify the type explicitly. Example: int foo(void) instead of foo(void). 


[Rapidwolve]

What does

PHP Code:

prefix.varname; 


do? Is there really a point to it? does it declare it or something

[Inverness]

Originally Posted by Rapidwolve

What does

PHP Code:

prefix.varname; 


do? Is there really a point to it? does it declare it or something

Yes, I use that for temp variables only, it declares the variable as a temp so it can be referenced without the use of temp.

When you have variables defined in function parameters they're declared as temp variables and you're able to reference them with or without the temp. before the variable name, this is the same idea.

I place all the temp declarations at the beginning so I know what all I'm using and can make notes for other people using it.

[cbk1994]

Originally Posted by Rapidwolve

What does

PHP Code:

prefix.varname; 


do? Is there really a point to it? does it declare it or something

Declares the variable, so it's value is "" not NULL.

[Inverness]

Ah, no wonder I had that array problem that time, oh well, it can be easily be fixed.

PHP Code:

function onCreated() {
  temp.rawr = 0;
  rawr = 3;
  echo("1:" @ rawr);
  echo("2:" @ temp.rawr);
} 


Returns 3 in both cases, problem solved.

Edit:
It doesn't look pretty anymore though

[Skyld]

Originally Posted by Inverness

Ah, no wonder I had that array problem that time, oh well, it can be easily be fixed.

PHP Code:

function onCreated() {
  temp.rawr = 0;
  rawr = 3;
  echo("1:" @ rawr);
  echo("2:" @ temp.rawr);
} 


Returns 3 in both cases, problem solved.

Edit:
It doesn't look pretty anymore though

I'm not sure why you are trying to manage the variables anyway. The engine's meant to do that for you, and if your functions are structured sensibly, it should be obvious which variable names you are using.

[napo_p2p]

Originally Posted by Skyld

I'm not sure why you are trying to manage the variables anyway. The engine's meant to do that for you, and if your functions are structured sensibly, it should be obvious which variable names you are using.

I think it's more of a styling thing. So he doesn't have to write temp. all of the time.

EDIT: Ding Ding Ding!

[Inverness]

Uh, I do this for the simple fact that I'm damn tired of typing temp. before every variable name, no other reason. I also like it better without temp., its more pretty like that. Also shortens the code in the long run.

[Skyld]

Originally Posted by Inverness

Uh, I do this for the simple fact that I'm damn tired of typing temp. before every variable name, no other reason. I also like it better without temp., its more pretty like that.

Hm, in my opinion, it is better to always prefix variables. That way, there is no confusion as to which scope you are working in.

I try to write my scripts for people who have to work with them as well as for myself.