Typewriter

[oralgnome]

Originally Posted by cbk1994

Why not just do this?

PHP Code:

//#CLIENTSIDE
function ChatBar.onTextChanged(temp.text) {
  if (this.on) {
    player.chat = temp.text;
  }
}

function onWeaponFired(){ 
  this.on = ! this.on;
  player.chat = "Typewriter " @ (this.on ? "on" : "off") @ "!";
} 


EDIT: In other words, there's more than one way to bake a cake.

[fowlplay4]

Originally Posted by oralgnome

EDIT: In other words, there's more than one way to bake a cake.

It's the better way to bake this specific cake.

[oralgnome]

Originally Posted by fowlplay4

It's the better way to bake this specific cake.

How so, it does the same thing - right?

[DustyPorViva]

Originally Posted by oralgnome

How so, it does the same thing - right?

Just because the end product is the same doesn't mean it's just as good. If you can't compare the OP script to Chris' and tell why one is better than the other than you need to rethink your position as a scripter.

[gaben]

Originally Posted by DustyPorViva

Just because the end product is the same doesn't mean it's just as good. If you can't compare the OP script to Chris' and tell why one is better than the other than you need to rethink your position as a scripter.

He never said it was 'just as good', he just doesn't see why it would be perceived as better at face value. I'm sure that's a safe assumption - and you have no right to determine what their position as a 'scripter' is. (Sorry, but it's true!)

Regardless of all this /e/drama, this.bool = !this.bool is a unique way of performing toggling and I can see how one would perceive it as somewhat 'better'. Though, in the end, the one that ends up playing second fiddle is the one that attempts to distinguish oneself' in the face of others.

[fowlplay4]

Originally Posted by oralgnome

How so, it does the same thing - right?

It uses a single event to detect change in text rather than a hack to detect it which simplifies the code significantly and is much easier to read and understand.

Originally Posted by gaben

Regardless, this.bool = !this.bool is a unique way of performing toggling and I can see how one would perceive it as somewhat 'better'. Though, in the end, the one that ends up playing second fiddle is the one that attempts to distinguish oneself' in the face of others.

That is irrelevant in my reasoning as to why I think it's 'better'. I would have considered writing the "toggle" like this since it's easier for new scripters to understand:

PHP Code:

//#CLIENTSIDE
function onWeaponFired() {
  if (this.on) {
    this.on = false;
    player.chat = "Typewriter off!";
  } else {
    this.on = true;
    player.chat = "Typewriter on!";
  }
}