Array help

[Astram]

This wont select the next variable in thiso.rights.
thiso.rights = Stick,Unstick,Jail,Stealth
can someone help me get this to work?

PHP Code:

function onKeyPressed(code, key, scancode) {
  for (temp.i = 0; temp.i < thiso.rights.size(); temp.i ++) {
    //[ 219
    //] 221
    //\ = 220,\,43
    if (code == 219) {
      //[
      if (this.selected - 1 => thiso.rights[0]) {
        this.selectedid = temp.i;
        this.selected = thiso.rights[(@this.selectedid - 1)];
        UpdateText(this.selected);
      }
    }
    if (code == 220) {
      //\
      if (this.selected + 1 =< thiso.rights.size() - 1) {
        this.selectedid = temp.i;
        this.selected = thiso.rights[(@this.selectedid + 1)];
        UpdateText(this.selected);
      }
    }
  }
} 


[Crow]

Why are you using a thiso prefix there? Should work with a regular this prefix.

[Astram]

Originally Posted by Crow

Why are you using a thiso prefix there? Should work with a regular this prefix.

In a different part of the script im using thiso. because well I need it

[Crow]

But you do not need it in this case. You only need that particular prefix if you want to reference to the NPC the code is executed in while being in another NPC's scope, like inside some of this stuff:

PHP Code:

with (npc) {
  // boo
} 


[Astram]

Originally Posted by Crow

But you do not need it in this case. You only need that particular prefix if you want to reference to the NPC the code is executed in while being in another NPC's scope, like inside some of this stuff:

PHP Code:

with (npc) {
  // boo
} 


Would that mess up the script like the problem im having...

[Crow]

Originally Posted by Astram

Would that mess up the script like the problem im having...

Just try using a this prefix instead of the thiso one.

[Astram]

I'm trying to make it so that you can change which variable in the array you are showing, by pressing [ and \. Once like first it will say Stick, then you press \. And it would do UpdateText(); to say Unstick, then Jail, then Stealth. But it shouldn't go any higher then the array size, and the array minimum.

[Crow]

You could use the modulo operator for this one.

PHP Code:

this.selectedid = (this.selectedid + 1) % this.rights.size(); 


Should also work for "scrolling" in the other direction. No need for a loop either. Just check the key code and do that.

[gaben]

I don't even know why you're looping it strangely in the first place, but you wrote temp.i < thiso.rights.size() instead of temp.i <= thiso.rights.size()? You'd be excluding one less array item.

In general though, there really isn't anything to 'fix' persay if we don't even know how you store your array vars (this.orights? too vague) or what you're really trying to do. Apparently you want to change the array with '[' or / yet nothing is indicating any keypresses besides onKeyPressed() which you didn't utilize properly anyway. Wat?

I guess you want to increment your array [] selectors, so why not just increment temp.i and de-increment them on '[' & / keypresses?

[0PiX0]

Originally Posted by gaben

I don't even know why you're looping it strangely in the first place, but you wrote temp.i < thiso.rights.size() instead of temp.i <= thiso.rights.size()? You'd be excluding one less array item.

No, although his script doesn't require a loop, he is looping it correctly. In arrays, the first element's index is 0, and the last element's index is array.size() - 1.

[gaben]

Originally Posted by 0PiX0

No, although his script doesn't require a loop, he is looping it correctly. In arrays, the first element's index is 0, and the last element's index is array.size() - 1.

I didn't say he was looping it incorrectly, I just said it was rather strange compared to what he wanted to accomplish.

Anyway, it'd be much easier to just increment like this and perform some checks for this.i or whatever number he'll be using for the array [0] selector.

PHP Code:

//#CLIENTSIDE

function onCreated(){
  this.i = 0;
}

function onKeyPressed(code, key){
  if(key == "[" && this.i >= 0 && this.i < 3){
         this.i++; // increment
         player.chat = this.i; // print out for verification
  }
  else if(key == "/" && this.i > 0){ // don't decrement 0 to -1!
        this.i--;
        player.chat = this.i;
  }
} 


Then I guess you'd do something like: thiso.rights[this.i] (selectors, 0,1,2,3).

[0PiX0]

Originally Posted by gaben

PHP Code:

function onCreated(){
  this.i = 0;
}

function onKeyPressed(code, key){
  if(key == "[" && this.i >= 0 && this.i < 3){
         this.i++; // increment
         player.chat = this.i; // print out for verification
  }
  else if(key == "/" && this.i > 0){ // don't decrement 0 to -1!
        this.i--;
        player.chat = this.i;
  }
} 


It's unnecessary to initialize a var to be set to 0. When incrementing, checking the condition 'this.i >= 0' is unnecessary. Also, you have the keys swapped.

Astram, I would use the method Crow described. In the end it should look somewhat like this:

PHP Code:

function GraalControl.onKeyDown(temp.keycode, temp.keystring, temp.scancode) {
  switch (keycode) {
    case 219:  this.selectedid = (this.selectedid - 1) % this.rights.size();  break;
    case 220:  this.selectedid = (this.selectedid + 1) % this.rights.size();  break;
    default:   return;
  }
  player.chat = this.rights[this.selectedid];
} 


[gaben]

Originally Posted by 0PiX0

It's unnecessary to initialize a var to be set to 0. When incrementing, checking the condition 'this.i >= 0' is unnecessary. Also, you have the keys swapped.

Astram, I would use the method Crow described. In the end it should look somewhat like this:

PHP Code:

function GraalControl.onKeyDown(temp.keycode, temp.keystring, temp.scancode) {
  switch (keycode) {
    case 219:  this.selectedid = (this.selectedid - 1) % this.rights.size();  break;
    case 220:  this.selectedid = (this.selectedid + 1) % this.rights.size();  break;
    default:   return;
  }
  player.chat = this.rights[this.selectedid];
} 


wat?

PHP Code:

//#CLIENTSIDE

function onCreated(){
  this.rights = {"Stick","Unstick","Jail","Stealth"};
}


function onKeyPressed(code, key){ 
  if(key == "[" && this.i < 3){ 
         this.i++; // increment 
         player.chat = this.rights[this.i]; 
  } 
  else if(key == "/" && this.i > 0){ // don't decrement 0 to -1! 
        this.i--; 
        player.chat = this.rights[this.i]; 
  } 
} 


[furry_mougle]

Originally Posted by 0PiX0

It's unnecessary to initialize a var to be set to 0. When incrementing, checking the condition 'this.i >= 0' is unnecessary. Also, you have the keys swapped.

Astram, I would use the method Crow described. In the end it should look somewhat like this:

PHP Code:

function GraalControl.onKeyDown(temp.keycode, temp.keystring, temp.scancode) {
  switch (keycode) {
    case 219:  this.selectedid = (this.selectedid - 1) % this.rights.size();  break;
    case 220:  this.selectedid = (this.selectedid + 1) % this.rights.size();  break;
    default:   return;
  }
  player.chat = this.rights[this.selectedid];
} 


That returns as a NULL value, you know?

[Mark Sir Link]

please stop using thiso throughout this script, you clearly have no idea what its intent and purpose is for. I am sure you are having all sorts of scoping issues by calling it since thiso probably refers to a null object or the player itself when you are doing that.

PHP Code:

//#CLIENTSIDE
function onCreated(){
  this.rights = {"Drag", "Boots", "Blocks"};
  this.selected = 0;
}

function GraalControl.onKeyDown(temp.keycode, temp.keystring, temp.scancode){
  switch(keycode){
    case 219: this.selected = (this.selected - 1 < 0 ? 0 : this.selected-1); break;
    case 220: this.selected = (this.selected + 1 >= this.rights.size() ? this.rights.size() -1 : this.selected+1); break;
    default: return;
  }
  player.chat = this.rights[this.selected];
} 


or

PHP Code:

//#CLIENTSIDE
function onCreated(){
  this.rights = {"Drag", "Boots", "Blocks"};
  this.selected = 0;
}

function GraalControl.onKeyDown(temp.keycode, temp.keystring, temp.scancode){
  switch(keycode){
    case 219: this.selected = (this.selected - 1) % this.rights.size(); break;
    case 220: this.selected = (this.selected + 1) % this.rights.size(); break;
    default: return;
  }
  player.chat = this.rights[this.selected];
}