Simple Warp/Summon

[PhilSmith]

I think i covered most of your edits. I was confused by two of them:

1) check in all lowercase. I'm not really sure what the point of this was. Could you elaborate a little more on its purpose please?

2) the filter. I understand that it is a quicker way of checking than mine, but i just couldnt get it to work.

aside from those, I corrected the other parts and added the community name and clientside shared.chat.

PHP Code:

// Scripted by Phil Smith
function onActionServerSide(search, temp.action){
//for loop to find all players and their partial nicks
  temp.foundPlayers.destroy();
  for(temp.pl : allplayers){
    if(temp.pl.account.starts(search)|| temp.pl.communityName.starts(search) || temp.pl.nick.starts(search)){
      if (temp.pl.level!=NULL){ //if player is not on rc
        temp.foundPlayers.add(temp.pl); //logs the player into the array
      }
    }
  } 
  if (temp.foundPlayers.size()==1){
    onPlayerFound(temp.action, temp.foundPlayers[0]);
  }
  if(temp.foundPlayers.size()<1){
    player.chat="No Players Found!";
  }
  if(temp.foundPlayers.size()>1){
    triggerclient("weapon",this.name,"NoneFound",temp.foundPlayers);
  }
}
function onPlayerFound(temp.func, temp.pl){
  if (temp.func=="summon"){
    temp.pl.setlevel2(player.level.name,player.x,player.y);
  }
  else if(temp.func=="warp"){
    setlevel2(temp.pl.level,temp.pl.x,temp.pl.y);
  }
}
//#CLIENTSIDE
function onActionClientSide(temp.action, temp.chatarray){
  if(temp.action=="NoneFound"){
    shared.chat(temp.chatarray.size() SPC "Players Were Found!:");
    sleep(2);
    for(temp.i==0;temp.i<temp.chatarray.size();temp.i++){
      shared.chat(temp.chatarray[temp.i]);
      sleep(4);
    }
  }
}
function onPlayerChats(){
  if(player.chat.starts("/warp")){
    triggerserver("weapon",this.name,player.chat.substring(6),"warp");
  }
  if(player.chat.starts("/summon")){

    triggerserver("weapon",this.name,player.chat.substring(8),"summon");
  }
} 


[WhiteDragon]

Originally Posted by PhilSmith

[New Version]

Don't be afraid of using } else if {. It is best to be explicit about how your program 'branches' than force whoever is reading it to think about it themselves.

For example, temp.foundPlayers.size()==1 and temp.foundPlayers.size()<1 both clearly can never be true at the same time, but you should always make that clear just in case the conditions are not so clearly disjoint like they are here.


Also, temp.foundPlayers.destroy(); at the start of a function makes no sense. temp.foundPlayers won't even exist then. If you are going to use it as an array, it is best to create one at that point: temp.foundPlayers = {};


Regarding the filter thing, it's just an interesting note. Most people don't program like that in GS2, but I think more people should. The less code you write, the less that can go wrong.

If you're curious about it, let me know what you tried and I can hopefully tell you what went wrong.

[PhilSmith]

First, I normally do use else ifs. I dont know what i was doing with this one, but i must have forgot.
Second, my temp.foundPlayers.destroy() was me being dumb. I looked up on the wiki what i actually needed to put and fixed it. Idk why it is still there in this one...
third, i believe i put something like this:

PHP Code:

temp.f = function (temp.pl,search) {
    return (temp.pl.account.starts(search)|| temp.pl.communityname.starts(search)|| temp.pl.nick.starts(search) && temp.pl.level != NULL;
  };
  temp.foundPlayers = filter(temp.f, allplayers); 


search in this case was the string for the substring player.chat. In otherwords, the player i was searching for.

[fowlplay4]

Originally Posted by WhiteDragon

Regarding the filter thing, it's just an interesting note. Most people don't program like that in GS2, but I think more people should. The less code you write, the less that can go wrong.

I would totally use functions like filter more if they were built-in or at least able to implemented un-obtrusively.