Clean Coding - Common Sense

[xXziroXx]

I, too, think that example A looks better then example B.

A: if (var == true) { .... }
B: if (var) { .... }

[Rapidwolve]

Originally Posted by xXziroXx

I, too, think that example A looks better then example B.

A: if (var == true) { .... }
B: if (var) { .... }

Thats how I had it on my script first, I forgot why I changed it

[cbk1994]

Originally Posted by xXziroXx

I, too, think that example A looks better then example B.

A: if (var == true) { .... }
B: if (var) { .... }

C:

PHP Code:

if ( var == true )
{
    ...
} 


C seems better than both

[xXziroXx]

Originally Posted by cbkbud

C:

PHP Code:

if ( var == true )
{
    ...
} 


C seems better than both

No way! I only make new lines for brackets on functions. And I just dont like that way of spacing

[JkWhoSaysNi]

Me either. The spaces inside the ( brackets offend me too

Heres how I do it:

PHP Code:

if (var) {
       ...
} 


i guess if (var) has more meaning if you name your boolean variables as verbs as I tend to do e.g. if (finished)

[xXziroXx]

Originally Posted by JkWhoSaysNi

Me either. The spaces inside the ( brackets offend me too

Heres how I do it:

PHP Code:

if (var) {
       ...
} 


i guess if (var) has more meaning if you name your boolean variables as verbs as I tend to do e.g. if (finished)

Same as me then, although I would do:

PHP Code:

if (var == true) {
       ...
} 


[Skyld]

PHP Code:

if (var)
{
  // ...
} 


I don't see the point in putting var == true when that's already implied, and I prefer brackets on their own line. It improves spacing and clarity.

[Crow]

Originally Posted by Skyld

PHP Code:

if (var)
{
  // ...
} 


I don't see the point in putting var == true when that's already implied, and I prefer brackets on their own line. It improves spacing and clarity.

Lines++ ;/

[Skyld]

Originally Posted by Crow

Lines++ ;/

Doesn't really matter. The script will be folded into the same amount of bytecodes with new lines as it is with brackets on the same lines.

The fact is that it's clearer when I'm editing the script.

[JkWhoSaysNi]

That's not a fact it's entirely subjective :P

I think less lines is clearer. I think it's easier to see which statement a block belongs to when the opening bracket is on the same line.

[xXziroXx]

Originally Posted by JkWhoSaysNi

That's not a fact it's entirely subjective :P

I think less lines is clearer. I think it's easier to see which statement a block belongs to when the opening bracket is on the same line.

Agreed.

[Novo]

PHP Code:

function onKilled()
  {
  var;
  } 


I r bestest in Teh World!

[Skyld]

Originally Posted by JkWhoSaysNi

That's not a fact it's entirely subjective :P

Originally Posted by Skyld

The fact is that it's clearer when I'm editing the script.

I.

[Novo]

Originally Posted by Skyld

I.

I.

[cbk1994]

Originally Posted by Novo

I.

I.
--
Less lines? Really.

PHP Code:

//#CLIENTSIDE
function onCreated() { dothis(); thendothis(); thenletthis = "foo"; thendosomethingelse(); timetomilkthecow();doOTHERSTUFF()} function doOTHERSTUFF() { noWAI(); } function noWAI() { player.chat = "MUAHAHAHAHAHAHAH!"; } 


Whoah you're right, that's really neat and clean!