Clean Coding - Common Sense

[Inverness]

Originally Posted by xXziroXx

Your styling is practically the same as mine

Note how I use temp variables. It is something I began doing only recently and it makes the script look much more organized rather than using temp. repeatedly before all the temp variable names.

[xXziroXx]

Originally Posted by Inverness

Note how I use temp variables. It is something I began doing only recently and it makes the script look much more organized rather than using temp. repeatedly before all the temp variable names.

I use temp variables all the time too!

[Kristi]

Originally Posted by Inverness

Note how I use temp variables. It is something I began doing only recently and it makes the script look much more organized rather than using temp. repeatedly before all the temp variable names.

Um, you can't do that, when you say vars = something, you're actually assinging it to vars, not temp.vars

PHP Code:

function onCreated() {
  temp.hello;
  hello = 2;
  sendtorc("TEST:" @ temp.hello);
  sendtorc("TEST2:" @ hello);
} 


Yields the following:
The best idler is the (Server): TEST:
The best idler is the (Server): TEST2:2

note that temp.hello is still null. The only way to drop the temp is if the var was passed as a paremeter, it will take presedence over an already global var.

On another note, ziro, grey, and inver all have good styling imho

[Riot]

Originally Posted by Kristi

Um, you can't do that, when you say vars = something, you're actually assinging it to vars, not test vars

PHP Code:

function onCreated() {
  temp.hello;
  hello = 2;
  sendtorc("TEST:" @ temp.hello);
  sendtorc("TEST2:" @ hello);
} 


Yields the following:
The best idler is the (Server): TEST:
The best idler is the (Server): TEST2:2

note that temp.hello is still null.

On another note, ziro, grey, and inver all have good styling imho

I was about to comment on this too:

PHP Code:

function onCreated() {
  temp.i;
  
  i = 34;
  echo("onCreated(): i =" SPC i SPC "temp.i=" SPC temp.i);
  test();
  
  this.setTimer(1);
}

function onTimeout() {
  echo("onTimeout(): i =" SPC i);
}

function test() {
  echo("test(): i =" SPC i);
} 


Returns:

onCreated(): i = 34 temp.i= 
test(): i = 34
onTimeout(): i = 34